[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://mimedefang/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Template:
>  _Description: Should MIMEDefang use the embedded Perl interpreter? 
> + Choosing this option is generally safe and will significantly improve
> + performance. However some systems do not support it.

Add a comma:     However,

This ought to give a clue as to what kind of systems it's talking
about.  If it's really ones without eperl installed, I'd have
thought that dependency should be expressed as a Recommends/Suggests
in the control file, not here.

If the idea is that sysadmins might want to have eperl installed
without MIMEDefang automatically taking advantage of it, this
template should explain why you'd want to do that.

(And if sendmail is a hard dependency, that should be more than a
Recommends.)

Control:
> +Description: e-mail filter program for sendmail
> 
> I'm not sure whether we've settled on "email" vs "e-mail"....

I write "e-mail" (compare "A-bomb"), and the style manuals seem to
agree with me, but a lot of people don't; it's the kind of thing I
wouldn't "correct" in someone else's text. 

> +Description: create graphs from MIMEDefang's spam and virus logs  

Not a noun phrase.

   Description: MIMEDefang spam and virus log grapher

(Or maybe, less of a noun-pile, "grapher for MIMEDefang spam and virus
logs".)

> + GraphDefang is a configurable utility that parses arbitrary
> + syslog entries and creates a set of configurable charts (PNG files)
> + with the data. These files can be written on disk or displayed by a
> + web server through a CGI interface.

I'd say "written to disk".

> "a cgi" has no meaning --> "CGI interface" sounds better.

Except to those with an allergy to PIN-numberisms (like "ATM
machine", "HIV virus", or "SAT tests": CGI is short for Common
Gateway Interface).  But on the other hand, talking about displaying
graphics with CGI might make people think of Computer-Generated
Imagery!  How about:

    with the data. These files can be written to disk or displayed by a
    web server through a CGI script.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../mimedefang.old/debian/templates	2007-12-15 13:35:33.000000000 +0000
+++ debian/templates	2008-01-01 19:54:17.000000000 +0000
@@ -2,5 +2,5 @@
 Type: boolean
 Default: true
 _Description: Should MIMEDefang use the embedded Perl interpreter? 
- Choosing this option will significantly improve performance. However
- some systems do not support it. If in doubt, you can select this option.
+ Choosing this option is generally safe and will significantly improve
+ performance. However, some systems do not support it.
--- ../mimedefang.old/debian/control	2007-12-15 13:35:33.000000000 +0000
+++ debian/control	2008-01-01 19:57:45.000000000 +0000
@@ -10,21 +10,19 @@
 Depends: ${shlibs:Depends}, ${perl:Depends}, debconf (>= 0.5) | debconf-2.0, libmime-perl, libio-stringy-perl, libmime-base64-perl, libmailtools-perl, libdigest-sha1-perl, libunix-syslog-perl, psmisc, adduser
 Recommends: tk8.3 | wish, sendmail
 Suggests: libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, wv, libfile-scan-perl, clamav, libarchive-zip-perl, graphdefang
-Description: Electronic mail filter program for sendmail 8.12+
- MIMEDefang is an e-mail filter program which works with Sendmail 8.12
- and later.  MIMEDefang filters all e-mail messages sent via SMTP.
- MIMEDefang splits multi-part MIME messages into their components and
- potentially deletes or modifies the various parts.  It then
- reassembles the parts back into an e-mail message and sends it on its
- way.
+Description: e-mail filter program for sendmail
+ MIMEDefang is an e-mail filter program which processes all messages sent
+ via Sendmail. It splits multi-part MIME messages into their components
+ and can delete or modify those parts before reassembling the message and
+ sending it on its way.
 
 Package: graphdefang
 Architecture: any
 Depends: ${perl:Depends}, libfile-readbackwards-perl, libgd-graph-perl, libgd-text-perl (>= 0.86-1), libtimedate-perl, libmldbm-perl, perl (>= 5.8.3) | libstorable-perl
 Recommends: php5
 Suggests: mimedefang
-Description: create graphs of your mimedefang spam and virus logs
- GraphDefang is a configurable perl utility that parses arbitrary
- syslog entries and creates a set of configurable charts (png files)
- with the data. It is possible to output the png files to the
- filesystem or to a web browser via a cgi.
+Description: MIMEDefang spam and virus log grapher         
+ GraphDefang is a configurable utility that parses arbitrary
+ syslog entries and creates a set of configurable charts (PNG files)
+ with the data. These files can be written to disk or displayed by a
+ web server through a CGI script.
Template: mimedefang/embedperl
Type: boolean
Default: true
_Description: Should MIMEDefang use the embedded Perl interpreter? 
 Choosing this option is generally safe and will significantly improve
 performance. However, some systems do not support it.
Source: mimedefang
Section: mail
Priority: extra
Maintainer: Christoph Martin <christoph.martin@uni-mainz.de>
Build-Depends: debhelper (>= 5), libmilter-dev, mailx, libunix-syslog-perl, libperl-dev, libmime-perl, libdigest-sha1-perl, libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, libfile-scan-perl, libarchive-zip-perl
Standards-Version: 3.6.1

Package: mimedefang
Architecture: any
Depends: ${shlibs:Depends}, ${perl:Depends}, debconf (>= 0.5) | debconf-2.0, libmime-perl, libio-stringy-perl, libmime-base64-perl, libmailtools-perl, libdigest-sha1-perl, libunix-syslog-perl, psmisc, adduser
Recommends: tk8.3 | wish, sendmail
Suggests: libmail-spamassassin-perl, sanitizer, libhtml-parser-perl, wv, libfile-scan-perl, clamav, libarchive-zip-perl, graphdefang
Description: e-mail filter program for sendmail
 MIMEDefang is an e-mail filter program which processes all messages sent
 via Sendmail. It splits multi-part MIME messages into their components
 and can delete or modify those parts before reassembling the message and
 sending it on its way.

Package: graphdefang
Architecture: any
Depends: ${perl:Depends}, libfile-readbackwards-perl, libgd-graph-perl, libgd-text-perl (>= 0.86-1), libtimedate-perl, libmldbm-perl, perl (>= 5.8.3) | libstorable-perl
Recommends: php5
Suggests: mimedefang
Description: MIMEDefang spam and virus log grapher         
 GraphDefang is a configurable utility that parses arbitrary
 syslog entries and creates a set of configurable charts (PNG files)
 with the data. These files can be written to disk or displayed by a
 web server through a CGI script.

Reply to: