[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [LCFC] templates://fdutils/{templates}



Christian Perrier wrote:
> This is the last call for comments for the review of debconf
> templates for fdutils.

The following should be taken with a pinch of salt, since it's
national lowered-IQ day.

> Template: fdutils/fdmount_setuid
[...]
>  Such setting may have security implications in case of
>  vulnerabilities in the software's code.

I'd prefer:
   Such a setting may have security implications in the case of
   vulnerabilities in fdmount's code.

> Package: fdutils
[...]
>   - getfdprm: prints the current disk geometry (number of
>     sectors, track and heads etc);

s/etc)/etc.)/  

However, in the sentence-final case a few lines earlier I'm not
correcting "etc." to "etc.."... is this cheating?

[...]
>  Note that these utilities do not work for USB floppy drives, because
>  there is no direct access to the floppy controller.

In principle there's an ambiguity here.  Does fdutils fail to work
for USB FDs because (A) USB FDs don't permit the access that fdutils
always requires, or because (B) fdutils never has the access which
would be required specifically for USB?  It's A, so:

   Note that these utilities do not work for USB floppy drives, because
   these do not allow direct access to the floppy controller.
-- 
JBR	with qualifications in linguistics, experience as a Debian
	sysadmin, and probably no clue about this particular package
--- ../fdutils.old/debian/templates	2007-12-19 10:16:33.000000000 +0000
+++ debian/templates	2008-01-01 13:59:48.000000000 +0000
@@ -1,7 +1,10 @@
 Template: fdutils/fdmount_setuid
 Type: boolean
 Default: false
-_Description: Do you want to make fdmount set-user-id root?
- In order to enable ordinary users to mount a floppy disk using fdmount,
- fdmount needs to be set up as set-user-id root. Please note that this is
- usually considered to be a security hazard.
+_Description: Should fdmount be installed 'setuid root'?
+ In order to enable ordinary users to mount a floppy disk,
+ the fdmount program can be installed with the set-user-id bit set, so
+ that it will run with the permissions of the superuser.
+ .
+ Such a setting may have security implications in the case of
+ vulnerabilities in fdmount's code.
--- ../fdutils.old/debian/control	2007-12-19 10:16:33.000000000 +0000
+++ debian/control	2008-01-01 13:52:34.000000000 +0000
@@ -4,6 +4,7 @@
 Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
 Standards-Version: 3.7.2
 Build-Depends: debhelper (>= 5), texi2html, flex, tetex-bin, texinfo, po-debconf
+Homepage: http://www.tux.org/pub/knaff/fdutils/
 
 Package: fdutils
 Architecture: any
@@ -12,25 +13,23 @@
 Replaces: miscutils, manpages (<< 1.11-3)
 Description: Linux floppy utilities
  This package contains utilities for formatting extra capacity
- disks, for automatic floppy disk mounting and unmounting, etc.
+ disks, automatic floppy disk mounting and unmounting, etc.
  .
  The package includes the following items:
  .
-   * superformat: formats high capacity disks of (up to 1992k
-     for high density disks or up to 3984k for extra density
-     disks)
-   * fdmount: automatically mounts/unmounts disks when they are
-     inserted/removed.
-   * xdfcopy: formats, reads and writes OS/2's XDF disks.
-   * MAKEFLOPPIES: creates the floppy devices in /dev
-   * getfdprm: prints the current disk geometry (number of
-     sectors, track and heads etc)
-   * setfdprm: sets the current disk geometry
-   * fdrawcmd: sends raw commands to the floppy driver
-   * floppycontrol: configure the floppy driver
-   * General documentation about the floppy driver
+  - superformat: formats high capacity disks of (up to 1992k
+    for high density disks or up to 3984k for extra density
+     disks);
+  - fdmount: automatically mounts/unmounts disks when they are
+    inserted/removed;
+  - xdfcopy: formats, reads and writes OS/2's XDF disks;
+  - MAKEFLOPPIES: creates the floppy devices in /dev;
+  - getfdprm: prints the current disk geometry (number of
+    sectors, track and heads etc.);
+  - setfdprm: sets the current disk geometry;
+  - fdrawcmd: sends raw commands to the floppy driver;
+  - floppycontrol: configure the floppy driver;
+  - general documentation about the floppy driver.
  .
  Note that these utilities do not work for USB floppy drives, because
- there is no direct access to the floppy controller.
- .
-  Homepage: http://www.tux.org/pub/knaff/fdutils/
+ these do not allow direct access to the floppy controller.
Template: fdutils/fdmount_setuid
Type: boolean
Default: false
_Description: Should fdmount be installed 'setuid root'?
 In order to enable ordinary users to mount a floppy disk,
 the fdmount program can be installed with the set-user-id bit set, so
 that it will run with the permissions of the superuser.
 .
 Such a setting may have security implications in the case of
 vulnerabilities in fdmount's code.
Source: fdutils
Section: utils
Priority: optional
Maintainer: Anibal Monsalve Salazar <anibal@debian.org>
Standards-Version: 3.7.2
Build-Depends: debhelper (>= 5), texi2html, flex, tetex-bin, texinfo, po-debconf
Homepage: http://www.tux.org/pub/knaff/fdutils/

Package: fdutils
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, debianutils (>= 1.7)
Recommends: mtools (>= 3.8-1)
Replaces: miscutils, manpages (<< 1.11-3)
Description: Linux floppy utilities
 This package contains utilities for formatting extra capacity
 disks, automatic floppy disk mounting and unmounting, etc.
 .
 The package includes the following items:
 .
  - superformat: formats high capacity disks of (up to 1992k
    for high density disks or up to 3984k for extra density
     disks);
  - fdmount: automatically mounts/unmounts disks when they are
    inserted/removed;
  - xdfcopy: formats, reads and writes OS/2's XDF disks;
  - MAKEFLOPPIES: creates the floppy devices in /dev;
  - getfdprm: prints the current disk geometry (number of
    sectors, track and heads etc.);
  - setfdprm: sets the current disk geometry;
  - fdrawcmd: sends raw commands to the floppy driver;
  - floppycontrol: configure the floppy driver;
  - general documentation about the floppy driver.
 .
 Note that these utilities do not work for USB floppy drives, because
 these do not allow direct access to the floppy controller.

Reply to: