[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://ampache/{ampache.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Some further suggested changes for the control file:

> + Ampache is a web-based audio file manager. It is implemented with MySQL
> + and PHP. It allows viewing, editing, and playing audio files via the

>   web. It has support for playlists, artist and album views, album art,

"It is.  It does.  It has."

    Ampache is a web-based audio file manager implemented with PHP and MySQL
    which allows viewing, editing, and playing audio files via the web. It
    has support for playlists, artist and album views, album art, [...]

> + random play, playback via HTTP and on the fly transcoding and downsampling,
> + vote-based playback, Mpd and Icecast, integrated Flash player, as well
> + as per-user themes and song play tracking. Multiple 

A confusing feature list.  I imagine it's

* random or vote-based play
* per-user themes and (also per-user) play-tracking
* playback via
	(a) HTTP,
	(b) on-the-fly transcoding and downsampling
	(c) Mpd-and-Icecast,
	(d) integrated Flash player

In which case I'd have phrased it as something like:

    It has support for playlists, artist and album views, album art, random or
    vote-based play, and per-user play-tracking/theming. Playback may be via
    HTTP, on-the-fly transcoding and downsampling, Mpd/Icecast, or integrated
    Flash player.

> - Homepage: http://www.ampache.org
> +  Homepage: http://www.ampache.org
> 
> Current recommended way to mention upstream's home page until the use
> of a "Homepage:" field in debian/control is widely accepted.

(I think someone on debian-mentors was saying it's supported in dpkg
now, but that would just mean it's time to start using both...)
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../ampache.old/debian/ampache.templates	2007-09-15 12:25:49.000000000 +0100
+++ debian/ampache.templates	2007-09-19 22:44:40.000000000 +0100
@@ -1,10 +1,13 @@
 Template: ampache/configure-webserver
 Type: boolean
 Default: true
-_Description:  Configure Apache2 webserver? 
+_Description: Configure Apache 2 web server for use with Ampache? 
 
 
 Template: ampache/restart-webserver
 Type: boolean
 Default: true
-_Description:  Restart Apache2 webserver?
+_Description: Restart Apache2 web server?
+ The Apache 2 web server needs to be restarted to enable Ampache. Please
+ choose whether you want to restart it automatically now or do it yourself
+ later.
--- ../ampache.old/debian/control	2007-09-15 12:25:49.000000000 +0100
+++ debian/control	2007-09-20 00:17:48.000000000 +0100
@@ -9,14 +9,13 @@
 Architecture: all
 Depends: debconf (>= 0.5) | debconf-2.0, po-debconf, apache2-mpm-prefork, php5, php5-mysql, php5-gd, php5-cli
 Recommends: phpmyadmin, mysql-server-5.0
-Description: A web based audio file management system written in PHP
- Ampache is a Web-based Audio file manager. It is implemented with MySQL,
- and PHP. It allows you to view, edit, and play your audio files via the
- web. It has support for playlists, artist and album views, album art,
- random play, playback via Http/On the Fly Transcoding and Downsampling,
- Vote based playback, Mpd and Icecast, Integrated Flash Player, as well
- as per user themes and song play tracking. You can also Link multiple
- Ampache servers togeather using XML-RPC. Ampache supports GETTEXT
- translations and has a full translation of many languages.
+Description: web-based audio file management system
+ Ampache is a web-based audio file manager implemented with PHP and MySQL
+ which allows viewing, editing, and playing audio files via the web. It
+ has support for playlists, artist and album views, album art, random or
+ vote-based play, and per-user play-tracking/theming. Playback may be via
+ HTTP, on-the-fly transcoding and downsampling, Mpd/Icecast, or integrated
+ Flash player. Multiple Ampache servers can be linked together using
+ XML-RPC. Ampache is fully localized in many languages.
  .
- Homepage: http://www.ampache.org
+  Homepage: http://www.ampache.org
Template: ampache/configure-webserver
Type: boolean
Default: true
_Description: Configure Apache 2 web server for use with Ampache? 


Template: ampache/restart-webserver
Type: boolean
Default: true
_Description: Restart Apache2 web server?
 The Apache 2 web server needs to be restarted to enable Ampache. Please
 choose whether you want to restart it automatically now or do it yourself
 later.
Source: ampache
Section: web
Priority: optional
Maintainer: Charlie Smotherman <cjsmo@cableone.net>
Build-Depends: debhelper (>= 5)
Standards-Version: 3.7.2

Package: ampache
Architecture: all
Depends: debconf (>= 0.5) | debconf-2.0, po-debconf, apache2-mpm-prefork, php5, php5-mysql, php5-gd, php5-cli
Recommends: phpmyadmin, mysql-server-5.0
Description: web-based audio file management system
 Ampache is a web-based audio file manager implemented with PHP and MySQL
 which allows viewing, editing, and playing audio files via the web. It
 has support for playlists, artist and album views, album art, random or
 vote-based play, and per-user play-tracking/theming. Playback may be via
 HTTP, on-the-fly transcoding and downsampling, Mpd/Icecast, or integrated
 Flash player. Multiple Ampache servers can be linked together using
 XML-RPC. Ampache is fully localized in many languages.
 .
  Homepage: http://www.ampache.org

Reply to: