[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://ampache/{ampache.templates}



Please find, for review, the debconf templates and packages descriptions for the ampache source package.

This review will last from Wednesday, September 19, 2007 to Saturday, September 29, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../ampache.old/debian/ampache.templates	2007-09-15 11:34:38.975613163 +0200
+++ debian/ampache.templates	2007-09-19 18:35:41.418700707 +0200
@@ -1,10 +1,13 @@
 Template: ampache/configure-webserver
 Type: boolean
 Default: true
-_Description:  Configure Apache2 webserver? 
+_Description: Configure Apache 2 web server for use with Ampache? 

This question may come in the middle of other packages' installations
so better be more specific about why Apache 2 needs to be reconfigured...
 
 Template: ampache/restart-webserver
 Type: boolean
 Default: true
-_Description:  Restart Apache2 webserver?
+_Description: Restart Apache2 web server?
+ The Apache 2 web server needs to be restarted to enable Ampache. Please
+ choose whether you want to restart it automatically now or do it yourself
+ later.

About the same rationale, with a proposal to add some extra info to
explain why Apache needs to be restarted.


--- ../ampache.old/debian/control	2007-09-15 11:34:38.975613163 +0200
+++ debian/control	2007-09-19 07:08:42.552301334 +0200
@@ -9,14 +9,14 @@
 Architecture: all
 Depends: debconf (>= 0.5) | debconf-2.0, po-debconf, apache2-mpm-prefork, php5, php5-mysql, php5-gd, php5-cli
 Recommends: phpmyadmin, mysql-server-5.0
-Description: A web based audio file management system written in PHP
- Ampache is a Web-based Audio file manager. It is implemented with MySQL,
- and PHP. It allows you to view, edit, and play your audio files via the
+Description: web-based audio file management system

Use of leading articles is discouraged in shohrt descriptions.

The mention of the implementation details is also discouraged as this
adds no value for someone who quickly browses a packages list.


+ Ampache is a web-based audio file manager. It is implemented with MySQL
+ and PHP. It allows viewing, editing, and playing audio files via the

Consistent use of capitals.


  web. It has support for playlists, artist and album views, album art,
- random play, playback via Http/On the Fly Transcoding and Downsampling,
- Vote based playback, Mpd and Icecast, Integrated Flash Player, as well
- as per user themes and song play tracking. You can also Link multiple
- Ampache servers togeather using XML-RPC. Ampache supports GETTEXT
- translations and has a full translation of many languages.
+ random play, playback via HTTP and on the fly transcoding and downsampling,
+ vote-based playback, Mpd and Icecast, integrated Flash player, as well
+ as per-user themes and song play tracking. Multiple 
+ Ampache servers can be linked together using XML-RPC. Ampache is fully
+ localized in many languages.

consistent typography, mostly

Avoid to personnalize things ("You can")

No real need to mention how the application is localized as the most
important is the result: it is localized in many languages..:)

  .
- Homepage: http://www.ampache.org
+  Homepage: http://www.ampache.org

Current recommended way to mention upstream's home page until the use
of a "Homepage:" field in debian/control is widely accepted.

-- 


Template: ampache/configure-webserver
Type: boolean
Default: true
_Description: Configure Apache 2 web server for use with Ampache? 


Template: ampache/restart-webserver
Type: boolean
Default: true
_Description: Restart Apache2 web server?
 The Apache 2 web server needs to be restarted to enable Ampache. Please
 choose whether you want to restart it automatically now or do it yourself
 later.
--- ../ampache.old/debian/ampache.templates	2007-09-15 11:34:38.975613163 +0200
+++ debian/ampache.templates	2007-09-19 18:35:41.418700707 +0200
@@ -1,10 +1,13 @@
 Template: ampache/configure-webserver
 Type: boolean
 Default: true
-_Description:  Configure Apache2 webserver? 
+_Description: Configure Apache 2 web server for use with Ampache? 
 
 
 Template: ampache/restart-webserver
 Type: boolean
 Default: true
-_Description:  Restart Apache2 webserver?
+_Description: Restart Apache2 web server?
+ The Apache 2 web server needs to be restarted to enable Ampache. Please
+ choose whether you want to restart it automatically now or do it yourself
+ later.
--- ../ampache.old/debian/control	2007-09-15 11:34:38.975613163 +0200
+++ debian/control	2007-09-19 07:08:42.552301334 +0200
@@ -9,14 +9,14 @@
 Architecture: all
 Depends: debconf (>= 0.5) | debconf-2.0, po-debconf, apache2-mpm-prefork, php5, php5-mysql, php5-gd, php5-cli
 Recommends: phpmyadmin, mysql-server-5.0
-Description: A web based audio file management system written in PHP
- Ampache is a Web-based Audio file manager. It is implemented with MySQL,
- and PHP. It allows you to view, edit, and play your audio files via the
+Description: web-based audio file management system
+ Ampache is a web-based audio file manager. It is implemented with MySQL
+ and PHP. It allows viewing, editing, and playing audio files via the
  web. It has support for playlists, artist and album views, album art,
- random play, playback via Http/On the Fly Transcoding and Downsampling,
- Vote based playback, Mpd and Icecast, Integrated Flash Player, as well
- as per user themes and song play tracking. You can also Link multiple
- Ampache servers togeather using XML-RPC. Ampache supports GETTEXT
- translations and has a full translation of many languages.
+ random play, playback via HTTP and on the fly transcoding and downsampling,
+ vote-based playback, Mpd and Icecast, integrated Flash player, as well
+ as per-user themes and song play tracking. Multiple 
+ Ampache servers can be linked togeather using XML-RPC. Ampache is fully
+ localized in many languages.
  .
- Homepage: http://www.ampache.org
+  Homepage: http://www.ampache.org
Source: ampache
Section: web
Priority: optional
Maintainer: Charlie Smotherman <cjsmo@cableone.net>
Build-Depends: debhelper (>= 5)
Standards-Version: 3.7.2

Package: ampache
Architecture: all
Depends: debconf (>= 0.5) | debconf-2.0, po-debconf, apache2-mpm-prefork, php5, php5-mysql, php5-gd, php5-cli
Recommends: phpmyadmin, mysql-server-5.0
Description: web-based audio file management system
 Ampache is a web-based audio file manager. It is implemented with MySQL
 and PHP. It allows viewing, editing, and playing audio files via the
 web. It has support for playlists, artist and album views, album art,
 random play, playback via HTTP and on the fly transcoding and downsampling,
 vote-based playback, Mpd and Icecast, integrated Flash player, as well
 as per-user themes and song play tracking. Multiple 
 Ampache servers can be linked together using XML-RPC. Ampache is fully
 localized in many languages.
 .
  Homepage: http://www.ampache.org

Attachment: signature.asc
Description: Digital signature


Reply to: