[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://wacom-tools/{wacom-kernel-source.templates,wacom.po-temp lates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

> + A kernel-headers-* package fitting the currently running kernel
> + needs to be installed. Alternatively, a suitably configured kernel
> + source tree may replace it. Do not choose this option if none of these
> + are available.

I'd prefer something like

   This requires either a kernel-headers-* package fitting the currently
   running kernel or a suitably configured kernel source tree. Do not choose
   this option if neither of these is available.

(But what does "suitably configured" actually mean?  Is it talking
about an unpacked kernel source tree with an appropriate .config?)

> -_Description: What to do after module compilation
> +_Description: Operations needed ofter modules compilation

Typo: s/ofter/after/

>   The wacom-kernel-modules package will be built in /usr/src/modules. You will
> + have to install it yourself after it is created, with 'dpkg -i wacom-kernel-module-<version>.deb'. This operation cannot be done automatically.

Overlength lines; just say:

    The wacom-kernel-modules package will be built in /usr/src/modules,
    but not automatically installed. You will have to install it manually
    with 'dpkg -i wacom-kernel-module-<version>.deb'.

> + If the wacom-kernel-source package is updated later, th current opeations
> + will occur again, using your original answers.

Typos (thE current opeRations); but replace it with something like
"this procedure will be repeated".

+ This package may also replace some modules out of
+ the running kernel. An automated unloading of the HID module, with insertion
+ of the wacom module beneath it, would be unsafe and therefore not attempted.

Add an explicit "is" (instead of an implied "would be") -
                               would be unsafe and therefore is not attempted.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../wacom-tools.old/debian/wacom-kernel-source.templates	2007-09-11 11:22:21.000000000 +0100
+++ debian/wacom-kernel-source.templates	2007-09-11 22:09:14.000000000 +0100
@@ -1,100 +1,77 @@
 Template: wacom-kernel-source/module
 Type: boolean
 Default: true
-_Description:  Would you like the wacom modules to be compiled automatically?
- In order to make full use of a wacom graphics tablet you need to compile and
- install the provided modules to suit your running Linux kernel.
- .
- If you opt to do this, the wacom modules will be compiled into a Debian binary
- package using a local kernel configuration which you will be required to
- specify.  You must have either a kernel-headers-* package installed to suit
- the kernel you wish to use it with, or have a suitably configured kernel
- source tree available.  If you do not currently have either of these available
- you should choose not to do this at present.  Once you have suitable headers
- installed you can return to this selection with:
- .
- dpkg-reconfigure wacom-kernel-source
- .
- Alternatively, you might prefer to build it manually.  The source to do this
- can be found in /usr/src/modules/wacom.  You may use a tool like make-kpkg(1)
- or `fakeroot debian/rules kdist [ KSRC=... KVERS=... ]` to create
- a Debian package as above, or you can simply `configure && make` and install
- it by hand.
+_Description: Automatically compile the Wacom modules?
+ In order to make full use of a Wacom graphics tablet you need to compile and
+ install the provided modules to suit the running Linux kernel.
+ .
+ If you choose this option, the Wacom modules will be compiled into a
+ binary package using local kernel configuration settings.
+ .
+ This requires either a kernel-headers-* package fitting the currently
+ running kernel or a suitably configured kernel source tree. Do not choose
+ this option if neither of these is available.
+ .
+ Once these requirements are met, you can launch this setup step with
+ 'dpkg-reconfigure wacom-kernel-source'.
 
 Template: wacom-kernel-source/recompile
 Type: boolean
 Default: true
-_Description: Would you like to create a binary wacom-kernel-modules package now?
- If you opt to do this, the wacom modules will be compiled into a Debian binary
- package using a local kernel configuration which you will be required to
- specify.  You must have either a kernel-headers-* package installed to suit
- the kernel you wish to use it with, or have a suitably configured kernel
- source tree available.  If you do not currently have either of these available
- you should choose not to do this at present.  Once you have suitable headers
- installed you can return to this selection with:
- .
- dpkg-reconfigure wacom-kernel-source
- .
- Note this package may replace some modules that were originally built with
- your running kernel.  You should ensure the original modules can be replaced
- in the event of trouble before installing the resulting package.  Also if you
- have already built a wacom-kernel-modules package in this way using the same
- kernel version then that package may be overwritten.  You should rename or
- relocate it before continuing if you wish to preserve it.
+_Description: Create a binary wacom-kernel-modules package?
+ If you choose this option, the Wacom modules will be compiled into a
+ binary package using local kernel configuration settings.
+ .
+ This requires either a kernel-headers-* package fitting the currently
+ running kernel or a suitably configured kernel source tree. Do not choose
+ this option if neither of these is available.
+ .
+ Once these requirements are met, you can launch this setup step with
+ 'dpkg-reconfigure wacom-kernel-source'.
+ .
+ This may replace some modules that were originally built with
+ the running kernel.
 
 Template: wacom-kernel-source/kernel
 Type: string
 Default: /usr/src/linux/
-_Description: Linux headers location:
- You have choosen to compile the wacom modules, so you must specify the location
+_Description: Linux header files location:
+ In order to compile the Wacom modules, please enter the location
  of the Linux kernel headers for them to use.
  .
- When Linux headers are provided by a kernel-headers-* package, they reside in
+ Headers provided by a kernel-headers-* package are located in
  /usr/src/kernel-headers-*.
 
 Template: wacom-kernel-source/wrong_kernel
 Type: boolean
 Default: false
-_Description: Do you wish to specify a different Linux headers directory?
- The directory you have provided is not a valid Linux headers location.
+_Description: Specify a different Linux headers directory?
+ No valid Linux headers were found in the directory you specified.
 
 Template: wacom-kernel-source/module_location
 Type: note
-_Description: What to do after module compilation
- The wacom-kernel-modules package will be built in /usr/src/modules. You will
- have to install it yourself after it is created and can do so from that
- directory using:
- .
- dpkg -i wacom-kernel-module-<version>.deb
- .
- Unfortunately that cannot be done automatically at this stage because dpkg
- is not able to be called recursively.
- .
- Once the module package is installed, you probably won't need the
- wacom-kernel-source package anymore unless you plan to update your kernel
- again later.  In that case you can safely purge it completely with 'dpkg -P
- wacom-kernel-source'.  Otherwise, you will be able to rebuild the
- wacom-kernel-modules package in this manner at any time with `dpkg-reconfigure
- wacom-kernel-source`.  You will be prompted once again for the location of the
- kernel headers to use.
- .
- If you update the wacom-kernel-source package at some later time (or remove it
- without purging, then reinstall) the answers you have given here will be used
- to repeat this process and create a new module package for you to install.
+_Description: Operations needed after modules compilation
+ The wacom-kernel-modules package will be built in /usr/src/modules,
+ but not automatically installed. You will have to install it manually
+ with 'dpkg -i wacom-kernel-module-<version>.deb'.
+ .
+ The wacom-kernel-source package becomes useless once the module
+ package is installed, unless kernel upgrades happen later. 
+ .
+ If the wacom-kernel-source package is updated later, this procedure will be
+ repeated, using your original answers.
 
 Template: wacom-kernel-source/verbose
 Type: boolean
 Default: false
-_Description: Do you want to watch the module compilation progress?
+_Description: Follow the module compilation progress?
  The process of building a binary package may produce quite a lot of output.
- Seeing this output may be useful if you have problems with it building,
- or annoying if you don't want the extra noise.
+ It may be useful if problems arise during the build.
 
 Template: wacom-kernel-source/erase
 Type: boolean
 Default: false
-_Description: Do you want to delete the wacom-kernel-modules packages?
- There are binary wacom-kernel-modules packages left in /usr/src(/modules) that
- were generated from this package. Once you have manually installed them you
- don't need those packages anymore, though you may like to keep them for backup
- or re-installation purposes.
+_Description: Delete the wacom-kernel-modules packages?
+ Some binary wacom-kernel-modules packages were left in /usr/src(/modules).
+ Once they have been installed, they're not useful anymore and may be removed
+ unless you want to keep them for backup or re-installation purposes.
--- ../wacom-tools.old/debian/wacom.po-templates	2007-09-11 11:22:21.000000000 +0100
+++ debian/wacom.po-templates	2007-09-11 22:10:30.000000000 +0100
@@ -1,15 +1,17 @@
 Template: wacom-kernel-modules/moduleorder
 Type: note
-_Description: The wacom module must be loaded before the HID module.
- If the wacom driver is not loaded before the normal Linux HID driver then the
+Description: Load the wacom module before the HID module
+ If the wacom driver is not loaded before the normal Linux HID (Human Interface Driver), the
  HID will have already claimed the device as a generic mouse and the wacom
- driver will be ignored.  This package may also replace some modules out of
- your running kernel.  It is typically not safe for this installer to
- automatically unload the HID module and insert the wacom driver beneath it,
- nor to automatically remove any of the other affected modules.
- If you wish to install the wacom module without rebooting the machine you will
+ driver will be ignored. 
+ . 
+ This package may also replace some modules out of
+ the running kernel. An automated unloading of the HID module, with insertion
+ of the wacom module beneath it, would be unsafe and is therefore not attempted.
+ .
+ If you wish to install the wacom module without rebooting the machine, you will
  need to shut down all processes that use the HID module and its dependents and
- unload them manually before installing the wacom module.  The simplest thing to
+ unload them manually before installing the wacom module. The simplest thing to
  do is reboot the machine at some convenient opportunity after the package
  install is complete and let the new modules configuration determine the proper
  loading order.
--- ../wacom-tools.old/debian/control	2007-09-11 11:22:21.000000000 +0100
+++ debian/control	2007-09-11 21:56:41.000000000 +0100
@@ -9,33 +9,33 @@
 Section: devel
 Architecture: all
 Depends: build-essential, debhelper (>= 4.1.16), libx11-dev, ${misc:Depends}
-Description: source for the wacom binary modules
- This package provides the source code for the wacom kernel and X11 modules.
+Description: source for the Wacom binary modules
+ This package provides the source code for the Wacom kernel and X11 modules.
  You will need a kernel headers package or properly configured source for
- your running kernel to create the binary module package.
+ the running kernel to create the binary module package.
 
 Package: wacom-tools
 Section: utils
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: utilities for wacom tablets and other hid devices
- This package provides utilities to test and configure wacom graphics tablets.
+Description: utilities for Wacom tablets and other HID devices
+ This package provides utilities to test and configure Wacom graphics tablets.
  You will need kernel modules built from the wacom-kernel-source package to
- use them with such devices.  It also provides hotplug and udev scripts which
- may be useful without these tools and (later) with the wacom support in the
+ use them with such devices. It also provides hotplug and udev scripts which
+ may be useful without these tools and (later) with the Wacom support in the
  mainline kernel packages as well (2.6.11 or later).
 
 Package: xserver-xorg-input-wacom
 Section: x11
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: X.Org X server -- wacom input driver
- This package provides the driver for wacom tablet devices.
+Description: X.Org X server -- Wacom input driver
+ This package provides the driver for Wacom tablet devices.
  .
- Note that it is not a part of the X.Org distribution since X11R6, this driver
- is from the linuxwacom project.  See http://linuxwacom.sf.net for details.
+ Note that it is not a part of the X.Org distribution since X11R6: this driver
+ is from the linuxwacom project. See http://linuxwacom.sf.net for details.
  .
- You will also require a kernel module which supports your tablet.  Many types
- are supported by the module supplied with current Linux kernels.  If yours is
+ You will also require a kernel module which supports your tablet. Many types
+ are supported by the module supplied with current Linux kernels. If yours is
  not one of them (yet), see the wacom-kernel-source package for the most up to
  date module available.
Template: wacom-kernel-source/module
Type: boolean
Default: true
_Description: Automatically compile the Wacom modules?
 In order to make full use of a Wacom graphics tablet you need to compile and
 install the provided modules to suit the running Linux kernel.
 .
 If you choose this option, the Wacom modules will be compiled into a
 binary package using local kernel configuration settings.
 .
 This requires either a kernel-headers-* package fitting the currently
 running kernel or a suitably configured kernel source tree. Do not choose
 this option if neither of these is available.
 .
 Once these requirements are met, you can launch this setup step with
 'dpkg-reconfigure wacom-kernel-source'.

Template: wacom-kernel-source/recompile
Type: boolean
Default: true
_Description: Create a binary wacom-kernel-modules package?
 If you choose this option, the Wacom modules will be compiled into a
 binary package using local kernel configuration settings.
 .
 This requires either a kernel-headers-* package fitting the currently
 running kernel or a suitably configured kernel source tree. Do not choose
 this option if neither of these is available.
 .
 Once these requirements are met, you can launch this setup step with
 'dpkg-reconfigure wacom-kernel-source'.
 .
 This may replace some modules that were originally built with
 the running kernel.

Template: wacom-kernel-source/kernel
Type: string
Default: /usr/src/linux/
_Description: Linux header files location:
 In order to compile the Wacom modules, please enter the location
 of the Linux kernel headers for them to use.
 .
 Headers provided by a kernel-headers-* package are located in
 /usr/src/kernel-headers-*.

Template: wacom-kernel-source/wrong_kernel
Type: boolean
Default: false
_Description: Specify a different Linux headers directory?
 No valid Linux headers were found in the directory you specified.

Template: wacom-kernel-source/module_location
Type: note
_Description: Operations needed after modules compilation
 The wacom-kernel-modules package will be built in /usr/src/modules,
 but not automatically installed. You will have to install it manually
 with 'dpkg -i wacom-kernel-module-<version>.deb'.
 .
 The wacom-kernel-source package becomes useless once the module
 package is installed, unless kernel upgrades happen later. 
 .
 If the wacom-kernel-source package is updated later, this procedure will be
 repeated, using your original answers.

Template: wacom-kernel-source/verbose
Type: boolean
Default: false
_Description: Follow the module compilation progress?
 The process of building a binary package may produce quite a lot of output.
 It may be useful if problems arise during the build.

Template: wacom-kernel-source/erase
Type: boolean
Default: false
_Description: Delete the wacom-kernel-modules packages?
 Some binary wacom-kernel-modules packages were left in /usr/src(/modules).
 Once they have been installed, they're not useful anymore and may be removed
 unless you want to keep them for backup or re-installation purposes.
Template: wacom-kernel-modules/moduleorder
Type: note
Description: Load the wacom module before the HID module
 If the wacom driver is not loaded before the normal Linux HID (Human Interface Driver), the
 HID will have already claimed the device as a generic mouse and the wacom
 driver will be ignored. 
 . 
 This package may also replace some modules out of
 the running kernel. An automated unloading of the HID module, with insertion
 of the wacom module beneath it, would be unsafe and is therefore not attempted.
 .
 If you wish to install the wacom module without rebooting the machine, you will
 need to shut down all processes that use the HID module and its dependents and
 unload them manually before installing the wacom module. The simplest thing to
 do is reboot the machine at some convenient opportunity after the package
 install is complete and let the new modules configuration determine the proper
 loading order.
Source: wacom-tools
Section: graphics
Priority: optional
Maintainer: Ron Lee <ron@debian.org>
Build-Depends: debhelper (>= 5.0.0), po-debconf, xserver-xorg-dev, libxi-dev, libxt-dev, libncurses5-dev
Standards-Version: 3.7.2.2

Package: wacom-kernel-source
Section: devel
Architecture: all
Depends: build-essential, debhelper (>= 4.1.16), libx11-dev, ${misc:Depends}
Description: source for the Wacom binary modules
 This package provides the source code for the Wacom kernel and X11 modules.
 You will need a kernel headers package or properly configured source for
 the running kernel to create the binary module package.

Package: wacom-tools
Section: utils
Architecture: any
Depends: ${shlibs:Depends}
Description: utilities for Wacom tablets and other HID devices
 This package provides utilities to test and configure Wacom graphics tablets.
 You will need kernel modules built from the wacom-kernel-source package to
 use them with such devices. It also provides hotplug and udev scripts which
 may be useful without these tools and (later) with the Wacom support in the
 mainline kernel packages as well (2.6.11 or later).

Package: xserver-xorg-input-wacom
Section: x11
Architecture: any
Depends: ${shlibs:Depends}
Description: X.Org X server -- Wacom input driver
 This package provides the driver for Wacom tablet devices.
 .
 Note that it is not a part of the X.Org distribution since X11R6: this driver
 is from the linuxwacom project. See http://linuxwacom.sf.net for details.
 .
 You will also require a kernel module which supports your tablet. Many types
 are supported by the module supplied with current Linux kernels. If yours is
 not one of them (yet), see the wacom-kernel-source package for the most up to
 date module available.

Reply to: