Re: [RFR] templates://libpam-mount/{libpam-mount.templates}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
> Template: libpam-mount/convert-xml-config
[...]
> +_Description: Convert libpam-mount configuration automatically?
> + The configuration format of libpam-mount changed to a new XML-based
> + format.
Make that "has changed" (or am I being en_GBish?). And surely it's
genuine XML, not merely XML-based.
> + It can be converted automatically now with the
> + '/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'
> + script. The old configuration /etc/security/pam_mount.conf will be
This is one of those cases where I'd say "the script X" instead of
"the X script" (because X is a previously unfamiliar uniquely
identifying name rather than a description of a kind of script).
In the control file:
> Description: PAM module that can mount volumes for a user session
> + This package provides a PAM module that is aimed at environments with SMB (Samba or Windows NT)
> or NCP (Netware or Mars-NWE) servers that Unix users wish to access
> + transparently.
Does it really mean Windows NT as opposed to Windows Server/XP?
Mars-NWE is wildly obscure too, and GNU/Linux is not UNIX. Besides,
users don't exactly "wish to access NCP servers transparently" -
they just want to access their files. It's the admin who's wishing
for transparent ncpfs access.
This module is aimed at environments with Windows/SAMBA or Netware
fileservers which should be transparently accessible to Linux users.
(I've also trimmed a superfluous reference to PAM. The keywords SMB
and NCP still occur later in the description.)
> + transparently. It facilitates access to such private volumes.
> + The module also supports mounting home directories using
> loopback or dm-crypt encrypted filesystems.
>
> s/of these types/such: better English, Justin?
I don't much like that sentence either way - it seems unhelpful.
Nobody's going to be using the search keywords "facilitates access";
couldn't it just say:
It supports automounting of private volumes, including mounting of
home directories on loopback or dm-crypt encrypted filesystems.
> + - access to each user's own volumes;
These bullet-points are good, but the switch to a bulleted list is a
bit abrupt; there's an implied introduction along the lines of "Its
features include:". But it can't quite be that. Oh, well, I'll
leave it implied.
> + - unmounting at logout, saving system's resources and mandatory for
> + the use with encrypted filesystems.
This last one does need tweaking:
- unmounting at logout, saving system resources (and mandatory for
encrypted filesystems)
> + Libpam-mount is able to mount SMB or NCP volumes as well as any type of
> + filesystem that can be mounted using the standard mount command.
>
> Improve English?
Perhaps s/is able to/can/; but I think it works okay as it is.
--
JBR with qualifications in linguistics, experience as a Debian
sysadmin, and probably no clue about this particular package
--- ../libpam-mount.old/debian/libpam-mount.templates 2007-12-14 08:35:13.000000000 +0000
+++ debian/libpam-mount.templates 2007-12-16 13:28:54.000000000 +0000
@@ -1,13 +1,14 @@
Template: libpam-mount/convert-xml-config
Type: boolean
Default: false
-_Description: Automatic conversion to new XML configuration?
- The configuration format of libpam-mount changed and can be converted
- automatically with the `convert_pam_mount_conf.pl' script found
- in /usr/share/doc/libpam-mount/examples/. The old configuration
- /etc/security/pam_mount.conf will not be changed.
+_Description: Convert libpam-mount configuration automatically?
+ The configuration format of libpam-mount has changed to a new XML
+ format.
.
- You can also convert the old configuration manually.
+ It can be converted automatically now with the script
+ '/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'.
+ The old configuration /etc/security/pam_mount.conf will be
+ kept unmodified.
.
- You should in all cases check the converted XML configuration file
- to avoid errors in the login process.
+ If you choose to convert the configuration automatically, the newly
+ generated file should be checked to prevent login errors.
--- ../libpam-mount.old/debian/control 2007-12-14 08:35:15.000000000 +0000
+++ debian/control 2007-12-16 13:26:31.000000000 +0000
@@ -17,21 +17,16 @@
davfs2, lsof, psmisc
Conflicts: libncp (<< 2.2.0.19.10)
Description: PAM module that can mount volumes for a user session
- This module is aimed at environments with SMB (Samba or Windows NT)
- or NCP (Netware or Mars-NWE) servers that Unix users wish to access
- transparently. It facilitates access to private volumes of these types
- well. The module also supports mounting home directories using
- loopback or dm-crypt encrypted filesystems.
+ This module is aimed at environments with Windows/SAMBA or Netware
+ fileservers which should be transparently accessible to Linux users.
.
- o Every user can access his own volumes.
- o The user needs to type the password just once (at login).
- o The mounting process is transparent to the users.
- o There is no need to keep the login passwords in any additional file.
- o The volumes are unmounted upon logout, so it saves system resources,
- avoiding the need of listing every possibly useful remote volume
- in /etc/fstab or in an automount/supermount config file. This
- is also necessary for securing encrypted filesystems.
+ - access to each user's own volumes;
+ - single sign-on features;
+ - transparent mounting process;
+ - no stored passwords;
+ - unmounting at logout, saving system resources (and mandatory for
+ encrypted filesystems).
.
- Libpam-mount "understands" SMB, NCP, and any type of filesystem that
- can be mounted using the standard mount command.
+ Libpam-mount is able to mount SMB or NCP volumes as well as any type of
+ filesystem that can be mounted using the standard mount command.
Template: libpam-mount/convert-xml-config
Type: boolean
Default: false
_Description: Convert libpam-mount configuration automatically?
The configuration format of libpam-mount has changed to a new XML
format.
.
It can be converted automatically now with the script
'/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'.
The old configuration /etc/security/pam_mount.conf will be
kept unmodified.
.
If you choose to convert the configuration automatically, the newly
generated file should be checked to prevent login errors.
Source: libpam-mount
Section: admin
Priority: extra
Maintainer: Bastian Kleineidam <calvin@debian.org>
Build-Depends: debhelper (>= 5), libpam0g-dev, libssl-dev, cdbs, dpatch,
zlib1g-dev | libz-dev, libhx-dev, libxml2-dev
Standards-Version: 3.7.2
Homepage: http://pam-mount.sourceforge.net/
Vcs-Svn: https://pam-mount.svn.sourceforge.net/svnroot/pam-mount/trunk
Vcs-Browser: http://pam-mount.svn.sourceforge.net/viewvc/pam-mount/trunk/
Package: libpam-mount
Section: admin
Architecture: any
Depends: ${shlibs:Depends}, mount (>= 2.12-3), libxml-writer-perl, debconf
Suggests: ncpfs, smbfs, cryptsetup, openssl, fuse-utils, truecrypt-utils,
davfs2, lsof, psmisc
Conflicts: libncp (<< 2.2.0.19.10)
Description: PAM module that can mount volumes for a user session
This module is aimed at environments with Windows/SAMBA or Netware
fileservers which should be transparently accessible to Linux users.
.
- access to each user's own volumes;
- single sign-on features;
- transparent mounting process;
- no stored passwords;
- unmounting at logout, saving system resources (and mandatory for
encrypted filesystems).
.
Libpam-mount is able to mount SMB or NCP volumes as well as any type of
filesystem that can be mounted using the standard mount command.
Reply to: