[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://libpam-mount/{libpam-mount.templates}



Please find, for review, the debconf templates and packages descriptions for the libpam-mount source package.

This review will last from Sunday, December 16, 2007 to Wednesday, December 26, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../libpam-mount.old/debian/libpam-mount.templates	2007-12-01 12:53:42.360487692 +0530
+++ debian/libpam-mount.templates	2007-12-14 12:06:00.541763341 +0530
@@ -1,13 +1,14 @@
 Template: libpam-mount/convert-xml-config
 Type: boolean
 Default: false
-_Description: Automatic conversion to new XML configuration?
- The configuration format of libpam-mount changed and can be converted
- automatically with the `convert_pam_mount_conf.pl' script found
- in /usr/share/doc/libpam-mount/examples/. The old configuration
- /etc/security/pam_mount.conf will not be changed.
+_Description: Convert libpam-mount configuration automatically?
+ The configuration format of libpam-mount changed to a new XML-based
+ format.

Give details in the long description and the most important question
in the short one.

  .
- You can also convert the old configuration manually.
+ It can be converted automatically now with the
+ '/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'
+ script. The old configuration /etc/security/pam_mount.conf will be
+ kept unmodified.

Use passive voice as the user will not run the automatic conversion.

Simplify the sentence (or at least try to)

  .
- You should in all cases check the converted XML configuration file
- to avoid errors in the login process.
+ If you choose to convert the configuration automatically, the newly
+ generated file should be checked to prevent login errors.

Neutral wording.


--- ../libpam-mount.old/debian/control	2007-12-01 12:53:42.360487692 +0530
+++ debian/control	2007-12-14 12:09:43.030472961 +0530
@@ -17,21 +17,19 @@
  davfs2, lsof, psmisc
 Conflicts: libncp (<< 2.2.0.19.10)
 Description: PAM module that can mount volumes for a user session
- This module is aimed at environments with SMB (Samba or Windows NT)
+ This package provides a PAM module that is aimed at environments with SMB (Samba or Windows NT)
  or NCP (Netware or Mars-NWE) servers that Unix users wish to access
- transparently. It facilitates access to private volumes of these types
- well. The module also supports mounting home directories using
+ transparently. It facilitates access to such private volumes.
+ The module also supports mounting home directories using
  loopback or dm-crypt encrypted filesystems.

s/of these types/such: better English, Justin?

  .
-  o Every user can access his own volumes.
-  o The user needs to type the password just once (at login).
-  o The mounting process is transparent to the users.
-  o There is no need to keep the login passwords in any additional file.
-  o The volumes are unmounted upon logout, so it saves system resources,
-    avoiding the need of listing every possibly useful remote volume
-    in /etc/fstab or in an automount/supermount config file. This
-    is also necessary for securing encrypted filesystems.
+  - access to each user's own volumes;
+  - single sign-on features;
+  - transparent mounting process;
+  - no stored passwords;
+  - unmounting at logout, saving system's resources and mandatory for
+    the use with encrypted filesystems.

Standardize enumeration style

  .
- Libpam-mount "understands" SMB, NCP, and any type of filesystem that
- can be mounted using the standard mount command.
+ Libpam-mount is able to mount SMB or NCP volumes as well as any type of
+ filesystem that can be mounted using the standard mount command.
 
Improve English?

PS: I really should have a look at this package. Apparently, I may
have some use cases for it.

-- 


Template: libpam-mount/convert-xml-config
Type: boolean
Default: false
_Description: Convert libpam-mount configuration automatically?
 The configuration format of libpam-mount changed to a new XML-based
 format.
 .
 It can be converted automatically now with the
 '/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'
 script. The old configuration /etc/security/pam_mount.conf will be
 kept unmodified.
 .
 If you choose to convert the configuration automatically, the newly
 generated file should be checked to prevent login errors.
--- ../libpam-mount.old/debian/libpam-mount.templates	2007-12-01 12:53:42.360487692 +0530
+++ debian/libpam-mount.templates	2007-12-14 12:06:00.541763341 +0530
@@ -1,13 +1,14 @@
 Template: libpam-mount/convert-xml-config
 Type: boolean
 Default: false
-_Description: Automatic conversion to new XML configuration?
- The configuration format of libpam-mount changed and can be converted
- automatically with the `convert_pam_mount_conf.pl' script found
- in /usr/share/doc/libpam-mount/examples/. The old configuration
- /etc/security/pam_mount.conf will not be changed.
+_Description: Convert libpam-mount configuration automatically?
+ The configuration format of libpam-mount changed to a new XML-based
+ format.
  .
- You can also convert the old configuration manually.
+ It can be converted automatically now with the
+ '/usr/share/doc/libpam-mount/examples/convert_pam_mount_conf.pl'
+ script. The old configuration /etc/security/pam_mount.conf will be
+ kept unmodified.
  .
- You should in all cases check the converted XML configuration file
- to avoid errors in the login process.
+ If you choose to convert the configuration automatically, the newly
+ generated file should be checked to prevent login errors.
--- ../libpam-mount.old/debian/control	2007-12-01 12:53:42.360487692 +0530
+++ debian/control	2007-12-14 12:09:43.030472961 +0530
@@ -17,21 +17,19 @@
  davfs2, lsof, psmisc
 Conflicts: libncp (<< 2.2.0.19.10)
 Description: PAM module that can mount volumes for a user session
- This module is aimed at environments with SMB (Samba or Windows NT)
+ This package provides a PAM module that is aimed at environments with SMB (Samba or Windows NT)
  or NCP (Netware or Mars-NWE) servers that Unix users wish to access
- transparently. It facilitates access to private volumes of these types
- well. The module also supports mounting home directories using
+ transparently. It facilitates access to such private volumes.
+ The module also supports mounting home directories using
  loopback or dm-crypt encrypted filesystems.
  .
-  o Every user can access his own volumes.
-  o The user needs to type the password just once (at login).
-  o The mounting process is transparent to the users.
-  o There is no need to keep the login passwords in any additional file.
-  o The volumes are unmounted upon logout, so it saves system resources,
-    avoiding the need of listing every possibly useful remote volume
-    in /etc/fstab or in an automount/supermount config file. This
-    is also necessary for securing encrypted filesystems.
+  - access to each user's own volumes;
+  - single sign-on features;
+  - transparent mounting process;
+  - no stored passwords;
+  - unmounting at logout, saving system's resources and mandatory for
+    the use with encrypted filesystems.
  .
- Libpam-mount "understands" SMB, NCP, and any type of filesystem that
- can be mounted using the standard mount command.
+ Libpam-mount is able to mount SMB or NCP volumes as well as any type of
+ filesystem that can be mounted using the standard mount command.
 
Source: libpam-mount
Section: admin
Priority: extra
Maintainer: Bastian Kleineidam <calvin@debian.org>
Build-Depends: debhelper (>= 5), libpam0g-dev, libssl-dev, cdbs, dpatch,
 zlib1g-dev | libz-dev, libhx-dev, libxml2-dev
Standards-Version: 3.7.2
Homepage: http://pam-mount.sourceforge.net/
Vcs-Svn: https://pam-mount.svn.sourceforge.net/svnroot/pam-mount/trunk
Vcs-Browser: http://pam-mount.svn.sourceforge.net/viewvc/pam-mount/trunk/

Package: libpam-mount
Section: admin
Architecture: any
Depends: ${shlibs:Depends}, mount (>= 2.12-3), libxml-writer-perl, debconf
Suggests: ncpfs, smbfs, cryptsetup, openssl, fuse-utils, truecrypt-utils,
 davfs2, lsof, psmisc
Conflicts: libncp (<< 2.2.0.19.10)
Description: PAM module that can mount volumes for a user session
 This package provides a PAM module that is aimed at environments with SMB (Samba or Windows NT)
 or NCP (Netware or Mars-NWE) servers that Unix users wish to access
 transparently. It facilitates access to such private volumes.
 The module also supports mounting home directories using
 loopback or dm-crypt encrypted filesystems.
 .
  - access to each user's own volumes;
  - single sign-on features;
  - transparent mounting process;
  - no stored passwords;
  - unmounting at logout, saving system's resources and mandatory for
    the use with encrypted filesystems.
 .
 Libpam-mount is able to mount SMB or NCP volumes as well as any type of
 filesystem that can be mounted using the standard mount command.

Attachment: signature.asc
Description: Digital signature


Reply to: