[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://libapache2-mod-python/{libapache2-mod-python.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

A one-liner, so maybe this time I'll get it right on the first
attempt. 

> + The mod_python module must be enabled if hosted web sites are using
> + its features.
[...]
> 
> "websites". I know about the tendency in English to merge many words
> together, but I think that one goes a little bit far away. Opinions
> from other reviewers?

I'm used to "website", but I seem to be (barely) in the minority:
"web.site" gets 1.65 gigaGooglehits, 227 "apt-cache search" hits;
"website" gets 0.942 gigaGooglehits, 195 "apt-cache search" hits.

> -Description: Apache 2 module that embeds Python within the server
> - mod_python allows you to write web-based applications in Python.
> +Description: Python-embedding module for Apache 2
> + The mod_python modules allows writing web-based applications in Python.

"Module" (singular, hence "allows").

Mind you, it's not true; I installed it myself just now, and it
hasn't modified my ability to write Python code.  The thing it
allows is *running* Python code!  And what's that "based" doing
here, anyway?  Make it:

    The mod_python module supports web applications written in Python.

-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../libapache2-mod-python.old/debian/libapache2-mod-python.templates	2007-10-20 11:20:54.000000000 +0100
+++ debian/libapache2-mod-python.templates	2007-10-24 08:09:44.000000000 +0100
@@ -1,10 +1,11 @@
 Template: libapache2-mod-python/enable_module
 Type: boolean
 _Description: Enable the Apache 2 mod_python module?
- You need to enable the module to use websites written for mod_python.
+ The mod_python module must be enabled if hosted web sites are using
+ its features.
  .
- Choosing to enable the module creates a symbolic link for mod_python
- in /etc/apache2/mods_enabled/, chosing to not enable the module removes
- that link.
+ If you choose this option, a symbolic link for mod_python will be created
+ in /etc/apache2/mods_enabled/. If you refuse this option, this link
+ will be removed if it exists.
  .
- NB. You will need to restart Apache 2 manually after changing this option.
+ Apache 2 must be restarted manually after changing this option.
--- ../libapache2-mod-python.old/debian/control	2007-10-20 11:20:54.000000000 +0100
+++ debian/control	2007-10-24 08:11:27.000000000 +0100
@@ -17,19 +17,19 @@
 Replaces: libapache2-mod-python2.4 (<< 3.2.8-3), libapache2-mod-python2.3 (<< 3.2.8-3)
 Conflicts: libapache2-mod-python2.4, libapache2-mod-python2.3, libapache2-mod-python2.2, libapache-mod-python, libapache-mod-python2.1, libapache-mod-python2.2, libapache-mod-python2.3
 XB-Python-Version: ${python:Versions}
-Description: Apache 2 module that embeds Python within the server
- mod_python allows you to write web-based applications in Python.
+Description: Python-embedding module for Apache 2
+ The mod_python module supports web applications written in Python.
  Because the parser is embedded in the server as an Apache module, it
- will run many times faster than traditional CGI.
+ will run much faster than traditional CGI.
  .
  This package is built for the current Python version.
 
 Package: libapache2-mod-python-doc
 Architecture: all
 Suggests: www-browser
-Description: Apache 2 module that embeds Python within the server
- mod_python allows you to write web-based applications in Python.
+Description: Python-embedding module for Apache 2 - documentation
+ The mod_python module supports web applications written in Python.
  Because the parser is embedded in the server as an Apache module, it
- will run many times faster than traditional CGI scripts.
+ will run much faster than traditional CGI.
  .
  This package contains the module documentation in HTML format.
Template: libapache2-mod-python/enable_module
Type: boolean
_Description: Enable the Apache 2 mod_python module?
 The mod_python module must be enabled if hosted web sites are using
 its features.
 .
 If you choose this option, a symbolic link for mod_python will be created
 in /etc/apache2/mods_enabled/. If you refuse this option, this link
 will be removed if it exists.
 .
 Apache 2 must be restarted manually after changing this option.
Source: libapache2-mod-python
Section: python
Priority: optional
Maintainer: Debian Python Modules Team <python-modules-team@lists.alioth.debian.org>
Uploaders: Norbert Tretkowski <nobse@debian.org>, Piotr Ożarowski <piotr@debian.org>, Robert S. Edmonds <edmonds@debian.org>
Build-Depends: debhelper (>= 5.0.38), debconf, autoconf, python-dev (>= 2.4.3-11), apache2-threaded-dev (>= 2.2.3-1), dpatch, python-central (>= 0.5.6), po-debconf
XS-Python-Version: current
XS-Vcs-Svn: svn://svn.debian.org/python-modules/packages/libapache2-mod-python/trunk/
XS-Vcs-Browser: http://svn.debian.org/wsvn/python-modules/packages/libapache2-mod-python/?op=log
Standards-Version: 3.7.2.1
 
Package: libapache2-mod-python
Architecture: any
Depends: ${python:Depends}, debconf | debconf-2.0, ${shlibs:Depends}, apache2.2-common, apache2
Suggests: libapache2-mod-python-doc
Provides: ${python:Provides}, libapache2-mod-python${python:Versions}
Replaces: libapache2-mod-python2.4 (<< 3.2.8-3), libapache2-mod-python2.3 (<< 3.2.8-3)
Conflicts: libapache2-mod-python2.4, libapache2-mod-python2.3, libapache2-mod-python2.2, libapache-mod-python, libapache-mod-python2.1, libapache-mod-python2.2, libapache-mod-python2.3
XB-Python-Version: ${python:Versions}
Description: Python-embedding module for Apache 2
 The mod_python module supports web applications written in Python.
 Because the parser is embedded in the server as an Apache module, it
 will run much faster than traditional CGI.
 .
 This package is built for the current Python version.

Package: libapache2-mod-python-doc
Architecture: all
Suggests: www-browser
Description: Python-embedding module for Apache 2 - documentation
 The mod_python module supports web applications written in Python.
 Because the parser is embedded in the server as an Apache module, it
 will run much faster than traditional CGI.
 .
 This package contains the module documentation in HTML format.

Reply to: