Re: [RFR] templates://flex/{templates.master}
Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
Starting in the control file:
> + This package provides flex, a tool for generating scanners: programs which recognized lexical
> + patterns in text. It reads the given input files for a description of a
If we're treating "Flex" as the "project name" elsewhere, there's no
particular reason to worry about its sentence-initial position here.
Plus, tense error ("recognized"). And this seems more of a job for
parentheses:
Flex is a tool for generating scanners (programs which recognize
lexical patterns in text). It [...]
> + The behavior of Flex has undergone a major change since version
> + 2.5.4a; Flex scanners are now reentrant, allowing to have multiple
> scanners in the same program with differing sets of defaults, and
> they play nicer with modern C and C++ compilers. [...]
s/allowing to have/allowing/, but there's also a problem here that
I'm less sure about. There are two different versions of this
description (one here in the control file and one in the template),
with slightly diverging content. The version above seems to say
that there's just one big change in Flex 2.5.5, reentrancy (with
implications). On the other hand, going back to the template file,
flex/upgrade/pre_2.5.5 has a subtly different phrasing:
> [...] There have been extensive changes. Flex scanners
> + are now reentrant, you may have multiple scanners in
> the same program with differing sets of defaults, and
> they play nicer with modern C and C++ compilers. [...]
...which implies it's "changes, including A and B and C". My patch
works on the assumption that the control file is canonical and
corrects both to:
The behavior of Flex has undergone a major change since version
2.5.4a. Flex scanners are now reentrant: there can be multiple
scanners in the same program with differing sets of defaults, and
they play nicer with modern C and C++ compilers.
> [...] The Flip side is
> that Flex no longer conforms to the POSIX lex behaviour, and the
> scanners require conforming implementations when flex is used in ANSI
> C mode. The package flex-old provides the older behaviour.
s/Flip side/flipside/ and s/behaviour/behavior/ throughout;
s/flex/Flex/ wherever it doesn't mean flex_*.deb or /usr/bin/flex.
--
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../flex.old/debian/templates.master 2007-10-08 08:35:06.000000000 +0100
+++ debian/templates.master 2007-10-12 15:33:45.000000000 +0100
@@ -2,15 +2,13 @@
Type: boolean
Default: false
_Description: Are you sure you want to upgrade flex?
- This version of Flex is a major upgrade from previous
- versions. There have been extensive changes. Flex scanners
- are now reenterant, you may have multiple scanners in
- the same program with differing sets of defaults, and
- they play nicer with modern C and C++ compilers. The flip
- side is that Flex no longer conforms to the POSIX lex
- behaviour, and the scanners require conforming
- implementations when flex is used in ANSI C mode. The package
- flex-old provides the same behaviour as version 2.5.4a of Flex.
+ The behavior of Flex has undergone a major change since version
+ 2.5.4a. Flex scanners are now reentrant: they can have multiple
+ scanners in the same program with differing sets of defaults, and
+ they play nicer with modern C and C++ compilers. The flipside is
+ that Flex no longer conforms to the POSIX lex behavior, and the
+ scanners require conforming implementations when Flex is used in ANSI
+ C mode. The package flex-old provides the older behavior.
.
Please make sure you are prepared for these changes in Flex
before continuing with its upgrade.
--- ../flex.old/debian/control 2007-10-08 08:35:06.000000000 +0100
+++ debian/control 2007-10-12 15:33:41.000000000 +0100
@@ -6,6 +6,7 @@
Build-Depends: bison, gettext, texinfo, help2man, file, po-debconf
Maintainer: Manoj Srivastava <srivasta@debian.org>
Standards-Version: 3.7.2.0
+Homepage: http://flex.sf.net/
Package: flex
Architecture: any
@@ -13,35 +14,31 @@
Depends: ${shlibs:Depends}, m4
Recommends: gcc | c-compiler
Suggests: bison
-Description: A fast lexical analyzer generator.
- flex is a tool for generating scanners: programs which recognized lexical
- patterns in text. flex reads the given input files for a description of a
+Description: fast lexical analyzer generator - binaries
+ Flex is a tool for generating scanners (programs which recognize lexical
+ patterns in text). It reads the given input files for a description of a
scanner to generate. The description is in the form of pairs of regular
- expressions and C code, called rules. flex generates as output a C source
- file, lex.yy.c, which defines a routine yylex(). This file is compiled
+ expressions and C code, called rules. It generates as output a C source
+ file, lex.yy.c, which defines a routine yylex(). This file is compiled
and linked with the -lfl library to produce an executable. When the
executable is run, it analyzes its input for occurrences of the regular
expressions. Whenever it finds one, it executes the corresponding C code.
.
- The behaviour of Flex has undergone a major change since version
- 2.5.4a; Flex scanners are now reentrant, you may have multiple
+ The behavior of Flex has undergone a major change since version
+ 2.5.4a. Flex scanners are now reentrant: they can have multiple
scanners in the same program with differing sets of defaults, and
- they play nicer with modern C and C++ compilers. The Flip side is
- that Flex no longer conforms to the POSIX lex behaviour, and the
- scanners require conforming implementations when flex is used in ANSI
- C mode. The package flex-old provides the older behaviour.
+ they play nicer with modern C and C++ compilers. The flipside is
+ that Flex no longer conforms to the POSIX lex behavior, and the
+ scanners require conforming implementations when Flex is used in ANSI
+ C mode. The package flex-old provides the older behavior.
.
This product includes software developed by the University of California,
Berkeley and its contributors. The upstream source code can be found at
- http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download
- The project web page is at http://flex.sf.net/
+ http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download.
Package: flex-doc
Section: doc
Priority: optional
Architecture: all
-Description: Documentation for flex (a fast lexical analyzer generator)
- This package contains the HTML documentation for flex. The upstream
- source code can be found at
- http://prdownloads.sourceforge.net/lex/flex-2.5.31.tar.bz2?download
- The project web page is at http://lex.sf.net/
+Description: fast lexical analyzer generator - documentation
+ This package contains the HTML documentation for flex.
Template: flex/upgrade/pre_2.5.5
Type: boolean
Default: false
_Description: Are you sure you want to upgrade flex?
The behavior of Flex has undergone a major change since version
2.5.4a. Flex scanners are now reentrant: they can have multiple
scanners in the same program with differing sets of defaults, and
they play nicer with modern C and C++ compilers. The flipside is
that Flex no longer conforms to the POSIX lex behavior, and the
scanners require conforming implementations when Flex is used in ANSI
C mode. The package flex-old provides the older behavior.
.
Please make sure you are prepared for these changes in Flex
before continuing with its upgrade.
Source: flex
XS-VCS-Arch: http://arch.debian.org/arch/private/srivasta/grab/flex
XS-VCS-Browse: http://arch.debian.org/cgi-bin/archzoom.cgi/srivasta@debian.org--lenny/flex?expand
Section: devel
Priority: standard
Build-Depends: bison, gettext, texinfo, help2man, file, po-debconf
Maintainer: Manoj Srivastava <srivasta@debian.org>
Standards-Version: 3.7.2.0
Homepage: http://flex.sf.net/
Package: flex
Architecture: any
Pre-Depends: debconf | debconf-2.0
Depends: ${shlibs:Depends}, m4
Recommends: gcc | c-compiler
Suggests: bison
Description: fast lexical analyzer generator - binaries
Flex is a tool for generating scanners (programs which recognize lexical
patterns in text). It reads the given input files for a description of a
scanner to generate. The description is in the form of pairs of regular
expressions and C code, called rules. It generates as output a C source
file, lex.yy.c, which defines a routine yylex(). This file is compiled
and linked with the -lfl library to produce an executable. When the
executable is run, it analyzes its input for occurrences of the regular
expressions. Whenever it finds one, it executes the corresponding C code.
.
The behavior of Flex has undergone a major change since version
2.5.4a. Flex scanners are now reentrant: they can have multiple
scanners in the same program with differing sets of defaults, and
they play nicer with modern C and C++ compilers. The flipside is
that Flex no longer conforms to the POSIX lex behavior, and the
scanners require conforming implementations when Flex is used in ANSI
C mode. The package flex-old provides the older behavior.
.
This product includes software developed by the University of California,
Berkeley and its contributors. The upstream source code can be found at
http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download.
Package: flex-doc
Section: doc
Priority: optional
Architecture: all
Description: fast lexical analyzer generator - documentation
This package contains the HTML documentation for flex.
Reply to: