[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://flex/{templates.master}



Please find, for review, the debconf templates and packages descriptions for the flex source package.

This review will last from Friday, October 12, 2007 to Monday, October 22, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../flex.old/debian/templates.master	2007-10-06 19:13:47.502874919 +0200
+++ debian/templates.master	2007-10-08 07:04:23.311699944 +0200
@@ -4,7 +4,7 @@
 _Description: Are you sure you want to upgrade flex?
  This version of Flex is a major upgrade from previous
  versions. There have been extensive changes. Flex scanners
- are now reenterant, you may have multiple scanners in
+ are now reentrant, you may have multiple scanners in
  the same program with differing sets of defaults, and
  they play nicer with modern C and C++ compilers. The flip
  side is that Flex no longer conforms to the POSIX lex

Typo

--- ../flex.old/debian/control	2007-10-06 19:13:47.502874919 +0200
+++ debian/control	2007-10-08 07:08:55.823183429 +0200
@@ -6,6 +6,7 @@
 Build-Depends: bison, gettext, texinfo, help2man, file, po-debconf
 Maintainer: Manoj Srivastava <srivasta@debian.org>
 Standards-Version: 3.7.2.0
+Homepage: http://flex.sf.net/

Use the Homepage field (I have to send you a proposed patch for the
Policy, Manoj, but you're aware of the effort to promote this and you
helped supporting it)
 
 Package: flex
 Architecture: any
@@ -13,18 +14,18 @@
 Depends: ${shlibs:Depends}, m4
 Recommends: gcc | c-compiler
 Suggests: bison
-Description: A fast lexical analyzer generator.
- flex is a tool for generating scanners: programs which recognized lexical
- patterns in text. flex reads the given input files for a description of a
+Description: fast lexical analyzer generator - binaries

Apply recommendations from the DevRef and avoid leading article.

Use a "generic description - specific description" style for the synopsis.

+ This package provides flex, a tool for generating scanners: programs which recognized lexical
+ patterns in text. It reads the given input files for a description of a


Workaround the problem of a sentence beginning with a lowercase letter
by using a quite common trick

  scanner to generate. The description is in the form of pairs of regular
- expressions and C code, called rules. flex generates as output a C source
- file, lex.yy.c, which defines a routine yylex().  This file is compiled
+ expressions and C code, called rules. It generates as output a C source
+ file, lex.yy.c, which defines a routine yylex(). This file is compiled

We standardized on suggesting single spaces after sentence dots. Some
people disagree with that, though.

  and linked with the -lfl library to produce an executable. When the
  executable is run, it analyzes its input for occurrences of the regular
  expressions. Whenever it finds one, it executes the corresponding C code.
  .
- The behaviour of Flex has undergone a major change since version
- 2.5.4a; Flex scanners are now reentrant, you may have multiple
+ The behavior of Flex has undergone a major change since version
+ 2.5.4a; Flex scanners are now reentrant, allowing to have multiple

We standardized on US-style spelling which is slightly more used in
packages' descriptions. That may hurt some British-style culture,
though..:-)

I however wonder whether this paragraph is still really needed in the
package's description.


  scanners in the same program with differing sets of defaults, and
  they play nicer with modern C and C++ compilers. The Flip side is
  that Flex no longer conforms to the POSIX lex behaviour, and the
@@ -33,15 +34,11 @@
  .
  This product includes software developed by the University of California,
  Berkeley and its contributors. The upstream source code can be found at 
- http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download
- The project web page is at http://flex.sf.net/
+ http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download.
 
 Package: flex-doc
 Section: doc
 Priority: optional
 Architecture: all
-Description: Documentation for flex (a fast lexical analyzer generator)
- This package contains the HTML documentation for flex. The upstream 
- source code can be found at
- http://prdownloads.sourceforge.net/lex/flex-2.5.31.tar.bz2?download
- The project web page is at http://lex.sf.net/
+Description: fast lexical analyzer generator - documentation
+ This package contains the HTML documentation for flex.

Here, a general paragraph about Flex could maybe be added as well. For
instance, a copy of the first paragraph of the "flex" package description.

-- 


Template: flex/upgrade/pre_2.5.5
Type: boolean
Default: false
_Description: Are you sure you want to upgrade flex?
 This version of Flex is a major upgrade from previous
 versions. There have been extensive changes. Flex scanners
 are now reentrant, you may have multiple scanners in
 the same program with differing sets of defaults, and
 they play nicer with modern C and C++ compilers. The flip
 side is that Flex no longer conforms to the POSIX lex
 behaviour, and the scanners require conforming
 implementations when flex is used in ANSI C mode. The package
 flex-old provides the same behaviour as version 2.5.4a of Flex.
 .
 Please make sure you are prepared for these changes in Flex
 before continuing with its upgrade.
--- ../flex.old/debian/templates.master	2007-10-06 19:13:47.502874919 +0200
+++ debian/templates.master	2007-10-08 07:04:23.311699944 +0200
@@ -4,7 +4,7 @@
 _Description: Are you sure you want to upgrade flex?
  This version of Flex is a major upgrade from previous
  versions. There have been extensive changes. Flex scanners
- are now reenterant, you may have multiple scanners in
+ are now reentrant, you may have multiple scanners in
  the same program with differing sets of defaults, and
  they play nicer with modern C and C++ compilers. The flip
  side is that Flex no longer conforms to the POSIX lex
--- ../flex.old/debian/control	2007-10-06 19:13:47.502874919 +0200
+++ debian/control	2007-10-08 07:08:55.823183429 +0200
@@ -6,6 +6,7 @@
 Build-Depends: bison, gettext, texinfo, help2man, file, po-debconf
 Maintainer: Manoj Srivastava <srivasta@debian.org>
 Standards-Version: 3.7.2.0
+Homepage: http://flex.sf.net/
 
 Package: flex
 Architecture: any
@@ -13,18 +14,18 @@
 Depends: ${shlibs:Depends}, m4
 Recommends: gcc | c-compiler
 Suggests: bison
-Description: A fast lexical analyzer generator.
- flex is a tool for generating scanners: programs which recognized lexical
- patterns in text. flex reads the given input files for a description of a
+Description: fast lexical analyzer generator - binaries
+ This package provides flex, a tool for generating scanners: programs which recognized lexical
+ patterns in text. It reads the given input files for a description of a
  scanner to generate. The description is in the form of pairs of regular
- expressions and C code, called rules. flex generates as output a C source
- file, lex.yy.c, which defines a routine yylex().  This file is compiled
+ expressions and C code, called rules. It generates as output a C source
+ file, lex.yy.c, which defines a routine yylex(). This file is compiled
  and linked with the -lfl library to produce an executable. When the
  executable is run, it analyzes its input for occurrences of the regular
  expressions. Whenever it finds one, it executes the corresponding C code.
  .
- The behaviour of Flex has undergone a major change since version
- 2.5.4a; Flex scanners are now reentrant, you may have multiple
+ The behavior of Flex has undergone a major change since version
+ 2.5.4a; Flex scanners are now reentrant, allowing to have multiple
  scanners in the same program with differing sets of defaults, and
  they play nicer with modern C and C++ compilers. The Flip side is
  that Flex no longer conforms to the POSIX lex behaviour, and the
@@ -33,15 +34,11 @@
  .
  This product includes software developed by the University of California,
  Berkeley and its contributors. The upstream source code can be found at 
- http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download
- The project web page is at http://flex.sf.net/
+ http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download.
 
 Package: flex-doc
 Section: doc
 Priority: optional
 Architecture: all
-Description: Documentation for flex (a fast lexical analyzer generator)
- This package contains the HTML documentation for flex. The upstream 
- source code can be found at
- http://prdownloads.sourceforge.net/lex/flex-2.5.31.tar.bz2?download
- The project web page is at http://lex.sf.net/
+Description: fast lexical analyzer generator - documentation
+ This package contains the HTML documentation for flex.
Source: flex
XS-VCS-Arch: http://arch.debian.org/arch/private/srivasta/grab/flex
XS-VCS-Browse: http://arch.debian.org/cgi-bin/archzoom.cgi/srivasta@debian.org--lenny/flex?expand
Section: devel
Priority: standard
Build-Depends: bison, gettext, texinfo, help2man, file, po-debconf
Maintainer: Manoj Srivastava <srivasta@debian.org>
Standards-Version: 3.7.2.0
Homepage: http://flex.sf.net/

Package: flex
Architecture: any
Pre-Depends: debconf | debconf-2.0
Depends: ${shlibs:Depends}, m4
Recommends: gcc | c-compiler
Suggests: bison
Description: fast lexical analyzer generator - binaries
 This package provides flex, a tool for generating scanners: programs which recognized lexical
 patterns in text. It reads the given input files for a description of a
 scanner to generate. The description is in the form of pairs of regular
 expressions and C code, called rules. It generates as output a C source
 file, lex.yy.c, which defines a routine yylex(). This file is compiled
 and linked with the -lfl library to produce an executable. When the
 executable is run, it analyzes its input for occurrences of the regular
 expressions. Whenever it finds one, it executes the corresponding C code.
 .
 The behavior of Flex has undergone a major change since version
 2.5.4a; Flex scanners are now reentrant, allowing to have multiple
 scanners in the same program with differing sets of defaults, and
 they play nicer with modern C and C++ compilers. The Flip side is
 that Flex no longer conforms to the POSIX lex behaviour, and the
 scanners require conforming implementations when flex is used in ANSI
 C mode. The package flex-old provides the older behaviour.
 .
 This product includes software developed by the University of California,
 Berkeley and its contributors. The upstream source code can be found at 
 http://prdownloads.sourceforge.net/flex/flex-2.5.33.tar.bz2?download.

Package: flex-doc
Section: doc
Priority: optional
Architecture: all
Description: fast lexical analyzer generator - documentation
 This package contains the HTML documentation for flex.

Attachment: signature.asc
Description: Digital signature


Reply to: