[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://mplayer/{mplayer.templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.
>  
>  Template: mplayer/rtc
>  Type: boolean
>  Default: false
>  _Description: Enable access to RTC?
> + On older kernels, MPlayer can use the RTC (Real Time Clock) to provide
> + better timing in reproduction, with less CPU cost.
> + .
> + For this option to work, the /dev/rtc device must be readable by
> + the 'audio' group and the default max-user-freq must be raised to 1024 by
> + the superuser.
> + .
> + This can be done automatically at boot, to the expense of potential (but
> + limited) security implications.

s/to the expense of/at the expense of/

Given that things like selinux have *actual* security implications
(and not merely limited potential implications), I think this
understates the risk; s/implications/issues/. 

> I wondered whether this template is still needed as I have no idea
> what "older kernels" mean.

According to http://www.mplayerhq.hu/DOCS/HTML/en/rtc.html it's
2.4-era, which won't work with Lenny anyhow.  Looks like a relic.

>  Template: mplayer/replace-existing-files
[...]
> + A /etc/mplayer/mplayer.conf file already exists on the system and

I'd say "An /etc/foo.bar file".

>  Template: mplayer/replace-existing-files-bail
[...]
> +_Description: Old configuration file kept
> + You choosed not to replace the existing /etc/mplayer/mplayer.conf
> + file.

s/choosed/chose/

>  Template: mplayer/voutput
[...]
> + If you prefer choosing the driver yourself, you should first choose
> + an entry matching this system's video card. In case none is matching and the
> + card supports 'XV', choose that option (the 'xvinfo' command may help).

This is another one where I wouldn't say "in case" in case somebody
reads it as an unconditional precaution; s/In case/If/.

Also, s/none is matching/none match/

>  Template: mplayer/install_codecs
[...]
> +_Description: Binary codecs download
> + MPlayer supports most video formats without additional software.
> + .
> + Additional video formats, such as Real 3.0/4.0, Windows Media 9, Quicktime,
> + can be supported by using binary codecs.

s/, Quicktime/, or Quicktime/

And the control file:
> -Description: The Movie Player
> - MPlayer is a movie player for GNU/Linux. 
> - .
> +Description: movie player for GNU/Linux

(It's also for kfreebsd...)

>   MPlayer plays most MPEG, VOB, AVI, Ogg/OGM, VIVO,
>   ASF/WMA/WMV, QT/MOV/MP4, FLI, RM, NuppelVideo, yuv4mpeg, FILM, RoQ, PVA files,

Another missing "or".

> + supported by many native, XAnim, RealPlayer, and Win32 DLL codecs. It can
> + also play VideoCD, SVCD, DVD, 3ivx, RealMedia, and DivX movies too.

No need for both "also" and simultaneously "too" as well.

>   Another big feature of MPlayer is the wide range of supported output
> + drivers. It works with X11, Xv, DGA, OpenGL, SVGAlib, fbdev,
>   DirectFB, but also SDL (and this way all its drivers) and some
>   lowlevel card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64,

Lose an "and" there by saying "(plus all its drivers)".

>   lowlevel card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64,
> + Permedia3). Most of them support software or hardware scaling,

Now it can afford another "and" before Permedia3.

[...]
> - NOTE: the .tar.gz distributed with Debian does not contain all of the upstream
> - code. Read README.Debian and copyright for details.
> + Some parts of upstream code are not distributed along with that package.
> + Please read the README.Debian and copyright files for details.
> 
> simplify what we want to explain: just tell that parts of upstream
> code is not there.

"Along with that package"?  What package - this one?  How about:

    Not all of the upstream code is distributed in the source tarball.
    See the README.Debian and copyright files for details.

-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../mplayer.old/debian/mplayer.templates	2007-10-03 07:41:17.000000000 +0100
+++ debian/mplayer.templates	2007-10-05 07:54:09.000000000 +0100
@@ -1,82 +1,93 @@
 Template: mplayer/cfgnote
 Type: note
-_Description: Create your ~/.mplayer/config file
- Performance of MPlayer depends heavily on hardware - this means that
- it may benefit from tweaking options, for every single machine it's
- installed to. You may wish to read the documentation (it is in the
- package 'mplayer-doc', under /usr/share/doc/mplayer-doc/). This DebConf
- interface will help you setup just a few main features; you may wish to
- add to /etc/mplayer/mplayer.conf some more refined options (to enable
- multichannel audio, or video postprocessing, etc etc); and any user
- similarly may customize MPlayer using the file ~/.mplayer/config
+_Description: Detailed configuration needed for each user
+ The performance of MPlayer heavily depends on hardware; this means that
+ it may benefit from tweaking options for every single machine it's
+ installed to.
+ .
+ You should read the software documentation provided by the
+ 'mplayer-doc' package.
+ .
+ Some configuration options will now be set for the entire system in
+ /etc/mplayer/mplayer.conf which may be later adapted. Any user can also
+ refine options in  ~/.mplayer/config.
 
 Template: mplayer/rtc
 Type: boolean
 Default: false
 _Description: Enable access to RTC?
- On older kernels MPlayer can use the RTC (Real Time Clock) to provide
- better timing in reproduction, with less CPU cost; to this end,
- though, the device /dev/rtc must be accessible to group audio, and
- the default max-user-freq must be raised to 1024.  Any needed change
- must be done by root. If you wish, MPlayer will automatically do
- this at boot, so that any user can enjoy this feature. Note that
- there may be security issues with this (although none are known now).
+ On older kernels, MPlayer can use the RTC (Real Time Clock) to provide
+ better timing in reproduction, with less CPU cost.
+ .
+ For this option to work, the /dev/rtc device must be readable by
+ the 'audio' group and the default max-user-freq must be raised to 1024 by
+ the superuser.
+ .
+ This can be done automatically at boot, at the expense of potential (but
+ limited) security issues.
 
 Template: mplayer/replace-existing-files
 Type: boolean
 Default: false
 _Description: Replace existing configuration file?
- There is already a file /etc/mplayer/mplayer.conf, but it does not
- contain an automatically generated part. This script may generate a
- new file (the old file will be moved to /etc/mplayer/mplayer.conf.debconf-old).
+ An /etc/mplayer/mplayer.conf file already exists on the system and
+ does not contain an automatically-generated part. That file can be replaced
+ by a generated one (the old file will be moved to
+ /etc/mplayer/mplayer.conf.debconf-old).
 
 Template: mplayer/replace-existing-files-bail
 Type: note
-_Description: Files not replaced
- It seems that you don't want to replace your existing configuration
- file /etc/mplayer/mplayer.conf.  If you change your mind later, you
- can run "dpkg-reconfigure mplayer".
+_Description: Old configuration file kept
+ You chose not to replace the existing /etc/mplayer/mplayer.conf file.
+ .
+ That file can be generated automatically later by running
+ 'dpkg-reconfigure mplayer'.
 
 Template: mplayer/voutput
 Type: select
 Default: autodetect
 Choices: ${vochoices}
 _Description: MPlayer video output:
- MPlayer can use a very wide range of video output drivers;
- it will try to autodetect the best one, but you may choose a preferred one.
- Here is a guide to the choice (in decreasing order of speed):
- (1) if you see an entry that matches your video card, choose that;
- (2) if your video card supports 'XV', choose that (use 'xvinfo' to know).
- You should read /usr/share/doc/mplayer-doc/HTML/en/video.html (it is in
- package 'mplayer-doc').
+ MPlayer can use a very wide range of video output drivers.
+ The needed driver may be detected automatically or chosen manually.
+ .
+ If you prefer choosing the driver yourself, you should first choose
+ an entry matching this system's video card. If none match and the
+ card supports 'XV', choose that option (the 'xvinfo' command may help).
+ .
+ Please read the /usr/share/doc/mplayer-doc/HTML/en/video.html file from
+ the 'mplayer-doc' package for more details.
 
 Template: mplayer/install_codecs
 Type: note
-_Description: How to download binary codecs
- MPlayer supports most codecs out of the box and the rest with the
- help of binary codecs. Binary codecs are only necessary for Real 3.0 
- and 4.0, Windows Media 9, QuickTime audio and some very obscure codecs.
- Debian cannot distribute these codecs, but these are available on the
- internet for download. Run the script
- `/usr/share/mplayer/scripts/binary_codecs.sh' to install those 
- made available from MPlayer web site.
+_Description: Binary codecs download
+ MPlayer supports most video formats without additional software.
+ .
+ Additional video formats, such as Real 3.0/4.0, Windows Media 9, or
+ Quicktime, can be supported by using binary codecs.
+ .
+ As such codecs are not free software, they are not distributed with
+ this package but can be downloaded freely. The
+ '/usr/share/mplayer/scripts/binary_codecs.sh' script is provided in
+ this package to help downloading them from the MPlayer web site.
 
 Template: mplayer/dvd_device
 Type: string
 Default: /dev/cdrom
 _Description: DVD device name:
- What is the name of your DVD device (if any):
+ Please enter the name of the device for your DVD player, if any.
 
 Template: mplayer/ttfont
 Type: select
 Choices: ${ttfontchoices}
 Default: ${ttfontdefault}
-_Description: MPlayer OSD font:
-  MPlayer needs True Type fonts for On Screen Display. Choose your favorite.
+_Description: Font for On Screen Display:
 
 Template: mplayer/no-ttfont
-Type: note
-_Description: MPlayer cannot find TrueType Fonts
- You should install a package providing truetype fonts (such as  
- 'ttf-freefont' or 'ttf-bitstream-vera' or  'msttcorefonts' )
- and reconfigure MPlayer (with the command "dpkg-reconfigure mplayer")
+Type: error
+_Description: No TrueType fonts found for On Screen Display
+ MPlayer needs at least one TrueType font for its 'On Screen Diplay' feature.
+ .
+ You should install a package providing such fonts (such as
+ 'ttf-freefont' or 'ttf-bitstream-vera' or 'msttcorefonts')
+ and reconfigure MPlayer (by running 'dpkg-reconfigure mplayer').
--- ../mplayer.old/debian/control	2007-10-03 07:41:17.000000000 +0100
+++ debian/control	2007-10-05 07:56:22.000000000 +0100
@@ -19,30 +19,27 @@
 Architecture: any
 Suggests: mplayer-doc, ttf-freefont, netselect | fping, bzip2, fontconfig
 Depends: ${shlibs:Depends}, debconf-2.0 | debconf, mplayer-skin
-Description: The Movie Player
- MPlayer is a movie player for GNU/Linux. 
- .
- MPlayer plays most MPEG, VOB, AVI, Ogg/OGM, VIVO,
- ASF/WMA/WMV, QT/MOV/MP4, FLI, RM, NuppelVideo, yuv4mpeg, FILM, RoQ, PVA files,
- supported by many native, XAnim, RealPlayer, and Win32 DLL codecs. You can
- watch VideoCD, SVCD, DVD, 3ivx, RealMedia, and DivX movies too.
+Description: movie player for GNU/Linux
+ MPlayer plays most MPEG, VOB, AVI, Ogg/OGM, VIVO, ASF/WMA/WMV,
+ QT/MOV/MP4, FLI, RM, NuppelVideo, yuv4mpeg, FILM, RoQ, or PVA files,
+ supported by many native, XAnim, RealPlayer, and Win32 DLL codecs. It can
+ also play VideoCD, SVCD, DVD, 3ivx, RealMedia, and DivX movies.
  .
  Another big feature of MPlayer is the wide range of supported output
- drivers.  It works with X11, Xv, DGA, OpenGL, SVGAlib, fbdev,
- DirectFB, but also SDL (and this way all its drivers) and some
+ drivers. It works with X11, Xv, DGA, OpenGL, SVGAlib, fbdev,
+ DirectFB, but also SDL (plus all its drivers) and some
  lowlevel card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64,
- Permedia3) Most of them supports software or hardware scaling,
- so you can enjoy movies in fullscreen.  MPlayer supports also
- displaying through some hardware MPEG decoder boards, such as the DVB
+ and Permedia3). Most of them support software or hardware scaling,
+ therefore allowing fullscreen display.  MPlayer is also able
+ to use some hardware MPEG decoder boards, such as the DVB
  and DXR3/Hollywood+.  
  .
- NOTE: the .tar.gz distributed with Debian does not contain all of the upstream
- code. Read README.Debian and copyright for details.
+ Not all of the upstream code is distributed in the source tarball.
+ Please read the README.Debian and copyright files for details.
 
 Package: mplayer-doc
 Architecture: all
 Recommends: mplayer
 Description: documentation for MPlayer
- MPlayer is a movie player for GNU/Linux. 
- .
- This package contains the documentation.
+ This package contains the documentation for MPlayer, a movie player for
+ GNU/Linux.
Template: mplayer/cfgnote
Type: note
_Description: Detailed configuration needed for each user
 The performance of MPlayer heavily depends on hardware; this means that
 it may benefit from tweaking options for every single machine it's
 installed to.
 .
 You should read the software documentation provided by the
 'mplayer-doc' package.
 .
 Some configuration options will now be set for the entire system in
 /etc/mplayer/mplayer.conf which may be later adapted. Any user can also
 refine options in  ~/.mplayer/config.

Template: mplayer/rtc
Type: boolean
Default: false
_Description: Enable access to RTC?
 On older kernels, MPlayer can use the RTC (Real Time Clock) to provide
 better timing in reproduction, with less CPU cost.
 .
 For this option to work, the /dev/rtc device must be readable by
 the 'audio' group and the default max-user-freq must be raised to 1024 by
 the superuser.
 .
 This can be done automatically at boot, at the expense of potential (but
 limited) security issues.

Template: mplayer/replace-existing-files
Type: boolean
Default: false
_Description: Replace existing configuration file?
 An /etc/mplayer/mplayer.conf file already exists on the system and
 does not contain an automatically-generated part. That file can be replaced
 by a generated one (the old file will be moved to
 /etc/mplayer/mplayer.conf.debconf-old).

Template: mplayer/replace-existing-files-bail
Type: note
_Description: Old configuration file kept
 You chose not to replace the existing /etc/mplayer/mplayer.conf file.
 .
 That file can be generated automatically later by running
 'dpkg-reconfigure mplayer'.

Template: mplayer/voutput
Type: select
Default: autodetect
Choices: ${vochoices}
_Description: MPlayer video output:
 MPlayer can use a very wide range of video output drivers.
 The needed driver may be detected automatically or chosen manually.
 .
 If you prefer choosing the driver yourself, you should first choose
 an entry matching this system's video card. If none match and the
 card supports 'XV', choose that option (the 'xvinfo' command may help).
 .
 Please read the /usr/share/doc/mplayer-doc/HTML/en/video.html file from
 the 'mplayer-doc' package for more details.

Template: mplayer/install_codecs
Type: note
_Description: Binary codecs download
 MPlayer supports most video formats without additional software.
 .
 Additional video formats, such as Real 3.0/4.0, Windows Media 9, or
 Quicktime, can be supported by using binary codecs.
 .
 As such codecs are not free software, they are not distributed with
 this package but can be downloaded freely. The
 '/usr/share/mplayer/scripts/binary_codecs.sh' script is provided in
 this package to help downloading them from the MPlayer web site.

Template: mplayer/dvd_device
Type: string
Default: /dev/cdrom
_Description: DVD device name:
 Please enter the name of the device for your DVD player, if any.

Template: mplayer/ttfont
Type: select
Choices: ${ttfontchoices}
Default: ${ttfontdefault}
_Description: Font for On Screen Display:

Template: mplayer/no-ttfont
Type: error
_Description: No TrueType fonts found for On Screen Display
 MPlayer needs at least one TrueType font for its 'On Screen Diplay' feature.
 .
 You should install a package providing such fonts (such as
 'ttf-freefont' or 'ttf-bitstream-vera' or 'msttcorefonts')
 and reconfigure MPlayer (by running 'dpkg-reconfigure mplayer').
Source: mplayer
Section: graphics
Priority: optional
Maintainer:  A Mennucc1 <mennucc1@debian.org>
Uploaders: Dariush Pietrzak <eyck@kuszelas.com>
Standards-Version: 3.7.2.0
Build-Depends-Indep: 
Build-Depends: debhelper (>= 4), make (>= 3.80), pkg-config, po-debconf,
 libsdl1.2-dev | libsdl1.1-dev, svgalibg1-dev [i386], libdts-dev, ladspa-sdk,
 libpng-dev, libncurses5-dev, zlib1g-dev, libspeex-dev, libsmbclient-dev,
 libtheora-dev (>= 0.0.0.alpha3-1), libesd0-dev, liblzo-dev, libgl1-mesa-dev,
 libasound2-dev (>= 1.0.6-3) [!kfreebsd-i386 !kfreebsd-amd64 !hurd-i386],
 libvorbis-dev, liblircclient-dev, libfreetype6-dev, libdvdread3-dev, 
 libcdparanoia0-dev, libfontconfig1-dev, libjpeg62-dev, libungif4-dev,
 libgtk2.0-dev, libdirectfb-dev, libcaca-dev, liblivemedia-dev,
 libx11-dev, libxext-dev, libxinerama-dev, libxv-dev, libxvmc-dev, libxxf86dga-dev, libxxf86vm-dev, x-dev, 

Package: mplayer
Architecture: any
Suggests: mplayer-doc, ttf-freefont, netselect | fping, bzip2, fontconfig
Depends: ${shlibs:Depends}, debconf-2.0 | debconf, mplayer-skin
Description: movie player for GNU/Linux
 MPlayer plays most MPEG, VOB, AVI, Ogg/OGM, VIVO, ASF/WMA/WMV,
 QT/MOV/MP4, FLI, RM, NuppelVideo, yuv4mpeg, FILM, RoQ, or PVA files,
 supported by many native, XAnim, RealPlayer, and Win32 DLL codecs. It can
 also play VideoCD, SVCD, DVD, 3ivx, RealMedia, and DivX movies.
 .
 Another big feature of MPlayer is the wide range of supported output
 drivers. It works with X11, Xv, DGA, OpenGL, SVGAlib, fbdev,
 DirectFB, but also SDL (plus all its drivers) and some
 lowlevel card-specific drivers (for Matrox, 3Dfx and Radeon, Mach64,
 and Permedia3). Most of them support software or hardware scaling,
 therefore allowing fullscreen display.  MPlayer is also able
 to use some hardware MPEG decoder boards, such as the DVB
 and DXR3/Hollywood+.  
 .
 Not all of the upstream code is distributed in the source tarball.
 Please read the README.Debian and copyright files for details.

Package: mplayer-doc
Architecture: all
Recommends: mplayer
Description: documentation for MPlayer
 This package contains the documentation for MPlayer, a movie player for
 GNU/Linux.

Reply to: