[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://adduser/{templates}



Please find, for review, the debconf templates of adduser.

This review will last from Monday, June 11, 2007 to Thursday, June 21, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:

--- /home/bubulle/travail/debian/rewrite/INTENT/adduser/adduser.old/debian/templates	2007-06-05 06:06:04.090505737 +0200
+++ /home/bubulle/travail/debian/rewrite/INTENT/adduser/adduser/debian/templates	2007-06-07 23:09:53.371287343 +0200
@@ -1,11 +1,11 @@
 Template: adduser/homedir-permission
 Type: boolean
 Default: true
-_Description: Do you want system wide readable home directories?
- Normally, home directories can be viewed by all users on the system. If
- you want to increase the security/privacy on your system, you might want
- your home directories only readable by the user. If you are unsure,
- enable system wide readable home directories.
+_Description: Do you want system-wide readable home directories?
+ By default, the users' home directories are readable by all users on
+ the system. If you want to increase the security and privacy on the
+ system, you might want home directories to be only readable by their
+ owners. If in doubt, you should enable this option.

Hyphen: recommended use in English in such cases?

paragraph rewrite for what seems to be better wording to
me..:-). Again, tending to avoid personnalization ("your home directories")

  .
- This will only affect home directories of users added with the adduser
- program later.
+ This will only affect newly created home directories for users added
+ with the adduser program.

I feel this like better wording but this may be improved by native
speakers, though.


--- /home/bubulle/travail/debian/rewrite/INTENT/adduser/adduser.old/debian/control	2007-06-05 06:06:04.090505737 +0200
+++ /home/bubulle/travail/debian/rewrite/INTENT/adduser/adduser/debian/control	2007-06-07 23:13:06.862196867 +0200
@@ -12,25 +12,25 @@
 Depends: perl-base (>=5.6.0), passwd (>= 1:4.0.12), debconf | debconf-2.0
 Suggests: liblocale-gettext-perl, perl-modules
 Replaces: manpages-pl (<= 20051117-1), manpages-it (<< 0.3.4-2)
-Description: Add and remove users and groups
+Description: add and remove users and groups

Remove extra capital for overall consistency among packages

  This package includes the adduser and deluser commands for creating
  and removing users.
  .
-  - Adduser can create new users and groups and add existing users to
-    existing groups.
-  - Deluser can remove users and groups and remove users from a given
+  - 'adduser' creates new users and groups and adds existing users to
+    existing groups;
+  - 'deluser' removes users and groups and removes users from a given
     group.

As we're speaking about commands, let's use quotes. Common enumeration
typography.

  .
- Adding users with adduser is much easier than adding them by hand.
+ Adding users with adduser is much easier than adding them manually.

Matter of taste...


  Adduser will choose appropriate UID and GID values, create a home
- directory, copy skeletal user configuration, allow you to set an
- initial password and the GECOS field.
+ directory, copy skeletal user configuration, fill in the GECOS field
+ and allow setting an initial password.

Native speakers: is "allow setting" Frenglish? :-)


  .
  Deluser can optionally remove and backup the user's home directory
- and mail spool or all files on the system owned by him.
+ and mail spool or all files on the system owned by the removed user.


Gender neutrality

  .
- Optionally a custom script can be executed after each of the commands.
+ A custom script can be executed after each of the commands.

"can" already includes the idea of being optional


  .
- Adduser is maintained on http://alioth.debian.org/projects/adduser/.
- There is also a development mailing list on
- http://lists.alioth.debian.org/mailman/listinfo/adduser-devel/.
+  Homepage: http://alioth.debian.org/projects/adduser/
+  Development mailing list:
+    http://lists.alioth.debian.org/mailman/listinfo/adduser-devel/

General convention for such information in packages' descriptions.

-- 


Template: adduser/homedir-permission
Type: boolean
Default: true
_Description: Do you want system-wide readable home directories?
 By default, the users' home directories are readable by all users on
 the system. If you want to increase the security and privacy on the
 system, you might want home directories to be only readable by their
 owners. If in doubt, you should enable this option.
 .
 This will only affect newly created home directories for users added
 with the adduser program.
--- ../adduser.old/debian/templates	2007-06-05 06:06:04.090505737 +0200
+++ debian/templates	2007-06-07 23:09:53.371287343 +0200
@@ -1,11 +1,11 @@
 Template: adduser/homedir-permission
 Type: boolean
 Default: true
-_Description: Do you want system wide readable home directories?
- Normally, home directories can be viewed by all users on the system. If
- you want to increase the security/privacy on your system, you might want
- your home directories only readable by the user. If you are unsure,
- enable system wide readable home directories.
+_Description: Do you want system-wide readable home directories?
+ By default, the users' home directories are readable by all users on
+ the system. If you want to increase the security and privacy on the
+ system, you might want home directories to be only readable by their
+ owners. If in doubt, you should enable this option.
  .
- This will only affect home directories of users added with the adduser
- program later.
+ This will only affect newly created home directories for users added
+ with the adduser program.
--- ../adduser.old/debian/control	2007-06-05 06:06:04.090505737 +0200
+++ debian/control	2007-06-07 23:13:06.862196867 +0200
@@ -12,25 +12,25 @@
 Depends: perl-base (>=5.6.0), passwd (>= 1:4.0.12), debconf | debconf-2.0
 Suggests: liblocale-gettext-perl, perl-modules
 Replaces: manpages-pl (<= 20051117-1), manpages-it (<< 0.3.4-2)
-Description: Add and remove users and groups
+Description: add and remove users and groups
  This package includes the adduser and deluser commands for creating
  and removing users.
  .
-  - Adduser can create new users and groups and add existing users to
-    existing groups.
-  - Deluser can remove users and groups and remove users from a given
+  - 'adduser' creates new users and groups and adds existing users to
+    existing groups;
+  - 'deluser' removes users and groups and removes users from a given
     group.
  .
- Adding users with adduser is much easier than adding them by hand.
+ Adding users with adduser is much easier than adding them manually.
  Adduser will choose appropriate UID and GID values, create a home
- directory, copy skeletal user configuration, allow you to set an
- initial password and the GECOS field.
+ directory, copy skeletal user configuration, fill in the GECOS field
+ and allow setting an initial password.
  .
  Deluser can optionally remove and backup the user's home directory
- and mail spool or all files on the system owned by him.
+ and mail spool or all files on the system owned by the removed user.
  .
- Optionally a custom script can be executed after each of the commands.
+ A custom script can be executed after each of the commands.
  .
- Adduser is maintained on http://alioth.debian.org/projects/adduser/.
- There is also a development mailing list on
- http://lists.alioth.debian.org/mailman/listinfo/adduser-devel/.
+  Homepage: http://alioth.debian.org/projects/adduser/
+  Development mailing list:
+    http://lists.alioth.debian.org/mailman/listinfo/adduser-devel/
Source: adduser
Section: admin
Priority: important
Maintainer: Debian Adduser Developers <adduser-devel@lists.alioth.debian.org>
Uploaders: Roland Bauerschmidt <rb@debian.org>, Marc Haber <mh+debian-packages@zugschlus.de>
Standards-Version: 3.7.2
Build-Depends: po-debconf
Build-Depends-Indep: gettext (>= 0.13), po4a (>= 0.23)

Package: adduser
Architecture: all
Depends: perl-base (>=5.6.0), passwd (>= 1:4.0.12), debconf | debconf-2.0
Suggests: liblocale-gettext-perl, perl-modules
Replaces: manpages-pl (<= 20051117-1), manpages-it (<< 0.3.4-2)
Description: add and remove users and groups
 This package includes the adduser and deluser commands for creating
 and removing users.
 .
  - 'adduser' creates new users and groups and adds existing users to
    existing groups;
  - 'deluser' removes users and groups and removes users from a given
    group.
 .
 Adding users with adduser is much easier than adding them manually.
 Adduser will choose appropriate UID and GID values, create a home
 directory, copy skeletal user configuration, fill in the GECOS field
 and allow setting an initial password.
 .
 Deluser can optionally remove and backup the user's home directory
 and mail spool or all files on the system owned by the removed user.
 .
 A custom script can be executed after each of the commands.
 .
  Homepage: http://alioth.debian.org/projects/adduser/
  Development mailing list:
    http://lists.alioth.debian.org/mailman/listinfo/adduser-devel/

Attachment: signature.asc
Description: Digital signature


Reply to: