[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://man-db/{templates.master}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

The only (repeated) point worth fixing is:

> Template: man-db/build-database
and
> Template: man-db/rebuild-database
...
> If you do not build the database now, it will be built the next time
> /etc/cron.weekly/mandb runs, or you can do it yourself using 'mandb -c' as
> user 'man'. In the meantime, the 'whatis' and 'apropos' commands will not
> be able to display any output.

But it isn't /etc/cron.weekly/mandb, it's /etc/cron.weekly/man-db!
And while I'm fixing that... there's no need to teach me mandb's
commandline options when I can run
	sudo /etc/cron.weekly/man-db
(if I wanted to know what that did, I'd read it).  So:

  If you do not build the database now, it will be built the next time
  /etc/cron.weekly/man-db is run (automatically or manually). Until then
  the 'whatis' and 'apropos' commands will not be able to display any
  output.

Another concern, but not serious enough for a patch, is that calling
things like this "on-line" help may be misleading.  It's a legacy of
the seventies when it was a noteworthy feature that UNIX manuals
came in a non-dead-tree format.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../man-db.old/debian/templates.master	2007-06-10 15:43:11.000000000 +0100
+++ debian/templates.master	2007-06-11 13:35:00.000000000 +0100
@@ -25,9 +25,9 @@
  other packages.
  .
  If you do not build the database now, it will be built the next time
- /etc/cron.weekly/mandb runs, or you can do it yourself using 'mandb -c' as
- user 'man'. In the meantime, the 'whatis' and 'apropos' commands will not
- be able to display any output.
+ /etc/cron.weekly/man-db is run (automatically or manually). Until then
+ the 'whatis' and 'apropos' commands will not be able to display any
+ output.
 
 Template: man-db/rebuild-database
 Type: boolean
@@ -40,8 +40,8 @@
  packages.
  .
  If you do not build the database now, it will be built the next time
- /etc/cron.weekly/mandb runs, or you can do it yourself using 'mandb -c' as
- user 'man'. In the meantime, the 'whatis' and 'apropos' commands will not
- be able to display any output.
+ /etc/cron.weekly/man-db is run (automatically or manually). Until then
+ the 'whatis' and 'apropos' commands will not be able to display any
+ output.
  .
  Incompatible changes like this should happen rarely.
--- ../man-db.old/debian/control	2007-06-10 15:43:11.000000000 +0100
+++ debian/control	2007-06-11 13:24:14.000000000 +0100
@@ -12,7 +12,7 @@
 Provides: man, man-browser
 Conflicts: man, suidmanager (<< 0.50)
 Replaces: man, nlsutils
-Description: The on-line manual pager
+Description: on-line manual pager
  This package provides the man command, the primary way of examining the
  on-line help files (manual pages). Other utilities provided include the
  whatis and apropos commands for searching the manual page database, the
Template: man-db/install-setuid
Type: boolean
Default: false
_Description: Should man and mandb be installed 'setuid man'?
 The man and mandb program can be installed with the set-user-id bit set, so
 that they will run with the permissions of the 'man' user. This allows
 ordinary users to benefit from the caching of preformatted manual pages
 ('cat pages'), which may aid performance on slower machines.
 .
 Cached man pages only work if you are using an 80-column terminal, to avoid
 one user causing cat pages to be saved at widths that would be inconvenient
 for other users. If you use a wide terminal, you can force man pages to be
 formatted to 80 columns anyway by setting MANWIDTH=80.
 .
 Enabling this feature may be a security risk, so it is disabled by default.
 If in doubt, you should leave it disabled.

Template: man-db/build-database
Type: boolean
Default: true
_Description: Should mandb build its database now?
 You do not yet have a database of manual page descriptions. Building one
 may take some time, depending on how many pages you have installed; it
 will happen in the background, possibly slowing down the installation of
 other packages.
 .
 If you do not build the database now, it will be built the next time
 /etc/cron.weekly/man-db is run (automatically or manually). Until then
 the 'whatis' and 'apropos' commands will not be able to display any
 output.

Template: man-db/rebuild-database
Type: boolean
Default: true
_Description: Should mandb build its database now?
 This version of man-db is incompatible with your existing database of
 manual page descriptions, so that database needs to be rebuilt. This may
 take some time, depending on how many pages you have installed; it will
 happen in the background, possibly slowing down the installation of other
 packages.
 .
 If you do not build the database now, it will be built the next time
 /etc/cron.weekly/man-db is run (automatically or manually). Until then
 the 'whatis' and 'apropos' commands will not be able to display any
 output.
 .
 Incompatible changes like this should happen rarely.
Source: man-db
Section: doc
Priority: important
Maintainer: Colin Watson <cjwatson@debian.org>
Standards-Version: 3.7.2
Build-Depends: debhelper (>= 4.0.0), flex, gettext, groff, libgdbm-dev

Package: man-db
Architecture: any
Depends: groff-base (>= 1.17.2-2), bsdmainutils, ${debconf-depends}, dpkg (>= 1.9.0), ${shlibs:Depends}
Suggests: groff, less, www-browser
Provides: man, man-browser
Conflicts: man, suidmanager (<< 0.50)
Replaces: man, nlsutils
Description: on-line manual pager
 This package provides the man command, the primary way of examining the
 on-line help files (manual pages). Other utilities provided include the
 whatis and apropos commands for searching the manual page database, the
 manpath utility for determining the manual page search path, and the
 maintenance utilities mandb, catman and zsoelim. man-db uses the groff
 suite of programs to format and display the manual pages.

Reply to: