[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://watchdog/{templates}



Christian Perrier wrote:
> Your review should be sent as an answer to this mail.

Just one suggestion for the control file:

> Package: watchdog
...
> Description: software watchdog
>  The watchdog program writes to /dev/watchdog every ten seconds.
>  If the device is opened but not written to within a minute, the machine
>  will reboot. This feature is available when the 'software watchdog' support
>  is compiled into the kernel.

Googling for "support compiled.into.the.kernel" shows that some
people use it in the sense intended here, which includes the
"CONFIG_SOFT_WATCHDOG=m" present in linux-image packages, while
other people use it in a more restrictive sense that requires 
"CONFIG_SOFT_WATCHDOG=y".  This makes it worth avoiding the phrase.
I would suggest:

                This feature is available when the kernel is built with
   'software watchdog' support (standard in Debian kernels).
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
--- ../watchdog.old/debian/templates	2007-06-02 15:07:11.000000000 +0100
+++ debian/templates	2007-06-08 23:04:01.000000000 +0100
@@ -9,15 +9,16 @@
 Type: boolean
 Default: false
 _Description: Restart watchdog on upgrades?
- If your kernel is configured with the CONFIG_WATCHDOG_NOWAYOUT option,
- restarting watchdog will cause a spurious reboot (the kernel will think
- the watchdog daemon crashed).
+ If the kernel is configured with the CONFIG_WATCHDOG_NOWAYOUT option,
+ restarting watchdog will cause a spurious reboot (the kernel will assume
+ that the watchdog daemon crashed).
 
 Template: watchdog/module
 Type: string
 Default: none
-_Description: Load watchdog module?
- Do you want the watchdog init script to preload a module for your watchdog
- driver before starting watchdog? The module "softdog" should work on all
- installations. If you don't want the script to load a module use "none".
+_Description: Watchdog module to preload:
+ Please choose which watchdog module should be preloaded before
+ starting watchdog. The 'softdog' module should be suited for all
+ installations. Enter 'none' if you don't want the script to load
+ a module.
 
--- ../watchdog.old/debian/control	2007-02-22 10:49:16.000000000 +0000
+++ debian/control	2007-06-08 23:05:39.000000000 +0100
@@ -10,9 +10,9 @@
 Depends: ${shlibs:Depends}, ${misc:Depends}, makedev (>= 2.3.1-24) | devfsd | udev
 Description: software watchdog
  The watchdog program writes to /dev/watchdog every ten seconds.
- If the device is open but not written to within a minute the machine
- will reboot -- a feature available when "software watchdog" support
- is compiled into the kernel.
+ If the device is opened but not written to within a minute, the machine
+ will reboot. This feature is available when the kernel is built with
+ 'software watchdog' support (standard in Debian kernels).
  .
  The ability to reboot will depend on the state of the machine
  and interrupts.
Template: watchdog/run
Type: boolean
Default: true
_Description: Start watchdog at boot time?
 Please specify whether watchdog should be started as part of the boot
 process. This can be changed later by editing /etc/default/watchdog.

Template: watchdog/restart
Type: boolean
Default: false
_Description: Restart watchdog on upgrades?
 If the kernel is configured with the CONFIG_WATCHDOG_NOWAYOUT option,
 restarting watchdog will cause a spurious reboot (the kernel will assume
 that the watchdog daemon crashed).

Template: watchdog/module
Type: string
Default: none
_Description: Watchdog module to preload:
 Please choose which watchdog module should be preloaded before
 starting watchdog. The 'softdog' module should be suited for all
 installations. Enter 'none' if you don't want the script to load
 a module.

Source: watchdog
Section: admin
Priority: extra
Maintainer: Michael Meskes <meskes@debian.org>
Build-Depends: debhelper (>> 4.1.13), po-debconf (>= 0.5.0)
Standards-Version: 3.6.2

Package: watchdog
Architecture: any
Depends: ${shlibs:Depends}, ${misc:Depends}, makedev (>= 2.3.1-24) | devfsd | udev
Description: software watchdog
 The watchdog program writes to /dev/watchdog every ten seconds.
 If the device is opened but not written to within a minute, the machine
 will reboot. This feature is available when the kernel is built with
 'software watchdog' support (standard in Debian kernels).
 .
 The ability to reboot will depend on the state of the machine
 and interrupts.

Reply to: