[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://ion3/{ion3.templates}



Please find, for review, the debconf templates of ion3.

This review will last from Sunday, June 03, 2007 to Wednesday, June 13, 2007.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

General note: the templates may seem to be debconf abuse but this has
been discussed with Ben Hutchings, the maintainer, and we concluded
that, given the very clumsy license of the upstream software, they're
better be kept.

Rationale:

@@ -1,3 +1,4 @@
 Template: ion3/acknowledge-outdated
 Type: boolean
 Default: false
@@ -6,11 +7,12 @@
  the latest version released by the author.
  .
  DO NOT send bug reports or questions to the author unless they apply
- to the latest version, available from:
+ to the latest version, available at:
   http://modeemi.fi/~tuomov/ion/download.html
  .
- You should send any bug reports about this package to the Debian bug
- tracking system and any other questions to the Debian maintainer.
+ Otherwise, you should send any bug reports about this package to the
+ Debian bug tracking system and any other questions to the Debian
+ maintainer.

Make both templates consistent.

 
 Template: ion3/acknowledge-maybe-outdated
 Type: boolean
@@ -29,6 +31,6 @@
 
 Template: ion3/did-not-acknowledge-outdated
 Type: error
-Description: You did not acknowledge installation of an old version.
- You must acknowledge that the author does not support old versions
+Description: Non acknowledged installation of an old version
+ Please acknowledge that the author does not support old versions
  and should not be contacted about them.

Recommended writing style for error/note: no sentence in short descriptions.

--- /home/bubulle/travail/debian/rewrite/INTENT/ion3/ion3.old/debian/control	2007-05-25 08:09:25.764023301 +0200
+++ /home/bubulle/travail/debian/rewrite/INTENT/ion3/ion3/debian/control	2007-06-03 10:03:09.654315115 +0200
@@ -20,16 +20,14 @@
  easier. Flexible configuration is possible thanks to Lua, which is
  used as the configuration language.
  .
- There is also support for so-called "floating workspaces" where
+ There is also support for so-called 'floating workspaces' where

Consistent use of quotes among packages.


  windows are managed the conventional way, so that you can still run
  applications which do not fit very well into Ion's window management
  approach. A pwm3 binary is included which starts Ion with floating
  workspaces as the default, thus replacing the now obsolete PWM window
  manager.
  .
- This is the current development branch of Ion.
- .
- Website: http://iki.fi/tuomov/ion/
+  Homepage: http://iki.fi/tuomov/ion/

I think it's not very scalable to mention the vesion is a development
version in tha package's description. That may change in the future.

 
 Package: ion3-dev
 Section: non-free/devel
@@ -38,7 +36,7 @@
 Depends: libx11-dev, libsm-dev, lua5.1, gcc (>> 3)
 Description: ion3 development files
  This package contains the files necessary for building extension
- modules to the window manager Ion.
+ modules to the Ion window manager.


Consistent style and better English(?)
 
 Package: ion3-doc
 Section: non-free/doc
@@ -46,6 +44,6 @@
 Recommends: lynx | www-browser
 Suggests: doc-base, dwww | doc-central | dhelp
 Description: ion3 documentation
- This package contains the document "Configuring and extending Ion3
- with Lua" which explains how to configure and extend the window
- manager Ion.
+ This package contains the document 'Configuring and extending Ion3
+ with Lua' which explains how to configure and extend the Ion window
+ manager.

Quoting changed.

-- 


Template: ion3/acknowledge-outdated
Type: boolean
Default: false
_Description: Do you understand this version is not supported by the author?
 The version of Ion3 you are installing (version ${version}) is not
 the latest version released by the author.
 .
 DO NOT send bug reports or questions to the author unless they apply
 to the latest version, available at:
  http://modeemi.fi/~tuomov/ion/download.html
 .
 Otherwise, you should send any bug reports about this package to the
 Debian bug tracking system and any other questions to the Debian
 maintainer.

Template: ion3/acknowledge-maybe-outdated
Type: boolean
Default: false
_Description: Do you understand this version may not be supported by the author?
 The version of Ion3 you are installing (version ${version}) may not
 be the latest version released by the author.
 .
 DO NOT send bug reports or questions to the author unless they apply
 to the latest version, available at:
  http://modeemi.fi/~tuomov/ion/download.html
 .
 Otherwise, you should send any bug reports about this package to the
 Debian bug tracking system and any other questions to the Debian
 maintainer.

Template: ion3/did-not-acknowledge-outdated
Type: error
Description: Non acknowledged installation of an old version
 Please acknowledge that the author does not support old versions
 and should not be contacted about them.
--- ../ion3.old/debian/ion3.templates	2007-05-25 08:09:25.764023301 +0200
+++ debian/ion3.templates	2007-06-03 10:02:15.157101536 +0200
@@ -1,3 +1,4 @@
+# This template is blatant debconf abuse
 Template: ion3/acknowledge-outdated
 Type: boolean
 Default: false
@@ -6,11 +7,12 @@
  the latest version released by the author.
  .
  DO NOT send bug reports or questions to the author unless they apply
- to the latest version, available from:
+ to the latest version, available at:
   http://modeemi.fi/~tuomov/ion/download.html
  .
- You should send any bug reports about this package to the Debian bug
- tracking system and any other questions to the Debian maintainer.
+ Otherwise, you should send any bug reports about this package to the
+ Debian bug tracking system and any other questions to the Debian
+ maintainer.
 
 Template: ion3/acknowledge-maybe-outdated
 Type: boolean
@@ -29,6 +31,6 @@
 
 Template: ion3/did-not-acknowledge-outdated
 Type: error
-Description: You did not acknowledge installation of an old version.
- You must acknowledge that the author does not support old versions
+Description: Non acknowledged installation of an old version
+ Please acknowledge that the author does not support old versions
  and should not be contacted about them.
--- ../ion3.old/debian/control	2007-05-25 08:09:25.764023301 +0200
+++ debian/control	2007-06-03 10:03:09.654315115 +0200
@@ -20,16 +20,14 @@
  easier. Flexible configuration is possible thanks to Lua, which is
  used as the configuration language.
  .
- There is also support for so-called "floating workspaces" where
+ There is also support for so-called 'floating workspaces' where
  windows are managed the conventional way, so that you can still run
  applications which do not fit very well into Ion's window management
  approach. A pwm3 binary is included which starts Ion with floating
  workspaces as the default, thus replacing the now obsolete PWM window
  manager.
  .
- This is the current development branch of Ion.
- .
- Website: http://iki.fi/tuomov/ion/
+  Homepage: http://iki.fi/tuomov/ion/
 
 Package: ion3-dev
 Section: non-free/devel
@@ -38,7 +36,7 @@
 Depends: libx11-dev, libsm-dev, lua5.1, gcc (>> 3)
 Description: ion3 development files
  This package contains the files necessary for building extension
- modules to the window manager Ion.
+ modules to the Ion window manager.
 
 Package: ion3-doc
 Section: non-free/doc
@@ -46,6 +44,6 @@
 Recommends: lynx | www-browser
 Suggests: doc-base, dwww | doc-central | dhelp
 Description: ion3 documentation
- This package contains the document "Configuring and extending Ion3
- with Lua" which explains how to configure and extend the window
- manager Ion.
+ This package contains the document 'Configuring and extending Ion3
+ with Lua' which explains how to configure and extend the Ion window
+ manager.
Source: ion3
Section: non-free/x11
Priority: extra
Maintainer: Ben Hutchings <ben@decadent.org.uk>
Standards-Version: 3.7.2.0
Build-Depends: debhelper (>= 4.1.16), gcc (>> 3), libx11-dev, libxext-dev, libsm-dev, liblua5.1-0-dev, lua5.1, dpatch, pkg-config, groff-base, po-debconf

Package: ion3
Section: non-free/x11
Architecture: any
Depends: ${shlibs:Depends}, xterm | x-terminal-emulator, debconf, devscripts, libwww-perl
Suggests: menu (>= 2.1.9), docker, ion3-scripts
Conflicts: ion (<< 0.0.20020207-7), ion3-old
Recommends: xfonts-75dpi | xfonts-75dpi-transcoded | xfonts-100dpi | xfonts-100dpi-transcoded
Provides: x-window-manager, ion3-api-${Ion:ApiVersion}
Description: keyboard-friendly window manager with tiled windows
 Ion, based on PWM, is an unusual window manager with no overlapping
 windows. Windows are placed in tabbed frames which may be arbitrarily
 split to create additional frames, making keyboard navigation much
 easier. Flexible configuration is possible thanks to Lua, which is
 used as the configuration language.
 .
 There is also support for so-called 'floating workspaces' where
 windows are managed the conventional way, so that you can still run
 applications which do not fit very well into Ion's window management
 approach. A pwm3 binary is included which starts Ion with floating
 workspaces as the default, thus replacing the now obsolete PWM window
 manager.
 .
  Homepage: http://iki.fi/tuomov/ion/

Package: ion3-dev
Section: non-free/devel
Priority: extra
Architecture: all
Depends: libx11-dev, libsm-dev, lua5.1, gcc (>> 3)
Description: ion3 development files
 This package contains the files necessary for building extension
 modules to the Ion window manager.

Package: ion3-doc
Section: non-free/doc
Architecture: all
Recommends: lynx | www-browser
Suggests: doc-base, dwww | doc-central | dhelp
Description: ion3 documentation
 This package contains the document 'Configuring and extending Ion3
 with Lua' which explains how to configure and extend the Ion window
 manager.

Attachment: signature.asc
Description: Digital signature


Reply to: