[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [RFR] templates://alsa-driver/{alsa-source.templates,linux-sound-base.templates}



Christian Perrier wrote:
> Please find, for review, the debconf templates of alsa-driver.

I've got some concerns with the control file, too - in summary: it
doesn't suggest any reason why anyone would want to compile a
custom alsa-modules package from alsa-source.  But I'll give a
separate diff for that (if I ever work out what the answer is).

> Template: alsa-source/cards_to_be_built
...
> _Description: ALSAdrivers to build:
>  Please select the ALSA sound card drivers that should be included
>  in alsa-modules packages that are built from the sources
>  included in the alsa-source package.

Disconcertingly reminiscent of a certain nursery rhyme - "these are
the drivers that killed the rat that nibbled the malt that lay in
the package that Jack built"... how about: 
  Please select the ALSA sound card drivers that should be included
  in alsa-modules packages built from these sources.

> Template: linux-sound-base/sound_system
...
> _Description: Sound system to use:
>  ALSA and OSS are alternative systems of drivers for
>  sound hardware.
>  .
>  Selecting ALSA or OSS will enforce the use of such driver
>  even in cases where both drivers exist.

Of such _a_ driver, or maybe "of the corresponding driver".

>  Choosing the "default" option will leave this choice to the hardware
>  detection mechanism and may depend upon the kernel version.

That last clause is a bit wrong; it says that "[manually] choosing X
may depend on Y", where what you want to say is that "this
[automated] choice may depend on Y".  How about:

  Choosing the "default" option will mean this decision is left to the
  hardware detection mechanism, and may depend upon the kernel version.
-- 
JBR
Ankh kak! (Ancient Egyptian blessing)
Template: alsa-source/has_pnp
Type: boolean
Default: true
_Description: Build ALSA drivers with ISA PnP support?
 If you choose this option, the ALSA drivers will be built with
 support for the isa-pnp driver.

Template: alsa-source/debug
Type: boolean
Default: false
_Description: Build ALSA drivers with debugging code?
 If you choose this option, the ALSA drivers will be built with
 code to help with debugging.

Template: alsa-source/cards_to_be_built
Type: multiselect
Default: all
#flag:translate:1
__Choices: all, ${alsa_cards}
#flag:translate!:4
_Description: ALSAdrivers to build:
 Please select the ALSA sound card drivers that should be included
 in alsa-modules packages built from these sources.
 .
 The following is a list of available sound card drivers
 along with short descriptions.
 .
 ${alsa_cards_with_descriptions}

Template: alsa-source/cards
Type: select
Choices: _CARDS_WITHOUT_DESCRIPTIONS_
Description: for internal use
 Really, it isn't. Trust me.

Template: alsa-source/cards_with_descriptions
Type: select
Choices: _CARDS_WITH_DESCRIPTIONS_
Description: for internal use
 Really, it isn't. Trust me.
Template: linux-sound-base/sound_system
Type: select
#flag:translate:3
__Choices: ALSA, OSS, default
Default: ALSA
_Description: Sound system to use:
 ALSA and OSS are alternative systems of drivers for
 sound hardware.
 .
 Selecting ALSA or OSS will enforce the use of the corresponding
 driver even in cases where both drivers exist.
 .
 Choosing the "default" option will mean this decision is left to the
 hardware detection mechanism and may depend upon the kernel version.
 Removing the linux-sound-base package effectively puts the system into
 "default" mode.
 .
 Choosing the ALSA sound system is strongly recommended.
--- ../alsa-driver.old/debian/alsa-source.templates	2007-05-06 16:00:54.000000000 +0100
+++ debian/alsa-source.templates	2007-05-06 16:55:03.000000000 +0100
@@ -2,14 +2,14 @@
 Type: boolean
 Default: true
 _Description: Build ALSA drivers with ISA PnP support?
- If you agree then the ALSA drivers will be built with
+ If you choose this option, the ALSA drivers will be built with
  support for the isa-pnp driver.
 
 Template: alsa-source/debug
 Type: boolean
 Default: false
 _Description: Build ALSA drivers with debugging code?
- If you agree then the ALSA drivers will be built with
+ If you choose this option, the ALSA drivers will be built with
  code to help with debugging.
 
 Template: alsa-source/cards_to_be_built
@@ -19,9 +19,8 @@
 __Choices: all, ${alsa_cards}
 #flag:translate!:4
 _Description: ALSAdrivers to build:
- Select the ALSA sound card drivers that should be included
- in alsa-modules packages that are built from the sources
- included in the alsa-source package.
+ Please select the ALSA sound card drivers that should be included
+ in alsa-modules packages built from these sources.
  .
  The following is a list of available sound card drivers
  along with short descriptions.
@@ -39,4 +38,3 @@
 Choices: _CARDS_WITH_DESCRIPTIONS_
 Description: for internal use
  Really, it isn't. Trust me.
-
--- ../alsa-driver.old/debian/linux-sound-base.templates	2007-05-06 16:00:54.000000000 +0100
+++ debian/linux-sound-base.templates	2007-05-06 16:56:05.000000000 +0100
@@ -7,16 +7,12 @@
  ALSA and OSS are alternative systems of drivers for
  sound hardware.
  .
- If either ALSA or OSS is selected then in cases where
- both systems offer a driver, only the driver from the
- selected sound system will be automatically loaded by
- hotplug or discover. If "default" is selected then the
- choice of which drivers to load automatically will be
- left up to hotplug or discover and may depend upon the
- kernel version. Removing the linux-sound-base package
- effectively puts the system into "default" mode.
+ Selecting ALSA or OSS will enforce the use of the corresponding
+ driver even in cases where both drivers exist.
  .
- The ALSA sound system is recommended. Select OSS only if
- you are using a 2.4 kernel and you do not want to
- install an alsa-modules package, or if the OSS driver
- works with your hardware and the ALSA driver does not.
+ Choosing the "default" option will mean this decision is left to the
+ hardware detection mechanism and may depend upon the kernel version.
+ Removing the linux-sound-base package effectively puts the system into
+ "default" mode.
+ .
+ Choosing the ALSA sound system is strongly recommended.

Reply to: