[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#750360: systemd-sysv: breaks NFS root systems



Control: tags -1 + patch

> initramfs-tools could just use a check like
> 
> chroot /root test -x /sbin/init
> 
> Then it doesn't matter whether it's a relative or absolute symlink.

I made the needed fix in the script and tested in our terminal server
environment. It works as expected and I do not see any side effects.

Therefore, I propose this as a fix to be included in initramfs-tools,
kindly sponsored by Teckids.

-nik

-- 
Dominik George (Vorstandsvorsitzender)
Teckids e.V. (i.Gr.) - Erkunden, Entdecken, Erfinden.
https://www.teckids.org

PGP-Fingerprint: 3C9D 54A4 7575 C026 FB17  FD26 B79A 3C16 A0C4 F296
diff -Nru initramfs-tools-0.115/debian/changelog initramfs-tools-0.115+nmu1/debian/changelog
--- initramfs-tools-0.115/debian/changelog	2013-11-04 10:10:24.000000000 +0100
+++ initramfs-tools-0.115+nmu1/debian/changelog	2014-06-03 10:59:22.000000000 +0200
@@ -1,3 +1,11 @@
+initramfs-tools (0.115+nmu1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * scripts/nfs: chroot for init existence test to fix symlink
+    issues (Closes: #750360)
+
+ -- Dominik George <nik@naturalnet.de>  Tue, 03 Jun 2014 10:57:19 +0200
+
 initramfs-tools (0.115) unstable; urgency=low
 
   [ Nikolaus Schulz ]
diff -Nru initramfs-tools-0.115/scripts/nfs initramfs-tools-0.115+nmu1/scripts/nfs
--- initramfs-tools-0.115/scripts/nfs	2013-08-02 10:11:21.000000000 +0200
+++ initramfs-tools-0.115+nmu1/scripts/nfs	2014-06-03 10:57:12.000000000 +0200
@@ -66,7 +66,7 @@
 
 	# loop until nfsmount succeeds
 	do_nfsmount
-	while [ ${retry_nr} -lt ${delay} ] && [ ! -e ${rootmnt}${init} ]; do
+	while [ ${retry_nr} -lt ${delay} ] && ! chroot "${rootmnt}" test -x "${init}" ; do
 		[ "$quiet" != "y" ] && log_begin_msg "Retrying nfs mount"
 		/bin/sleep 1
 		do_nfsmount

Attachment: signature.asc
Description: Digital signature


Reply to: