Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
- To: Brian Norris <computersforpeace@gmail.com>
- Cc: Ben Hutchings <ben@decadent.org.uk>, Geert Uytterhoeven <geert@linux-m68k.org>, Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>, linux-spi <linux-spi@vger.kernel.org>, Huang Shijie <shijie8@gmail.com>, MTD Maling List <linux-mtd@lists.infradead.org>, Ian Campbell <ijc@hellion.org.uk>, debian-kernel <debian-kernel@lists.debian.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>
- Subject: Re: [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
- From: Rafał Miłecki <zajec5@gmail.com>
- Date: Mon, 29 Sep 2014 11:53:14 +0200
- Message-id: <[🔎] CACna6ry91b3wcHsG4C-td+STPuiaH7oaAcQuKiKdhud+jctUeA@mail.gmail.com>
- In-reply-to: <[🔎] CACna6rx=GyZ-4JpDix==WKszABseQXK6qCCkfiKCm9-WzBmM3A@mail.gmail.com>
- References: <[🔎] 1410714624.3040.38.camel@decadent.org.uk> <[🔎] 1410714670.3040.39.camel@decadent.org.uk> <[🔎] 20140928222150.GC3248@norris-Latitude-E6410> <[🔎] CACna6rx=GyZ-4JpDix==WKszABseQXK6qCCkfiKCm9-WzBmM3A@mail.gmail.com>
On 29 September 2014 08:36, Rafał Miłecki <zajec5@gmail.com> wrote:
> 1) The main urgent issue: broken auto-loading
> Tracked in the thread: http://www.spinics.net/lists/linux-spi/msg01726.html
> Problem: m25p80.c references spi_nor_ids (from external file)
> Short-term solution: duplicate IDs in the m25p80.c
>
> Ben: just like Brian, I think the patch like this one (
> [PATCH 1/5] m25p80,spi-nor: Fix module aliases for m25p80
> ) is the way to go. However few comments:
I started wondering... would this be possible to fix all m25p80 users
instead? Make them always specify modalias as "m25p80" and then
provide platform_data if needed?
Has anyone checked in how many places we use "wrong" (or should I say
"weird") modaliases? I guess some would need to grep kernel for all
possible names.
Reply to: