Bug#656476: Sundance network driver (D-Link DFE-580TX) timeouts rendering interface unusable
Le lundi 30 janvier 2012 à 14:41 +0000, Ben Hutchings a écrit :
> On Mon, 2012-01-30 at 15:28 +0100, Eric Dumazet wrote:
> > Le lundi 30 janvier 2012 à 14:05 +0000, Ben Hutchings a écrit :
> >
> > > Yes, I spotted that. But no descriptors are pushed to the hardware
> > > here; that's done in the driver's TX tasklet. Although... maybe that
> > > can run immediately when scheduled from here? I've never had to deal
> > > with tasklets so I really don't know their semantics.
> >
> > Thats probable on SMP ...
>
> The bug report is for a UP system running a kernel built with
> SMP-alternatives.
Hmm, TX _completion_ is not run from tasklet but hardware IRQ, this is
why I added the spin_lock_irqsave().
Tasklet fires the TX, but hardware IRQ does the TX completion part.
This driver is ... interesting :)
Reply to: