[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#655387: [PATCH] usb: cdc_ether: Ignore bogus union descriptor for RNDIS devices



Am Dienstag, 10. Januar 2012, 23:15:16 schrieb Bjørn Mork:
> -                               goto bad_desc;
> +                               /* Fallback to guessing for rndis
> +                                * class devices with bogus union
> +                                * descriptor.
> +                                * Fixes some Samsung Android devices
> +                                */
> +                               if (rndis)
> +                                       info->u = NULL;
> +                               else
> +                                       goto bad_desc;

You are trying something subtle here. Stop doing that. Use a dedicated flag
or a clearly named goto.

	Regards
		Oliver



Reply to: