Re: [PATCH] lockdep, bug: Exclude TAINT_OOT_MODULE from disabling lock debugging
On Wed, 07 Dec 2011 14:30:58 +0000, Ben Hutchings <ben@decadent.org.uk> wrote:
> We do want to allow lock debugging for GPL-compatible modules that are
> not (yet) built in-tree. This was disabled as a side-effect of commit
> 2449b8ba0745327c5fa49a8d9acffe03b2eded69 ('module,bug: Add
> TAINT_OOT_MODULE flag for modules not built in-tree'). Lock debug
> warnings now include taint flags, so kernel developers should still
> be able to deflect warnings caused by out-of-tree modules.
>
> The TAINT_PROPRIETARY_MODULE flag for non-GPL-compatible modules will
> still disable lock debugging.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Meh. Disabling lock debugging was always a weird thing to do, IMHO.
Taint flags should be used for warnings to developers, not these strange
side-effects.
Cheers,
Rusty.
Reply to: