[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#635653: marked as done ([linux-2.6] Please pick: iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty)

Your message dated Sat, 3 Sep 2011 01:05:55 -0500
with message-id <20110903060555.GA7548@elie>
and subject line Re: [linux-2.6] Please pick: iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty
has caused the Debian Bug report #635653,
regarding [linux-2.6] Please pick: iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
635653: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=635653
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-2.6
Version: 3.0.0-1-amd64
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

There is a mean bug in the 3.0 version of the iwlagn driver causing a 
kernel panic when going into suspend with a wireless card that is down. 
However, there is a fix for that already that is small clean and works 
like a charm. It would be nice if you could cherry pick it for the next 
update, thanks.

For the origin of the patch and further info see [1]. 

Kind regards,
Florian.


[1] https://patchwork.kernel.org/patch/1005892/

--- System information. ---
Architecture: amd64
Kernel:       Linux 3.0.0-1-amd64

Debian Release: wheezy/sid
  500 unstable        www.debian-multimedia.org 
  500 unstable        ftp.de.debian.org 
  500 testing         ftp.de.debian.org 
  100 experimental-snapshots qt-kde.debian.net 
    1 experimental    ftp.de.debian.org 


diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
index f803fb6..d6ae444 100644
--- a/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
+++ b/drivers/net/wireless/iwlwifi/iwl-agn-lib.c
@@ -1487,6 +1487,9 @@  int iwlagn_wait_tx_queue_empty(struct iwl_priv *priv)
 	unsigned long now = jiffies;
 	int ret = 0;
 
+	if (!priv->txq)
+		return 0;
+
 	/* waiting for all the tx frames complete might take a while */
 	for (cnt = 0; cnt < priv->hw_params.max_txq_num; cnt++) {
 		if (cnt == priv->cmd_queue)

--- End Message ---
--- Begin Message --- 
Version: 3.1.0~rc4-1~experimental.1

Florian Kriener wrote:

> Short version: Yes it works, but the patch did not apply to the curren 
> linux-source package.

It probably makes sense to include something like your backport in
gregkh's 3.0.y stable series; please contact stable@kernel.org if you
want to do so.  Even if that doesn't happen, the fix will be in v3.1
and it is already fixed in the release candidates packaged for Debian
experimental.  Thanks for testing.

--- End Message ---
Reply to: