[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#638656: br2684: Sent packets truncated in VC routed mode



Package: linux-2.6
Version: 3.0.0-2
Tags: upstream, patch, fixed-upstream

Hello,

The transmit function for VC-MUX routed encapsulation wrongly
strips an ethernet header from IP packets, but there is no ethernet
header so it actually truncates the IP header.

The bug was introduced in Linux 2.6.26. It was fixed upstream in
Linux 3.1-rc1 and 3.0.3 by the following patch which has been added to
the 2.6.32-longterm queue and will hopefully be included in the next
2.6.32.46 release.

Please fix Linux 2.6.32 in Squeeze/stable.

The bug also exists in Linux 2.6.26 in Lenny/oldstable but the br2684ctl
package in Lenny/oldstable does not support routed mode.

Regards.

---------------

commit 55041e081ef433774279ecb6fc3fd30f741f5f37
From: Chas Williams <chas@cmf.nrl.navy.mil>
Date: Mon, 1 Aug 2011 17:56:14 -0700
Subject: atm: br2864: sent packets truncated in VC routed mode

commit a08af810cdc29d2ca930e8a869d3d01744c392d8 upstream.

Reported-by: Pascal Hambourg <pascal@plouf.fr.eu.org>
Signed-off-by: Chas Williams <chas@cmf.nrl.navy.mil>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 net/atm/br2684.c |    2 --
 1 file changed, 2 deletions(-)

--- a/net/atm/br2684.c
+++ b/net/atm/br2684.c
@@ -242,8 +242,6 @@ static int br2684_xmit_vcc(struct sk_buf
 		if (brdev->payload == p_bridged) {
 			skb_push(skb, 2);
 			memset(skb->data, 0, 2);
-		} else { /* p_routed */
-			skb_pull(skb, ETH_HLEN);
 		}
 	}
 	skb_debug(skb);




Reply to: