Bug#524438: [2.6.27.y] Re: cifs: Crash (OOPS or restart) when accessing Windows ME share with accented characters in filenames
On Thu, Jul 07, 2011 at 05:00:57AM +0100, Ben Hutchings wrote:
> On Wed, 2011-07-06 at 19:49 -0500, Jonathan Nieder wrote:
> > Hi,
> > Ben Hutchings wrote:
> > > We got this fix via 220.127.116.11:
> > [...]
> > > [CIFS] make sure we have the right resume info before calling CIFSFindNext
> > [...]
> > > But it requires these additional fixes which we're missing for some
> > > reason:
> > >
> > > commit b77d753c413e02559669df66e543869dad40c847
> > > Author: Steve French <firstname.lastname@example.org>
> > > Date: Wed Oct 8 19:13:46 2008 +0000
> > >
> > > [CIFS] Check that last search entry resume key is valid
> > This one does not seem to be part of Willy Tarreau's v2.6.27.y tree.
> > Should it be?
> I assume so, but Steve should confirm or deny.
Interestingly I notice that a number of CIFS changes that were applied between
2.6.27 and 2.6.28 were not backported (just checked git logs for cifssmb.c) :
331c31351044888916805c9cb32d8bb9e40c12e9 cifs: fix buffer overrun in parse_DFS_referrals
2c55608f28444c3f33b10312881384c470ceed56 Fixed parsing of mount options when doing DFS submount
9a8165fce724d1aba21e2c713ac6ba11dbfecafa cifs: track DeletePending flag in cifsInodeInfo
b77d753c413e02559669df66e543869dad40c847 [CIFS] Check that last search entry resume key is valid
391e575556109744ae0aa198c1e245588a3ea76a cifs: remove NULL termination from rename target in CIFSSMBRenameOpenFI
6d22f09896c0d62c003ffa25fff25323e3ed608b cifs: add function to set file disposition
Their description makes me think that at least the 5 first ones need to
be backported, but I may be wrong since I don't know their implications.
Steve, it would be ver kind of you if you could take a few minutes to check
them and confirm/deny the backport for each of them. If you think other patches
are missing, please do not hesitate to tell me so.