[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#631572: marked as done (linux-2.6: kconfig.py confuses unset (through a comment) with set to "no")

Your message dated Sat, 25 Jun 2011 00:42:32 +0100
with message-id <20110624234232.GU29924@decadent.org.uk>
and subject line Re: Bug#631572: linux-2.6: kconfig.py confuses unset (through a comment) with set to "no"
has caused the Debian Bug report #631572,
regarding linux-2.6: kconfig.py confuses unset (through a comment) with set to "no"
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
631572: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=631572
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: linux-2.6
Severity: normal

debian/lib/python/debian_linux/kconfig.py considers that:
# CONFIG_EXAMPLE is not set

is equivalent to:
CONFIG_EXAMPLE=n

For example, if debian/config/kernelarch-x86/config contains:
# CONFIG_CRASH_DUMP is not set

and one adds to debian/config/config:
CONFIG_CRASH_DUMP=y

then a kernel built for x86 will NOT have CONFIG_CRASH_DUMP.

This behaviour is due to lines 59-61 in kconfig.py:
            elif line.startswith("# CONFIG_"):
                option = line[9:-11]
                self.set(option, 'n')

IMHO:
1) A comment shouldn't be parsed, except for "meta-comments", which
   should be well documented (as in, huge warning in the same file,
   like done with grub config wrapper).
2) Being "unset" is not the same as being set to no, and if taken into
   account (which looks unecessary) being set should have a higher prio.
3) This current behaviour is extremely counter-intuitive.

I'm worried by the amount of time I lost on this, and hope others won't :)

-- System Information:
Debian Release: 6.0.1
  APT prefers stable
  APT policy: (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-238.9.1.el5.028stab089.1 (SMP w/8 CPU cores)
        (running in a container, please ignore)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

--- End Message ---
--- Begin Message --- 
On Sat, Jun 25, 2011 at 02:50:28AM +0400, Pierre Carrier wrote:
> Package: linux-2.6
> Severity: normal
> 
> debian/lib/python/debian_linux/kconfig.py considers that:
> # CONFIG_EXAMPLE is not set

This is correct kconfig syntax.

> is equivalent to:
> CONFIG_EXAMPLE=n
[...]

This is not.

I know it's weird that comments are parsed.  But that is how the
upstream kconfig system works, and we try to be consistent with it.

Ben.

-- 
Ben Hutchings
We get into the habit of living before acquiring the habit of thinking.
                                                              - Albert Camus

--- End Message ---
Reply to: