[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: linux-2.6_2.6.38-5_m68k.changes ACCEPTED



On Thu, 2011-05-12 at 03:36 +0100, Ben Hutchings wrote:
[...]
> > warning: (NETFILTER_XT_MATCH_REALM) selects NET_CLS_ROUTE which has unmet direct dependencies (NET && NET_SCHED)
> 
> The dependencies for NETFILTER_XT_MATCH_REALM  should be fixed.  But why
> is NET_SCHED disabled on m68k, anyway?

Fixed in 2.6.39.

[...]
> > drivers/char/tpm/tpm_tis.c:96: warning: 'is_itpm' defined but not used
> 
> The definition of this function should be conditional on CONFIG_PNP.
> 
> Anyway, I don't think the TPM drivers could be used on most non-x86
> architectures.  We should just disable them.

Disabled on trunk.

[...]
> > CC [M]  drivers/net/zorro8390.o
> > drivers/net/lib8390.c:256: warning: '__ei_tx_timeout' defined but not used
> > drivers/net/lib8390.c:302: warning: '__ei_start_xmit' defined but not used
> > drivers/net/lib8390.c:526: warning: '__ei_poll' defined but not used
> > drivers/net/lib8390.c:879: warning: '__ei_get_stats' defined but not used
> > drivers/net/lib8390.c:981: warning: '__ei_set_multicast_list' defined but not used
> > drivers/net/lib8390.c:1016: warning: '____alloc_ei_netdev' defined but not used
> 
> It looks like zorro8390.c should be using these functions instead of the
> corresponding functions without the double-underscore prefixes.  At the
> moment it's using some functions built from the #included lib8390.c
> using the special definition of EI_SHIFT (from zorro8390.c), and some
> functions exported from the 8390 module, which are built with the
> default definition of EI_SHIFT (from 8390.h).
> 
> > CC [M]  drivers/net/hydra.o
> > drivers/net/lib8390.c:256: warning: '__ei_tx_timeout' defined but not used
> > drivers/net/lib8390.c:302: warning: '__ei_start_xmit' defined but not used
> > drivers/net/lib8390.c:526: warning: '__ei_poll' defined but not used
> > drivers/net/lib8390.c:879: warning: '__ei_get_stats' defined but not used
> > drivers/net/lib8390.c:981: warning: '__ei_set_multicast_list' defined but not used
> > drivers/net/lib8390.c:1016: warning: '____alloc_ei_netdev' defined but not used
> 
> Similar issue in hydra.c.

Both fixed by Geert in net-2.6 and cc'd to stable.

[...]
> > drivers/video/mb862xx/mb862xxfb.c:326: warning: 'mb862xxfb_init_fbinfo' defined but not used
> > drivers/video/mb862xx/mb862xxfb.c:464: warning: 'dev_attr_dispregs' defined but not used
> 
> Bug in the Kconfig.  This driver should not be built on non-PCI
> machines.
[...]

I've sent a patch to the video maintainer.

Ben.

-- 
Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: