On Mon, 2010-11-29 at 11:48 +1100, Neil Brown wrote:
> On Mon, 29 Nov 2010 00:08:47 +0000 Ben Hutchings <benh@debian.org> wrote:
>
> > >
> > > if (q->merge_bvec_fn && !ti->type->merge)
> > > limits->max_segments = 1;
> > >
> > > (the test on ->type->merge is important and applies to 2.6.26 as well).
> >
> > Why is it not necessary to set seg_boundary_mask to PAGE_CACHE_SIZE - 1,
> > as for md devices?
> >
>
> Sorry. It is necessary of course. I guess I was being a bit hasty and
> forgetting all the details.
>
> if (q->merge_bvec_fn && !ti->type->merge) {
> limits->max_segments = 1; /* Make sure only one segment in each bio */
> limits->seg_boundary_mask = PAGE_CACHE_SIZE-1; /* make sure that
> segment is in just one page */
> }
Thanks again. I'll apply this change in Debian and try to get it
upstream if we don't see any regressions.
Ben.
--
Ben Hutchings, Debian Developer and kernel team member
Attachment:
signature.asc
Description: This is a digitally signed message part