On Mon, 29 Nov 2010 00:08:47 +0000 Ben Hutchings <benh@debian.org> wrote:
> >
> > if (q->merge_bvec_fn && !ti->type->merge)
> > limits->max_segments = 1;
> >
> > (the test on ->type->merge is important and applies to 2.6.26 as well).
>
> Why is it not necessary to set seg_boundary_mask to PAGE_CACHE_SIZE - 1,
> as for md devices?
>
Sorry. It is necessary of course. I guess I was being a bit hasty and
forgetting all the details.
if (q->merge_bvec_fn && !ti->type->merge) {
limits->max_segments = 1; /* Make sure only one segment in each bio */
limits->seg_boundary_mask = PAGE_CACHE_SIZE-1; /* make sure that
segment is in just one page */
}
NeilBrown
Attachment:
signature.asc
Description: PGP signature