[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [PATCH]: linux-2.6: use string operators instead of numeric ones for string concatenation

On Fri, 2010-09-03 at 09:42 +0200, Stefan Lippers-Hollmann wrote:
> Revision 16224 of svn://svn.debian.org/svn/kernel/dists/trunk/linux-2.6 
> enabled "use strict;" and "use warnings;" for the perl based maintainer 
> scripts of linux-image-@upstreamversion@@abiname@@localversion@, this in 
> turn exposed that the numeric '+=' operator is used to concatenate 
> $message and $dir_message variables; this patch fixes this by using the 
> string operator '.='.

Thanks for testing and reporting this.  This sort of stupid bug is
exactly why we need those directives.  However, given that this bug was
introduced by:

kernel-package (10.037) unstable; urgency=medium

  * Vy popular demand, we toned down the checks for overwriting previously
    installed kernels. Instead of checking for /lib/modules/$version, we
    only check is /lib/modules/$version/kernel exists. This means that
    third party modules shall not trigger any interactions with the user;
    it is up to the users to handle incompatibilites between previously
    installed third party modules and the new kernel. No check on
    official kernel images -- any incompatibilities should result in an
    ABI number change.

 -- Manoj Srivastava <srivasta@debian.org>  Wed, 22 Mar 2006 14:24:16 -0600

and makes the check() subroutine completely useless, and no-one seems to
have complained, I think we could just remove it.


Ben Hutchings
Once a job is fouled up, anything done to improve it makes it worse.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: