On Wed, 2010-07-28 at 09:57 +0100, Ian Campbell wrote: > On Wed, 2010-07-28 at 03:43 +0100, Ben Hutchings wrote: > > On Tue, 2010-07-27 at 15:44 +0100, Ian Campbell wrote: > > > The pvhvm drivers for Xen allow a fully virtualised guest (aka HVM) to > > > use the Xen PV disk and network interfaces the same as a Xen guest > > > running paravirtualised, in addition they allow for PV time and event > > > delivery, suspend/resume support and PV hooks to improve performance > > > under shadow page tables. > > > > > > The drivers are currently in linux-next and are expected to go in during > > > the next merge window. Stefano (the upstream author) has also prepared > > > backports to 2.6.32 for RHEL6 and I would like to know if there would be > > > interest in (or rather objections to) my adding these to the squeeze > > > kernel? > > > > This looks OK in principle. > > > > > The majority of the patch is a new driver for a virtual PCI device which > > > provides the glue to allow the existing PV drivers to work in an HVM > > > context. > > > > One nit is that you are adding to <linux/pci_ids.h> which is deprecated > > now. You should just define the vendor/device IDs in the driver. > > I didn't know that, it looks like the file is still being updated fairly > regularly. I guess it should have come up in review of the upstream > version? [...] It looks like this is not handled consistently by the various subsystem maintainers. I'm speaking based on my experience with network drivers. Ben. -- Ben Hutchings Once a job is fouled up, anything done to improve it makes it worse.
Attachment:
signature.asc
Description: This is a digitally signed message part