[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: s3c24xx kernel flavour

On Tue, Jun 08, 2010 at 11:31:41AM +0200, Thibaut Girka wrote:
> All those patches (except register-glamo.patch) comes from OpenMoko (OM)
> kernel.git, slightly modified to apply to the Debian kernel without
> needing all the changes made by OM. Each patch should refer to the
> correspondign commit(s) from OM git repository.

Do I miss the fact that OpenMoko is listed as maintainer for this part
of the tree?

> Subject: MFD: pcf50633: Fix bitfield logic in interrupt handler
> X-Git-Url: http://git.openmoko.org/?p=kernel.git;a=commitdiff_plain;h=470379585be3e2e116e9412e114698debb02eb9e
> MFD: pcf50633: Fix bitfield logic in interrupt handler
> Those constants are alreay bitfields.

This is a different to the commit done in Linux
(0aeee5d4f6aa9bd28373907727937b7935d0434c). Why was this not fixed via

> @@ -304,6 +304,7 @@ config EZX_PCAP
>  	help
>  	  This enables the PCAP ASIC present on EZX Phones. This is
>  	  needed for MMC, TouchScreen, Sound, USB, etc..
> +source "drivers/mfd/glamo/Kconfig"

Coding style, missing empty line.


Conquest is easy. Control is not.
		-- Kirk, "Mirror, Mirror", stardate unknown

Reply to: