[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[RFR] templates://redhat-cluster/{cman.templates}



Please find, for review, the debconf templates and packages descriptions for the redhat-cluster source package.

This review will last from Monday, January 07, 2008 to Thursday, January 17, 2008.

Please send reviews as unified diffs (diff -u) against the original
files. Comments about your proposed changes will be appreciated.

Your review should be sent as an answer to this mail.

When appropriate, I will send intermediate requests for review, with
"[RFRn]" (n>=2) as a subject tag.

When we will reach a consensus, I send a "Last Chance For
Comments" mail with "[LCFC]" as a subject tag.

Finally, the reviewed templates will be sent to the package maintainer
as a bug report, and a mail will be sent to this list with "[BTS]" as
a subject tag.

Rationale:
--- ../redhat-cluster.old/debian/cman.templates	2007-12-29 08:26:58.922223775 +0100
+++ debian/cman.templates	2008-01-03 07:56:10.855302148 +0100
@@ -1,14 +1,11 @@
 Template: cman/upgrade-warning
 Type: boolean
 Default: false
-_Description: Do you want to abort now?
+_Description: Abort the potentially disruptive upgrade of Red Hat Cluster Suite?


"Abort what" would be the question. So, better explain.

  The new version 2.0 of the Red Hat Cluster Suite is not compatible with 
  the currently installed one. Upgrading these packages without stopping 
- the complete cluster can cause filesystem corruption on shared storage 
+ the complete cluster can cause file system corruption on shared storage 
  devices.

Most packages (including D-I) standardized on "file system".

  .
  For instructions on how to safely upgrade the Red Hat Cluster Suite to
- version 2.0, please refer to the following document:
- .
- http://wiki.debian.org/UpgradeRHCSV1toV2
- .
+ version 2.0, please refer to http://wiki.debian.org/UpgradeRHCSV1toV2.

No need to split this in two paragraphs.


--- ../redhat-cluster.old/debian/control	2007-12-29 08:26:58.922223775 +0100
+++ debian/control	2008-01-03 08:21:03.343791119 +0100
@@ -12,7 +12,7 @@
 Priority: optional
 Architecture: all
 Depends: cman, gfs-tools, gfs2-tools, rgmanager, clvm
-Description: Red Hat cluster suite (meta package)
+Description: Red Hat cluster suite - meta package

Standard "common description - specific description" format


  The only scope for this package is to install the full Red Hat Cluster Suite
  in one shot. It is safe to remove it.

I think that ALL packages are missing a common paragraph describing
*what* Redhat cluster suite is..... Anyone feeling like proposing one?

 
@@ -23,54 +23,62 @@
 Depends: ${shlibs:Depends}, python, openais (>= 0.82-2)
 Conflicts: magma, libmagma1, libmagma-dev, ccs, fence, libiddev-dev, fence-gnbd, gulm, libgulm1, libgulm-dev, magma-plugins
 Replaces: ccs, fence, fence-gnbd
-Description: cluster manager
+Description: Red Hat cluster suite - cluster manager
  CMAN is a symmetric general-purpose cluster manager. It consists of
  a connection manager that handles cluster membership management,
  messaging among the cluster nodes, event notification, quorum and
  state transitions. Another part of CMAN is a service manager that
  handles service groups.
  .
- This package contains only userspace tools for controlling the actual
+ This package provides only userspace tools for controlling the
  cluster manager.

"actual"? Is there any need for that word?
 
 Package: libcman2
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: cluster manager - libraries
- cman provides a general purpose, openais based, cluster manager.
+Description: Red Hat cluster suite - cluster manager libraries
+ CMAN is a symmetric general-purpose cluster manager. It consists of
+ a connection manager that handles cluster membership management,
+ messaging among the cluster nodes, event notification, quorum and
+ state transitions. Another part of CMAN is a service manager that
+ handles service groups.

Common with the former package.

  .
- This package contains the client libraries.
+ This package provides the client libraries.

Standardize on "this package provides"
 
 Package: libcman-dev
 Section: libdevel
 Architecture: any
 Depends: libcman2 (= ${binary:Version})
-Description: cluster manager - development files
- cman provides a general purpose, openais based, cluster manager.
+Description: Red Hat cluster suite - cluster manager development files
+ CMAN is a symmetric general-purpose cluster manager. It consists of
+ a connection manager that handles cluster membership management,
+ messaging among the cluster nodes, event notification, quorum and
+ state transitions. Another part of CMAN is a service manager that
+ handles service groups.
  .
- This package contains the files needed for developing applications.
+ This package provides the files needed for developing applications.

Ditto. Similar changes follow all along
 
@@ -142,6 +150,6 @@
 Architecture: all
 Depends: bzip2
 Description: Red Hat cluster suite - kernel modules source
- This package contains the source necessary for compiling the Red Hat
+ This package provides the source necessary for compiling the Red Hat
  cluster suite out-of-tree kernel modules gfs and gnbd against the 
- linux tree.
+ Linux kernel source tree.

"linux tree" is incorrect, imho. That's the Linux kernel source tree,
I think

-- 


Template: cman/upgrade-warning
Type: boolean
Default: false
_Description: Abort the potentially disruptive upgrade of Red Hat Cluster Suite?
 The new version 2.0 of the Red Hat Cluster Suite is not compatible with 
 the currently installed one. Upgrading these packages without stopping 
 the complete cluster can cause file system corruption on shared storage 
 devices.
 .
 For instructions on how to safely upgrade the Red Hat Cluster Suite to
 version 2.0, please refer to http://wiki.debian.org/UpgradeRHCSV1toV2.
--- redhat-cluster.old/debian/cman.templates	2007-12-29 08:26:58.922223775 +0100
+++ redhat-cluster/debian/cman.templates	2008-01-03 07:56:10.855302148 +0100
@@ -1,14 +1,11 @@
 Template: cman/upgrade-warning
 Type: boolean
 Default: false
-_Description: Do you want to abort now?
+_Description: Abort the potentially disruptive upgrade of Red Hat Cluster Suite?
  The new version 2.0 of the Red Hat Cluster Suite is not compatible with 
  the currently installed one. Upgrading these packages without stopping 
- the complete cluster can cause filesystem corruption on shared storage 
+ the complete cluster can cause file system corruption on shared storage 
  devices.
  .
  For instructions on how to safely upgrade the Red Hat Cluster Suite to
- version 2.0, please refer to the following document:
- .
- http://wiki.debian.org/UpgradeRHCSV1toV2
- .
+ version 2.0, please refer to http://wiki.debian.org/UpgradeRHCSV1toV2.
--- redhat-cluster.old/debian/control	2007-12-29 08:26:58.922223775 +0100
+++ redhat-cluster/debian/control	2008-01-07 07:28:01.759879277 +0100
@@ -12,7 +12,7 @@
 Priority: optional
 Architecture: all
 Depends: cman, gfs-tools, gfs2-tools, rgmanager, clvm
-Description: Red Hat cluster suite (meta package)
+Description: Red Hat cluster suite - meta package
  The only scope for this package is to install the full Red Hat Cluster Suite
  in one shot. It is safe to remove it.
 
@@ -23,54 +23,62 @@
 Depends: ${shlibs:Depends}, python, openais (>= 0.82-2)
 Conflicts: magma, libmagma1, libmagma-dev, ccs, fence, libiddev-dev, fence-gnbd, gulm, libgulm1, libgulm-dev, magma-plugins
 Replaces: ccs, fence, fence-gnbd
-Description: cluster manager
+Description: Red Hat cluster suite - cluster manager
  CMAN is a symmetric general-purpose cluster manager. It consists of
  a connection manager that handles cluster membership management,
  messaging among the cluster nodes, event notification, quorum and
  state transitions. Another part of CMAN is a service manager that
  handles service groups.
  .
- This package contains only userspace tools for controlling the actual
+ This package provides only userspace tools for controlling the
  cluster manager.
 
 Package: libcman2
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: cluster manager - libraries
- cman provides a general purpose, openais based, cluster manager.
+Description: Red Hat cluster suite - cluster manager libraries
+ CMAN is a symmetric general-purpose cluster manager. It consists of
+ a connection manager that handles cluster membership management,
+ messaging among the cluster nodes, event notification, quorum and
+ state transitions. Another part of CMAN is a service manager that
+ handles service groups.
  .
- This package contains the client libraries.
+ This package provides the client libraries.
 
 Package: libcman-dev
 Section: libdevel
 Architecture: any
 Depends: libcman2 (= ${binary:Version})
-Description: cluster manager - development files
- cman provides a general purpose, openais based, cluster manager.
+Description: Red Hat cluster suite - cluster manager development files
+ CMAN is a symmetric general-purpose cluster manager. It consists of
+ a connection manager that handles cluster membership management,
+ messaging among the cluster nodes, event notification, quorum and
+ state transitions. Another part of CMAN is a service manager that
+ handles service groups.
  .
- This package contains the files needed for developing applications.
+ This package provides the files needed for developing applications.
 
 Package: libdlm2
 Section: libs
 Architecture: any
 Depends: ${shlibs:Depends}
-Description: distributed lock manager - library
+Description: Red Hat cluster suite - distributed lock manager library
  DLM is a symmetric general-purpose distributed lock manager. It is
  used for example by GFS and the distributed volume manager.
  .
- This is the client library for applications using the lock manager.
- The lock manager itself is a kernel module.
+ This package provides a client library for applications using the
+ lock manager. The lock manager itself is a kernel module.
 
 Package: libdlm-dev
 Section: libdevel
 Architecture: any
 Depends: libdlm2 (= ${binary:Version})
-Description: distributed lock manager - development files
+Description: Red Hat cluster suite - distributed lock manager development files
  DLM is a symmetric general-purpose distributed lock manager. It is
  used for example by GFS and the distributed volume manager.
  .
- This package contains the files needed for developing applications
+ This package provides the files needed for developing applications
  that use the lock manager.
 
 Package: gfs-tools
@@ -78,13 +86,13 @@
 Depends: ${shlibs:Depends}, psmisc, gfs2-tools
 Recommends: redhat-cluster-modules
 Section: admin
-Description: global file system tools 
+Description: Red Hat cluster suite - global file system tools 
  The Global File System allows a cluster of machines to concurrently access
  shared storage hardware like SANs or iSCSI and network block devices. GFS
  can be deployed to build high available services without the single point
  of failure a file server would be.
  .
- This package contains userspace tools for creating and managing global
+ This package provides userspace tools for creating and managing global
  file systems. GFS itself is a set of kernel modules.
  .
  Note: the package requires gfs2-tools installed and it's known to work fine
@@ -95,13 +103,13 @@
 Architecture: any
 Depends: ${shlibs:Depends}, psmisc
 Section: admin
-Description: global file system 2 tools (EXPERIMENTAL)
+Description: Red Hat cluster suite - global file system 2 tools
  The Global File System 2 allows a cluster of machines to concurrently access
  shared storage hardware like SANs or iSCSI and network block devices. GFS
  can be deployed to build high available services without the single point
  of failure a file server would be.
  .
- This package contains userspace tools for creating and managing global
+ This package provides userspace tools for creating and managing global
  file systems. GFS2 itself is a set of kernel modules.
  .
  GFS2 *MUST NOT* be used in production enviroment yet.
@@ -111,30 +119,30 @@
 Architecture: any
 Depends: ${shlibs:Depends}
 Recommends: fence-gnbd (= ${binary:Version}), redhat-cluster-modules
-Description: global network block device - client tools
+Description: Red Hat cluster suite - global network block device client tools
  GNBD allows to use block devices over the network. It is a modified
  version of the linux network block device for the use within a cluster
  environment.
  .
- This package contains userspace tools for running GNBD clients.
+ This package provides userspace tools for running GNBD clients.
 
 Package: gnbd-server
 Section: admin
 Architecture: any
 Depends: ${shlibs:Depends}
 Recommends: fence-gnbd (= ${binary:Version})
-Description: global network block device - server tools
+Description: Red Hat cluster suite - global network block device server tools
  GNBD allows to use block devices over the network. It is a modified
  version of the linux network block device for the use within a cluster
  environment.
  .
- This package contains userspace tools for running GNBD servers.
+ This package provides userspace tools for running GNBD servers.
 
 Package: rgmanager
 Architecture: any
 Depends: ${shlibs:Depends}, cman (= ${binary:Version}), iproute, iputils-arping, iputils-ping, nfs-kernel-server, nfs-common
 Conflicts: nfs-user-server
-Description: clustered resource group manager
+Description: Red Hat cluster suite - clustered resource group manager
  Resource Group Manager provides high availability of critical server
  applications in the event of planned or unplanned system downtime.
 
@@ -142,6 +150,6 @@
 Architecture: all
 Depends: bzip2
 Description: Red Hat cluster suite - kernel modules source
- This package contains the source necessary for compiling the Red Hat
+ This package provides the source necessary for compiling the Red Hat
  cluster suite out-of-tree kernel modules gfs and gnbd against the 
- linux tree.
+ Linux kernel source tree.
Source: redhat-cluster
Section: admin
Priority: optional
Maintainer: Debian Kernel Team <debian-kernel@lists.debian.org>
Uploaders: Bastian Blank <waldi@debian.org>, Frederik Schüler <fs@debian.org>
Standards-Version: 3.7.3.0
Build-Depends: dpatch, debhelper (>= 4.2.28), libxml2-dev, libncurses5-dev, libopenais-dev (>= 0.82-2), libvolume-id-dev (>=  0.105-4), linux-libc-dev (>= 2.6.22-6), libvirt-dev (>= 0.3.0) [amd64 i386], libnss3-dev [amd64 i386], libnspr4-dev [amd64 i386], bzip2, libslang2-dev
Build-Conflicts: libccs-dev, libcman-dev (<= 2.0), libdlm-dev (<= 2.0), libcman2, libdlm2

Package: redhat-cluster-suite
Section: admin
Priority: optional
Architecture: all
Depends: cman, gfs-tools, gfs2-tools, rgmanager, clvm
Description: Red Hat cluster suite - meta package
 The only scope for this package is to install the full Red Hat Cluster Suite
 in one shot. It is safe to remove it.

Package: cman
Architecture: any
Section: admin
Pre-Depends: debconf | debconf-2.0
Depends: ${shlibs:Depends}, python, openais (>= 0.82-2)
Conflicts: magma, libmagma1, libmagma-dev, ccs, fence, libiddev-dev, fence-gnbd, gulm, libgulm1, libgulm-dev, magma-plugins
Replaces: ccs, fence, fence-gnbd
Description: Red Hat cluster suite - cluster manager
 CMAN is a symmetric general-purpose cluster manager. It consists of
 a connection manager that handles cluster membership management,
 messaging among the cluster nodes, event notification, quorum and
 state transitions. Another part of CMAN is a service manager that
 handles service groups.
 .
 This package provides only userspace tools for controlling the
 cluster manager.

Package: libcman2
Section: libs
Architecture: any
Depends: ${shlibs:Depends}
Description: Red Hat cluster suite - cluster manager libraries
 CMAN is a symmetric general-purpose cluster manager. It consists of
 a connection manager that handles cluster membership management,
 messaging among the cluster nodes, event notification, quorum and
 state transitions. Another part of CMAN is a service manager that
 handles service groups.
 .
 This package provides the client libraries.

Package: libcman-dev
Section: libdevel
Architecture: any
Depends: libcman2 (= ${binary:Version})
Description: Red Hat cluster suite - cluster manager development files
 CMAN is a symmetric general-purpose cluster manager. It consists of
 a connection manager that handles cluster membership management,
 messaging among the cluster nodes, event notification, quorum and
 state transitions. Another part of CMAN is a service manager that
 handles service groups.
 .
 This package provides the files needed for developing applications.

Package: libdlm2
Section: libs
Architecture: any
Depends: ${shlibs:Depends}
Description: Red Hat cluster suite - distributed lock manager library
 DLM is a symmetric general-purpose distributed lock manager. It is
 used for example by GFS and the distributed volume manager.
 .
 This package provides a client library for applications using the
 lock manager. The lock manager itself is a kernel module.

Package: libdlm-dev
Section: libdevel
Architecture: any
Depends: libdlm2 (= ${binary:Version})
Description: Red Hat cluster suite - distributed lock manager development files
 DLM is a symmetric general-purpose distributed lock manager. It is
 used for example by GFS and the distributed volume manager.
 .
 This package provides the files needed for developing applications
 that use the lock manager.

Package: gfs-tools
Architecture: any
Depends: ${shlibs:Depends}, psmisc, gfs2-tools
Recommends: redhat-cluster-modules
Section: admin
Description: Red Hat cluster suite - global file system tools 
 The Global File System allows a cluster of machines to concurrently access
 shared storage hardware like SANs or iSCSI and network block devices. GFS
 can be deployed to build high available services without the single point
 of failure a file server would be.
 .
 This package provides userspace tools for creating and managing global
 file systems. GFS itself is a set of kernel modules.
 .
 Note: the package requires gfs2-tools installed and it's known to work fine
 even if GFS2 is highly experimental and *MUST NOT* be used in production
 enviroment yet.

Package: gfs2-tools
Architecture: any
Depends: ${shlibs:Depends}, psmisc
Section: admin
Description: Red Hat cluster suite - global file system 2 tools
 The Global File System 2 allows a cluster of machines to concurrently access
 shared storage hardware like SANs or iSCSI and network block devices. GFS
 can be deployed to build high available services without the single point
 of failure a file server would be.
 .
 This package provides userspace tools for creating and managing global
 file systems. GFS2 itself is a set of kernel modules.
 .
 GFS2 *MUST NOT* be used in production enviroment yet.

Package: gnbd-client
Section: admin
Architecture: any
Depends: ${shlibs:Depends}
Recommends: fence-gnbd (= ${binary:Version}), redhat-cluster-modules
Description: Red Hat cluster suite - global network block device client tools
 GNBD allows to use block devices over the network. It is a modified
 version of the linux network block device for the use within a cluster
 environment.
 .
 This package provides userspace tools for running GNBD clients.

Package: gnbd-server
Section: admin
Architecture: any
Depends: ${shlibs:Depends}
Recommends: fence-gnbd (= ${binary:Version})
Description: Red Hat cluster suite - global network block device server tools
 GNBD allows to use block devices over the network. It is a modified
 version of the linux network block device for the use within a cluster
 environment.
 .
 This package provides userspace tools for running GNBD servers.

Package: rgmanager
Architecture: any
Depends: ${shlibs:Depends}, cman (= ${binary:Version}), iproute, iputils-arping, iputils-ping, nfs-kernel-server, nfs-common
Conflicts: nfs-user-server
Description: Red Hat cluster suite - clustered resource group manager
 Resource Group Manager provides high availability of critical server
 applications in the event of planned or unplanned system downtime.

Package: redhat-cluster-source
Architecture: all
Depends: bzip2
Description: Red Hat cluster suite - kernel modules source
 This package provides the source necessary for compiling the Red Hat
 cluster suite out-of-tree kernel modules gfs and gnbd against the 
 Linux kernel source tree.

Attachment: signature.asc
Description: Digital signature


Reply to: