Bug#447611: update-initramfs triggerisation
On Tue, Oct 23, 2007 at 01:45:46AM -0700, Steve Langasek wrote:
> On Mon, Oct 22, 2007 at 06:12:44PM +0200, maximilian attems wrote:
> > i'm following dpkg git, once this cool feature is merged,
> > i'm happy to apply a patch using it. i didn't see it merged in
> > the master tree yet. as i didn't follow the dpkg discsussions
> > i don't know current status.
>
> Why should that be a prerequisite for merging these changes for
> initramfs-tools? Reducing the diff between the Debian and Ubuntu packages
> of initramfs-tools will make it easier to pass bugfixes between the two
> distros for this package, and I don't see any reason to think this code will
> make initramfs-tools less maintainable, so it seems like a good idea to me
> to merge this change even if it's not yet useful in Debian.
it is a prerequisite, until not merged i have zero evidence that
the interface may not have changed.
afais on dpkg devel joeyh raised good critics on how
the trigger support is done.
i agree that i like to keep the diff small and current shape
of initramfs-tools would be cool for a merge in the next weeks.
> > > + dpkg --compare-versions "$DPKG_RUNNING_VERSION" ge '1.14.5ubuntu10~~'
> > > +then
> > ubuntu specific, would with high probab trigger on the wrong versions,
> > also why is this needed?
>
> but the previous bit of code says that this only fires when the maintainer
> script is called with "trigger" as the first argument. As there aren't any
> older versions of dpkg in Debian that will ever call the maintainer scripts
> this way, that seems reasonable to me?
ok
> Hmm, installing files into the DEBIAN/ directory using dh_install -- eew?
> :-)
>
> Anyway, Joey's solution is better.
yup, what's the invocation?
> $ type test
> test is a shell builtin
> $
>
> ?
thanks for the lection, forgot that differs from current codingstyle,
so i prefer the way i said and i don't like the getopt parsing ;)
> I'm glad to hear it, I'd very much like to see Debian able to take advantage
> of these speed-ups soon. :)
full ack
--
maks
Reply to: