Bug#447611: update-initramfs triggerisation
On Mon, Oct 22, 2007 at 06:12:44PM +0200, maximilian attems wrote:
> i'm following dpkg git, once this cool feature is merged,
> i'm happy to apply a patch using it. i didn't see it merged in
> the master tree yet. as i didn't follow the dpkg discsussions
> i don't know current status.
Why should that be a prerequisite for merging these changes for
initramfs-tools? Reducing the diff between the Debian and Ubuntu packages
of initramfs-tools will make it easier to pass bugfixes between the two
distros for this package, and I don't see any reason to think this code will
make initramfs-tools less maintainable, so it seems like a good idea to me
to merge this change even if it's not yet useful in Debian.
> > + dpkg --compare-versions "$DPKG_RUNNING_VERSION" ge '1.14.5ubuntu10~~'
> > +then
> ubuntu specific, would with high probab trigger on the wrong versions,
> also why is this needed?
but the previous bit of code says that this only fires when the maintainer
script is called with "trigger" as the first argument. As there aren't any
older versions of dpkg in Debian that will ever call the maintainer scripts
this way, that seems reasonable to me?
> has there been a buggy dpkg trigger support!?
Should that matter, given that any versions of dpkg with that bug are, as
you say, Ubuntu-specific? :)
> > diff -ruN ../orig/initramfs-tools-0.85eubuntu16/debian/rules initramfs-tools-0.85eubuntu18/debian/rules
> > --- ../orig/initramfs-tools-0.85eubuntu16/debian/rules 2006-12-21 23:32:07.000000000 +0000
> > +++ initramfs-tools-0.85eubuntu18/debian/rules 2007-08-16 16:10:49.000000000 +0100
> > @@ -8,3 +8,7 @@
> > for x in `find scripts/ -maxdepth 1 -type d | tail -n+2`; do \
> > chmod -R +x $$x; \
> > done
> > +
> > +binary-install/initramfs-tools::
> > + install -m 644 -o 0 -g 0 debian/initramfs-tools.triggers \
> > + debian/initramfs-tools/DEBIAN/triggers
> no i-t uses cdbs,
> please add to debian/initramfs-tools.install
Hmm, installing files into the DEBIAN/ directory using dh_install -- eew?
:-)
Anyway, Joey's solution is better.
> but maybe i misread and there is no cdbs support for that yet??
> > diff -ruN ../orig/initramfs-tools-0.85eubuntu16/update-initramfs initramfs-tools-0.85eubuntu18/update-initramfs
> > --- ../orig/initramfs-tools-0.85eubuntu16/update-initramfs 2007-04-10 16:07:41.000000000 +0100
> > +++ initramfs-tools-0.85eubuntu18/update-initramfs 2007-08-16 16:56:23.000000000 +0100
> > @@ -4,11 +4,24 @@
> > BOOTDIR=/boot
> > CONF=/etc/initramfs-tools/update-initramfs.conf
> > KPKGCONF=/etc/kernel-img.conf
> > +USETRIGGERS=true
> >
> > set -e
> >
> > [ -r ${CONF} ] && . ${CONF}
> >
> > +if $USETRIGGERS \
> > + && test x"$DPKG_MAINTSCRIPT_PACKAGE" != x \
> > + && test $# = 1 \
> > + && test x"$1" = x-u \
> > + && dpkg-trigger --check-supported 2>/dev/null
> why not using built-ins?
$ type test
test is a shell builtin
$
?
> don't get me wrong, i highly like the idea of that work
> and i'm happy to use it soon.
I'm glad to hear it, I'd very much like to see Debian able to take advantage
of these speed-ups soon. :)
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
vorlon@debian.org http://www.debian.org/
Reply to: