[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#374891: marked as done (initramfs-tools: activate resume volume group)



Your message dated Sat, 24 Jun 2006 16:02:16 -0700
with message-id <E1FuH8q-0005wf-AS@spohr.debian.org>
and subject line Bug#374891: fixed in initramfs-tools 0.65
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--- Begin Message ---
Package: initramfs-tools
Version: 0.60
Tags: patch

Currently the lvm script does not activate the volume group which the resume partition resides on. In case the resume lv is in the same vg as the root lv, then things will work anyway since the root vg is activated but if they are in different vg's this means that resume will not work.

I've attached a patch which fixes this by activating both resume and root vg's.

Regards,
David Härdeman

diff -ur initramfs-tools-0.60-orig/scripts/local-top/lvm initramfs-tools-0.60/scripts/local-top/lvm
--- initramfs-tools-0.60-orig/scripts/local-top/lvm	2006-03-26 21:56:35.000000000 +0200
+++ initramfs-tools-0.60/scripts/local-top/lvm	2006-06-21 23:43:19.000000000 +0200
@@ -15,23 +15,34 @@
 	;;
 esac
 
-vg=${ROOT#/dev/mapper/}
+activate_vg()
+{
+	local vg="$1"
 
-case ${vg} in
-	/dev/root)
-		unset vg
-		;;
-	/*)
-		exit 0
-		;;
-esac
-	
-modprobe -q dm-mod
+	# Make sure that we have a non-empty argument
+	if [ -z "$vg" ]; then
+		return 0
+	fi
+
+	# Make sure that we have a d-m path
+	vg=${vg#/dev/mapper/}
+	if [ "$vg" = "$1" ]; then
+		return 0
+	fi
 
-# Split volume group from logical volume.
-vg=$(echo ${vg} | sed -e 's#\(.*\)\([^-]\)-[^-].*#\1\2#')
-# Reduce padded --'s to -'s
-vg=$(echo ${vg} | sed -e 's#--#-#g')
+	# Split volume group from logical volume.
+	vg=$(echo ${vg} | sed -e 's#\(.*\)\([^-]\)-[^-].*#\1\2#')
+	# Reduce padded --'s to -'s
+	vg=$(echo ${vg} | sed -e 's#--#-#g')
 
-vgchange -ay ${vg}
+	vgchange -ay ${vg}
+}
+
+if [ ! -e /sbin/vgchange ]; then
+	exit 0
+fi
+
+modprobe -q dm-mod
 
+activate_vg "$ROOT"
+activate_vg "$resume"

--- End Message ---
--- Begin Message ---
Source: initramfs-tools
Source-Version: 0.65

We believe that the bug you reported is fixed in the latest version of
initramfs-tools, which is due to be installed in the Debian FTP archive:

initramfs-tools_0.65.dsc
  to pool/main/i/initramfs-tools/initramfs-tools_0.65.dsc
initramfs-tools_0.65.tar.gz
  to pool/main/i/initramfs-tools/initramfs-tools_0.65.tar.gz
initramfs-tools_0.65_all.deb
  to pool/main/i/initramfs-tools/initramfs-tools_0.65_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 374891@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
maximilian attems <maks@sternwelten.at> (supplier of updated initramfs-tools package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Sat, 24 Jun 2006 13:27:49 +0200
Source: initramfs-tools
Binary: initramfs-tools
Architecture: source all
Version: 0.65
Distribution: unstable
Urgency: low
Maintainer: Debian kernel team <debian-kernel@lists.debian.org>
Changed-By: maximilian attems <maks@sternwelten.at>
Description: 
 initramfs-tools - tools for generating an initramfs
Closes: 364301 369617 374378 374891
Changes: 
 initramfs-tools (0.65) unstable; urgency=low
 .
   * scripts/local-top/lvm: Activate root and resume volume group.
     The initialization got refractored in an function. (closes: #374891)
     Thanks for the patch to David Härdeman <david@2gen.com>.
 .
   * scripts/local-top/lvm: Be careful to activate volume group on lilo boot
     too. Although in that case we don't know the precise volume group, we
     activate them all. Matches behaviour of previous hook.
 .
   * hooks/lvm: Add dm-mirror, allows to boot from an unfinished pvmove.
     (closes: #374378)
 .
   * mkinitramfs: Remove old kernel-package supported long param.
     kernel-package uses since 10.036 mkinitramfs-kpkg.
 .
   * update-initramfs: Show by default which initramfs gets generated.
     (closes: #364301)
 .
   * Resync with 0.40ubuntu32:
    -  Make prereqs conditional on the script/hook actually existing.  From
       now on, this means that 'PREREQ="udev"' means "run udev first, iff it
       happens to be installed".  Having the files exist on the filesystem if
       you have a HARD dependency should be enforced with package dependencies.
       (closes: #369617)
    -  Make "update-initramfs -u" try to find the running kernel *after* it
       attempts to search the symbolic link list and its own sha1 list.
       Using this as a fallback, rather than the default, should solve most
       upgrade issues, where people found their initramfs was half-baked.
    -  Abstract out the kernel minversion checking stuff into the function
       library, so we can reuse it to check minversion requirements for hook
       scripts as well (such as udev, which requires >= 2.6.15 in dapper)
    -  Bump the kernel minversion to 2.6.15 on hppa and ia64, since they used
       initrd-tools with their 2.6.12 kernels in breezy, not initramfs-tools.
    -  If mkinitramfs fails due to minversion not being met, don't bail out
       of update-initramfs, but just exit 0, so upgrades don't halt on it.
 .
   * debian/initramfs-tools.postrm: We no longer need to explicitly remove
     /etc/initramfs-tools/modules.
Files: 
 f67df0c06aa9b1170596402aaf759701 623 utils optional initramfs-tools_0.65.dsc
 5c1b5fb9a5a8c56a219816dd0b7ab81a 39624 utils optional initramfs-tools_0.65.tar.gz
 ec854fe94ffa830168a30ec515a70a01 45772 utils optional initramfs-tools_0.65_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)

iD8DBQFEncIsXKRQ3lK3SH4RAtkmAKDCzOsVLc2kHthy1dXQNzo6Uw/fkwCg5TZ9
LzCcNooukgktuX4YiW0j+cE=
=llR9
-----END PGP SIGNATURE-----


--- End Message ---

Reply to: