[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#396388: should allow hooks to abort build



Package: initramfs-tools
Version: 0.84
Severity: normal

mkinitramfs is not a set -x script, and so when call_scripts runs a hook
script, any error is ignored.

In some cases, a hook script needs to abort the initramfs build. For
example, then nslu2-tools hook script can detect issues, like a missing
ixp ethernet driver, that will make the box unusable, and needs to be
able to abort the initramfs build in these situations.

Currently the only way for a hook script to abort the build is a nasty
hack. Since call_scripts sources /conf/param.conf, a hook script could
create that file, and make it exit 1. Of course, that's beyond gross,
and I won't do it. :-)

Please provide a mechanism for hook scripts to abort a build. Note that
in the past, if a hook script exited nonzero, the build did abort, so my
guess is that there are few hook scripts that exit nonzero in cases
where the build would continue. However, if you don't feel that's safe
now, an alternative would be to check for a flag file in the initramfs
tree, which a hook script could create to indicate that the build needs
to be aborted.

-- 
see shy jo

Attachment: signature.asc
Description: Digital signature


Reply to: