Bug#335230: More stub code
On Wed, Oct 26, 2005 at 09:49:13AM +0200, Mattia Dongili wrote:
> On Tue, October 25, 2005 10:13 pm, Erik van Konijnenburg said:
> > On Tue, Oct 25, 2005 at 08:09:06PM +0200, Mattia Dongili wrote:
> > The init() function looks OK. Detail: you're doing a fork/exec of
> > "evms_query info ..." just to find a major/minor number. Using
> > Base::devno() is cheaper: just a stat() system call.
>
> Yes, that was my first implementation actually. But the Device Number in
> evms_query info doesn't match the real device maj/min and I really don't
> know which one might be useful when filtering with findByDevNo eg:
Possibly evms devices modified in the ui but not yet activated ...
Plugins: you're working on those. In the mean time, I got EVMS installed
on a test box here, albeit in a silly configuration. Playing a bit
suggests that it may be that the properties uncovered now are already
enough to support raid; should become apparent in testing.
> > Here's a twist: what if there are two devices on evms that yaird accesses?
> > So far we've been able to do a depth-first walk over devices needed,
> > but if evms_activate does not take an argument indicating which device
> > we're trying to activate, we'll need to find an alternative approach.
>
> evms_activate will try to discover them all. I still don't get why this is
> an issue but this is due to limited computing power in my brain :)
There's some tricky issues there, but that requires more coffee to write down
properly than is advisable at this time of day :-)
Anyway, I plan to hook the code you mailed into a test version of yaird
this weekend.
Thanks,
Erik
Reply to: