[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#335230: More stub code



On Tue, Oct 25, 2005 at 08:09:06PM +0200, Mattia Dongili wrote:
> I've been able to setup an almost-working evms box (at least evms_query
> reports useful data).
> 
> I tried following Erik's suggestions and also implemented part of the
> init() method and reworked some of Marco's code.
> Some parts are still to be finished, but I'd like some feedback
> expecially on evms_query commands and the expected content of some
> EvmsDev properties.

The init() function looks OK.  Detail: you're doing a fork/exec of
"evms_query info ..." just to find a major/minor number.  Using
Base::devno() is cheaper: just a stat() system call.

The properties look OK to find devices, but don't yet provide enough
information to decide whether to load raid0/raid5.  The crude fix is
to just load them always ...   Marco, opinions?

Here's a twist: what if there are two devices on evms that yaird accesses?
So far we've been able to do a depth-first walk over devices needed,
but if evms_activate does not take an argument indicating which device
we're trying to activate, we'll need to find an alternative approach.

Regards,
Erik



Reply to: