[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#324583: linux-patch-debian-2.6.12: missing default version numbers in unpatch/apply script break make-kpkg



Package: linux-patch-debian-2.6.12
Version: 2.6.12-5
Severity: important


Somehow the @upstream@ and @version@ macros didn't get expanded in
debian/bin/unpatch and debian/bin/apply which causes

  PATCH_THE_KERNEL=YES make-kpkg cleab

to fail with the following message:

/usr/bin/make -f /usr/share/kernel-package/rules unpatch_now
make[2]: Entering directory `/usr/src/linux-source-2.6.12'
for patch in /usr/src/kernel-patches/all/2.6.12/unpatch/debian ; do              \
          if test -x  $patch; then                        \
              if $patch; then                             \
                  echo "Removed Patch $patch ";           \
              else                                         \
                   echo "Patch $patch  failed.";          \
                   echo "Hit return to Continue";          \
           read ans;                               \
              fi;                                          \
  fi;                                              \
        done
/usr/src/kernel-patches/all/2.6.12/unpatch/debian: line 8: /usr/src/kernel-patches/all//apply/debian: No such file or directory
Patch /usr/src/kernel-patches/all/2.6.12/unpatch/debian  failed.
Hit return to Continue

(Note the missing version between /all/ and /apply/ in the error message.)

Building a kernel 

  PATCH_THE_KERNEL=YES make-kpkg kernel-image

fails with with

for patch in /usr/src/kernel-patches/all/2.6.12/apply/debian ; do            \
          if test -x  $patch; then                    \
              if $patch; then                         \
                  echo "Patch $patch processed fine"; \
          echo "$patch" >> applied_patches;   \
              else                                     \
                   echo "Patch $patch  failed.";      \
                   echo "Hit return to Continue";      \
           read ans;                           \
              fi;                                      \
  fi;                                          \
        done
E: Can't patch to nonexistent revision  (wait until 2006)
Patch /usr/src/kernel-patches/all/2.6.12/apply/debian  failed.
Hit return to Continue

Changing line 158 in /usr/src/kernel-patches/all/2.6.12/apply/debian from

  version=${override_version:-}

to

  version=${override_version:-2.6.12-5}

and line 6 in /usr/src/kernel-patches/all/2.6.12/unpatch/debian

  upstream=${override_upstream:-}

to

  upstream=${override_upstream:-2.6.12}

fixes the problem.

Of course the real problem lies somewhere in the build process for this
patch, since @upstream@ and @version@ where expanded to empty strings
instead of the correct values.


-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.12-251
Locale: LANG=de_DE@euro, LC_CTYPE=de_DE@euro (charmap=ISO-8859-15)

Versions of packages linux-patch-debian-2.6.12 depends on:
ii  bash                          3.0-15     The GNU Bourne Again SHell
ii  bzip2                         1.0.2-8    high-quality block-sorting file co
ii  grep-dctrl                    2.6.7      Grep Debian package information
ii  patch                         2.5.9-2    Apply a diff file to an original

linux-patch-debian-2.6.12 recommends no packages.

-- no debconf information



Reply to: