Bug#296642: kernel-source-2.4.27: [drm] filp in LOCK_TEST_WITH_RETURN
Package: kernel-source-2.4.27
Version: 2.4.27-8
Severity: normal
The fix for CAN-2004-1056 (Fix insufficient locking checks in DRM code)
(see #285563) introduced the filp parameter in the
LOCK_TEST_WITH_RETURN macro in drmP.h and various i810 and i830 source
files in /drivers/char/drm. As is noted by the maintainer in the mail
that accompanies the patch, this syntax comes from the 2.6 series and
a different workaround to the locking problem is adopted in the patch
for 2.4.27. However, the macro definition from 2.6 seems to have been
inadvertently introduced at the same time. I have no idea what effect
this has - DRM macros are hard to follow - but anyway, it gives me some
compiler warnings about redefined macros because the non-i81x drivers
are still using the LOCK_TEST_WITH_RETURN( dev ) syntax. Sorry if these
are just harmless compiler warnings but I thought I should let you know.
-- System Information:
Debian Release: 3.1
Architecture: i386 (i686)
Kernel: Linux 2.4.27.20050219.0
Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968)
Versions of packages kernel-source-2.4.27 depends on:
ii binutils 2.15-5 The GNU assembler, linker and bina
ii bzip2 1.0.2-1 A high-quality block-sorting file
ii coreutils [fileutils] 5.2.1-2 The GNU core utilities
-- no debconf information
Reply to: