Bug#278068: chmod messes up permissions on hfs filesystem

[Horms <horms@verge.net.au>]

On Thu, Nov 04, 2004 at 12:31:31PM +0900, Horms wrote:
> On Wed, Nov 03, 2004 at 05:00:35PM +0100, Roman Zippel wrote:
> > Hi,
> > 
> > On Tue, 2 Nov 2004, Horms wrote:
> > 
> > > Thanks for the patch, though the behaviour of the umask still seems
> > > rather odd. I would like to offer an updated patch which I believe
> > > makes the umask behave in the expected way. It also ensures
> > > that the write_lock bit is read from/written to disk correctly.
> > 
> > You apply the umask before updating the write bit, which is incorrect.
> 
> I tried to account for that, but perhaps I missed.

Hi,

I think that I am a little confused here.
By applying the umask after any write bits set from
disk or by the user they are overridden.
I thought the intention of the umask was to provide
a default, not to override user-derived values.

In the case of msdos, which I believe is where this came from
there are no user or disk inputs as the file system does
not have any permissions as such. So the umask can just be
unilaterally applied.

But in the case of hfs, where there is one permission bit,
I think it would make sense for user requests, which are subsequently
written to disk, to override the umask. Does that make sense?

-- 
Horms