Re: RFS : libcharts4j-java

[Pierre Gruet <pgtdebian@free.fr>]

Hi Emmanuel,

Le 25/07/2020 à 23:36, Emmanuel Bourg a écrit :
> On 25/07/2020 08:39, Emmanuel Bourg wrote:
> 
>>> Could someone please review and sponsor it when time permits?
>>
>> Hi Pierre, I'll take care of it.
> 
> The package has been uploaded and is now in the NEW queue.
>

Thanks a lot for taking time to review and give advice!

> 
> Technically the package was good, I just made a few minor changes:
> - I've removed the -doc package, it's rarely used and javadoc is a
> recurrent source of troubles on JDK upgrades.
>

OK, so you are giving the general advice to never package javadoc?

> - I've removed the +dfsg suffix, I have a personal preference for
> "clean" version numbers, and the removal of the junit jar from the
> upstream source isn't significant enough to justify using this prefix in
> my opinion.
>

Understood, I will keep in mind that such changes do not necessarily
deserve a suffix to the version number.

> - I've renamed the source package from libcharts4j to charts4j
> - The dependency on javahelper wasn't necessary
> - The dependency on the maven-compiler-plugin is implicit when using
> maven-debian-helper
>

Acknowledged!

> 
> Emmanuel Bourg
> 

Thanks again for your help,
Pierre Gruet