Re: Review of fairsim, libjtransforms-java and libjlargearray-java

[Carnë Draug <carandraug+dev@gmail.com>]

On 2 October 2017 at 00:21, Markus Koschany <apo@debian.org> wrote:
> Hi,
>
> I think all three packages are in a good shape but there are some issues.
>
> Standards-Version is 4.1.1 now.
>
> I suggest to remove the -doc packages because I don't believe those
> libraries are significant enough to warrant the maintenance of
> additional documentation packages but I leave the decision to you. That
> would also simplify the packaging a little.

I actually like and use the docs packages so I'd rather keep them.

> You don't have to add the classpath to the library. The Lintian check
> that warned about this issue has recently been removed.

Without the classpath, then users of the jar files need to figure out
the dependencies themselves which does not work.  As someone that
routinely uses java libraries via Python and Octave, I find it
essential.

> If you do it and
> use jh_classpath or the *.classpath file then you must specify the
> absolute path to the libraries otherwise they won't be found.

Not true.  The path can be relative to the directory of the jar file
that contains the manifest file.

> you rarely need both javahelper and maven-debian-helper in one package.
> I believe maven-debian-helper would suffice here and you can remove the
> build-dependency on javahelper and the related substvars.

I thought that d/package-name.classpath file was used by jh_classpath
and that is provided by javahelper.  Or how can I set the classpath on
the manifest without it?

> I also suggest to remove the --has-package-version flag from the *.poms
> files. There was a recent change in maven-debian-helper that
> automatically adds a versioned dependency to reverse-dependencies if one
> of their build-dependencies uses this flag. In my opinion in most cases
> this is too strict and not what you probably wanted.
>
> Regarding your failing patch I'm not sure. It doesn't sound like it is
> Java specific. You can send me your patch and I can take a look though.
>

Here is the patch [1].  When I build with this patch, quilt will make
a copy of the original org.fairsim.fiji.FairSim_ImageJplugin package
in `.pc/set-git-build-id.patch/org/fairsim/fiji/FairSim_ImageJplugin.java`
This causes a duplicate class error because both the original and copy
are found.

Thank you
Carnë

[1] https://github.com/carandraug/debian-fairsim/commit/ffe1cf94d174a2722a478372685b98900e977a76