Re: RFS: svgsalamander/1.0.0+dfsg1-1
Hi Felix,
I've had a look at your package and some comments follow. In general the
package looks good, but there is room for improvement.
Please consider bumping the debhelper compatibility to 9.
Also change the LGPL-2.0 shortname to LGPL-2+ to better reflects the "or
(at your option) any later version" clause.
The Forwarded header in
0004-Use-system-awt-gradient-instead-of-the-embedded-batik.patch &
0006-modify-broken-upstream-pom.patch can also be improved. For the
former "not-needed" is more appropriate than "no" with note, not-needed
is probably also appropriate for the latter.
The README.source should be updated to reflect the change to GitHub
tarballs.
Consider adding the --parallel option to dh in debian/rules to enable
the use of parallel builds with DEB_BUILD_OPTIONS="parallel=<N>".
The watch file can also be improved to handle common issues [0], like
the attached version for example.
Also consider adding upstream metadata [1].
[0] https://wiki.debian.org/debian/watch#Common_mistakes
[1] https://wiki.debian.org/UpstreamMetadata
Kind Regards,
Bas
--
GPG Key ID: 4096R/6750F10AE88D4AF1
Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
version=3
opts=\
dversionmangle=s/\+(debian|dfsg|ds|deb)\d*$//,\
uversionmangle=s/(\d)[_\.\-\+]?((RC|rc|pre|dev|beta|alpha)\d*)$/$1~$2/;s/RC/rc/,\
filenamemangle=s/(?:.*?)?(?:rel|v|svgSalamander)?[\-\_]?(\d\S+)\.(tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))/svgSalamander-$1.$2/ \
https://github.com/blackears/svgSalamander/releases \
(?:.*?/)?(?:rel|v|svgSalamander)?[\-\_]?(\d\S+)\.(?:tgz|tbz|txz|(?:tar\.(?:gz|bz2|xz)))
Reply to: