[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: lintian: [new check] verify that JAR filename complies with Debian Java Policy



On 07/07/2015 04:15 AM, Emmanuel Bourg wrote:
> Le 06/07/2015 06:36, tony mancill a écrit :
> 
>> This warning is useful because
>> some components of the Debian Java toolchain fail when JAR files don't
>> comply with the naming policy.
> 
> Hi Tony,
> 
> For my understanding, what are the tools relying on this naming policy?
> I'm asking because I'm pretty sure many packages don't strictly adhere
> to the Java policy on this point (for example liblog4j1.2-java vs
> /usr/share/java/log4j-1.2.jar) and I'm not under the impression it's
> causing such a havoc.
> 
> Emmanuel Bourg
> 

Hi Emmanuel,

I proposed the check as a result of this thread [1].  At least mh_make
is failing, and perhaps there are others that will silently fail in this
context.

But please note that the check is only adding a regex check on the names
of JARs.  This will catch things like "capitalsAreNotAllowed.jar" and
"&__you-cant-do-this.jar" and "0.jar." The regex is defined in Util.pm:

> ./lib/Lintian/Util.pm:our $PKGNAME_REGEX = qr/[a-z0-9][-+\.a-z0-9]+/o;

The check doesn't care about the name of the JAR vis-a-vis the name of
the package, and so won't trigger for liblog41.2-java vs log4j-1.2.jar.
 I fully agree that those sorts of differences aren't a problem.

Perhaps the warning text should be improved?

Cheers,
tony

[1] https://lists.debian.org/debian-java/2015/06/msg00009.html


Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: