[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: maven-debian-helper to maven3



Le 21/03/2015 03:11, Andrew Schurman a écrit :

> All ready [1] and works on two packages that I tried. Would you prefer a
> github pull request? I've included 2 commits (the last two) which aren't
> strictly necessary, but fix the bug that I was seeing intermittently in
> tests.

Thank you. I'll pull directly from your repository, not need to send a PR.


> I also believe the tests should be run as part of building the package
> otherwise they will be forgotten, but we'll have to mock out some of the
> process forks to make them reliable on a build machine first. They are
> currently turned off.

Running the tests at build time is a good idea.


> It turns out there are 2 different metadata files that we need when
> referencing a goal instead of a phase: one for plugin prefixes and one
> for versions. I changed the default build to not use the prefix form
> when calling goals until we can get both generated. Any builds that do
> will fail until they change to the non-prefix form (plus an explicit
> version for anything other than javadoc) or wait until my next set of
> changes are ready.

I don't think we can avoid deploying the metadata file with the
prefixes. There are some packages than redefine the DEB_MAVEN_DOC_TARGET
variable and invoke javadoc:aggregate, as I understand they will break
without the metadata. That's why I was suggesting that the
maven-debian-helper package contains and install the prefix metadata for
the most common plugin groups (i.e. org.apache.maven.plugins and
org.codehaus.mojo). We can start with static files for now.


> At first glance, it appears just a few dependency tweaks in the control
> file. It's not necessary for any projects that use maven-debian-helper,
> but I'll take a look.

Maybe it's necessary to build maven-debian-helper with maven-ant-helper?
Do you remember why you had to build maven-debian-helper with itself?


> See commit e18be23 in [1] for how we can get rid of '2.x' versions, but
> would take a lot of work to check and update all ~320 packages. This
> works without any maven-metadata. I'm not sure if this will cause any
> more headaches than there already are if applied on a larger scale.

Another idea would be to rewrite the poms and use the special
LATEST/RELEASE versions instead of 'debian'. Thus the packages would no
longer contain the 'debian' artifacts. However this requires metadata
for every libraries, not just the plugins. I've done some tests with the
version ranges and it seems they need the metadata too.

Emmanuel Bourg


Reply to: