[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Replace POMReader in maven-repo-handler with DOM based reader

Hi Thomas,

Did you consider using the Maven code for parsing the POMs?
maven-repo-handler could simply delegate this task to the Maven Core jar.

Emmanuel Bourg

Le 27/10/2012 18:06, Thomas Koch a écrit :
> Hi,
> the current POMReader class in maven-repo-handler is based on a streaming XML 
> reader API. The read function has over 200 lines with 7+ levels of nesting and 
> 30+ local variables. The reader also intermixes XML parsing and maven POM 
> processing logic.
> I'm thinking about replacing the current POMReader with a DOM based class. 
> This would consume more memory and be slower, but neither should be a problem 
> here. The new class would wrap the DOM object and have getters to extract data 
> structures that interest us: Dependencies, Plugins, ...
> Regards,
> Thomas Koch, http://www.koch.ro

Attachment: smime.p7s
Description: Signature cryptographique S/MIME

Reply to: