Re: [Summery] Re: Integrating the FOSDEM 06 Draft into the Java Policy
Hi,
On Thu, 25 Mar 2010 21:32:50 +0100, Niels Thykier <niels@thykier.net>
wrote:
> Currently there are three patches active:
> * p1_trival_changes.patch
> * p2_fosdem06_r3.patch
> * p3_fosdem06-gcj.patch
I'm OK with all three patches, except one small addition from
"p2_fosdem06_r3.patch" :
Programs and libraries &should; enable JUnit tests, if these are present.
*However, these tests &mustnot; lead to build failures.*
For some library packages (ie. commons-maths), I'm confidence enough to
enable unit tests and trust upstream QA : if some JUnit tests fail there
must be a problem somewhere (Build-Depends, JVM, pbuilder/buildd
context...) and package should not be uploaded/NMUed.
For example, in commons-math I've made a patch to comply with this policy
[1], which made me a little awkward :)
What do you think about rephrase it to something like :
Programs and libraries &should; enable JUnit tests, if these are present.
*However, these tests &should; not lead to build failures unless
Maintainer is confident enough that tests are stable between builds*
[1]
http://svn.debian.org/wsvn/pkg-java/trunk/commons-math/debian/patches/02_no_tests_on_build.diff
Regards,
--
Damien Raude-Morvan - http://damien.raude-morvan.com/
Reply to: