Re: RFS: remotetea - Sun ONC/RPC support for Java
Hi Matthew,
2009/8/8 Matthew Johnson <mjj29@debian.org>:
> - You've given the debian/ copyright as GPL3 but the rest is GPL2+.
> Aside from the fact I don't like the GPL3, this means the resulting
> binary package is GPL3 and can't be used with other GPL2-only packages.
I don't think that is true as long as the debian dir doesn't ship java
code that gets compiled and shipped with the binary packages.
> I generally think it's a bad principle to have a different licence for
> the packaging as for the rest of the software.
I'll agree to that.
Cheers,
Torsten
>
> - Given you are repacking the sources you should indicate this in the
> version. Normally people append .dfsg if it's a free/nonfree issue or
> .debian otherwise.
>
> - debian/rules clean doesn't remove the javadoc or classes directories.
> This means that if you dpkg-buildpackage twice it fails to create the
> source package. You need to call ant clean in the
> override_dh_auto_clean target
>
> - *embarassed* you seem to have triggered a bug in jh_depends where it
> depends on jarwrapper but not a JVM. I've fixed it and just uploaded
> 0.21. Once that's in I can rebuild and upload a version of remote tea
> with any fixes from the above.
>
> Matt
> --
> Matthew Johnson
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkp9cskACgkQ2XtckeYvo1j3CgCfWgt/0xpzP87zv/Yn0Nqpb8Mu
> 0kUAnRVg3B7dgRMhpJ9tLx3Aq9nyDDRV
> =52dR
> -----END PGP SIGNATURE-----
>
>
Reply to: