Re: RFC: libescher
Hi,
Arnaud Vandyck wrote:
> [I replyed from pkg-java-maintainers to debian-java because I prefer
> pkg-java-maintainers's list to be only for bug reports]
I will use debian-java for packaging diffs from now on. :)
>>>The escher source archive (0.2.3) is a bit odd. It contains no separate source
>>>and has all the class files in it. I tried to fix that in the clean rule. Hope
>>>that makes sense.
> That's the way to go.
Another problem is that the root for the source files is the archive's root
itself. In other words: It has no separate source folder. Out of knowledge I
fixed that in the clean rule, too. However that makes the diff pretty big and it
may be more useful to fix that problem in some kind of compilation-preparation
step (It is just mkdir src; mv gnu src;)
>>>+Build-Depends: cdbs, debhelper (>= 4.1.0), java-gcj-compat-dev, ant
>>>+Standards-Version: 3.6.2
>
>
> Build-Depends: cdbs, debhelper (>= 4.1.0)
> Build-Depends-Indep: java-gcj-compat-dev, ant
> Standards-Version: 3.7.2
>
> [...]
Fixed!
>>>+DEB_JARS := \
>>>+ ant-launcher
>
>
> I don't think it's needed anymore.
I am afraid I get NoClassDefFoundErrors without that. However I am building the
package on an Ubuntu system. Hope that isnt to much of a problem...?
>
>>>+# Build compiler
>>>+DEB_ANT_COMPILER := org.eclipse.jdt.core.JDTCompilerAdapter
>>>+ifneq (,$(findstring eclipse,$(DEB_ANT_COMPILER)))
>>>+ DEB_JARS += ecj.jar /usr/share/ant/lib/ecj-adapter.jar
>>>+endif
>
>
> Isn't it the default compiler?
Removed that.
>
>>>Index: libescher-java/debian/README.Debian-source
>>>===================================================================
>>>--- libescher-java/debian/README.Debian-source (Revision 0)
>>>+++ libescher-java/debian/README.Debian-source (Revision 0)
>>>@@ -0,0 +1,9 @@
>>>+libescher-java for Debian
>>>+-------------------------
>>>+
>>>+Upstream author provides no separate source-only archive therefore
>>>+pre-compiled class files and HTML documentation has been removed from the
>>>+downloaded
>>>+archive.
>
>
> Great to comment the way you changed the sources.
Thanks. I extended this info a bit in the current version.
> Excellent work, I'm ok to sponsor your upload if needed, you can contact
> me in private (give me an url with orig.tar.gz and .dsc and diff.gz).
Here are the files:
http://www.inf.fu-berlin.de/~rschuste/pkg-java/libescher-java_0.2.3.orig.tar.gz
http://www.inf.fu-berlin.de/~rschuste/pkg-java/libescher-java_0.2.3-1.diff.gz
http://www.inf.fu-berlin.de/~rschuste/pkg-java/libescher-java_0.2.3-1.dsc
cya
Robert
--
tarent GmbH
Heilsbachstr. 24, 53123 Bonn | Poststr. 4-5, 10178 Berlin
fon: +49(228) / 52675-0 | fon: +49(30) / 27594853
fax: +49(228) / 52675-25 | fax: +49(30) / 78709617
Reply to: